refactor(agent-status): delete two launch-config accessors left with no callers (#22032)

#21844 removed the Codex launch-argument attention suppressor, which was the
last production caller of two launch-config lookups. Both were left in place
for a follow-up; this is it.

`getAgentLaunchConfigForStatusMetadata` (renderer store) looked a launch config
up from a loose metadata bag. Its sibling `getAgentLaunchConfigForStatusEntry`
takes a real status entry and still serves the one live consumer, cold restore
resume startup. Deleting the metadata accessor also orphaned its
`getLaunchConfigForStatusMetadata` helper and the
`AgentLaunchConfigStatusMetadata` parameter type, so those go too.

`getAgentStatusLaunchConfigForPaneKey` (main runtime) returned a pane's launch
config behind a launch-token fence. Its two remaining references were
assertions in the launch-authority retirement test. They were a second view of
a state bit the test already pins: retirement nulls `pty.launchToken`, and the
surviving `verifyOrchestrationCompatibilityCaller` assertion fails when it
does not. Verified by ablation — disabling only the `launchToken` nulling
fails that assertion with the accessor already gone, so no coverage is lost.
Retirement never cleared `launchConfig` itself, so there was no second
property hiding in those assertions.

Test mocks that existed only to satisfy the removed store method are stripped;
the tests themselves are about other behaviour and stay.

No behaviour change.

src/main/runtime/orca-runtime-prune-mobile-session-tab-group-layout.ts

@@ -23,8 +23,6 @@ import type {
 import { buildRuntimeMobileAgentStatus } from './runtime-mobile-agent-status-builder'
 import { FIRST_PANE_ID } from '../../shared/pane-key'
 import { isTerminalLeafId, makePaneKey, parsePaneKey } from '../../shared/stable-pane-id'
-import type { SleepingAgentLaunchConfig } from '../../shared/agent-session-resume'
-import { copySleepingAgentLaunchConfig } from './runtime-agent-launch-resolution'
 import { getStructuredAgentSessionHost } from '../native-chat/agent-session-wire/structured-agent-session-registry'
 import { replaceConversationInSnapshot } from './structured-conversation-tab-replacement'
 import { resolveStructuredWorkerAuthority } from './structured-worker-authority'
@@ -247,20 +245,6 @@ export class OrcaRuntimeWithPruneMobileSessionTabGroupLayout extends OrcaRuntime
     return this.getTerminalHandleForPaneKey(paneKey) ?? undefined
   }
 
-  getAgentStatusLaunchConfigForPaneKey(
-    paneKey: string,
-    args?: { launchToken?: string }
-  ): SleepingAgentLaunchConfig | undefined {
-    const pty = this.getPtyRecordForPaneKey(paneKey)
-    if (!pty?.launchConfig) {
-      return undefined
-    }
-    if (pty.launchToken === null || pty.launchToken !== args?.launchToken) {
-      return undefined
-    }
-    return copySleepingAgentLaunchConfig(pty.launchConfig)
-  }
-
   getTerminalHandleForPaneKey(paneKey: string): string | null {
     const parsed = parsePaneKey(paneKey)
     const leaf = parsed ? this.leaves.get(this.getLeafKey(parsed.tabId, parsed.leafId)) : undefined

src/main/runtime/orca-runtime-tests/terminal-creation-and-readiness.spec.ts

@@ -263,11 +263,6 @@ describe('OrcaRuntimeService', () => {
     }
 
     expect(runtime.verifyOrchestrationCompatibilityCaller(evidence)).not.toBeNull()
-    expect(
-      runtime.getAgentStatusLaunchConfigForPaneKey(spawnEnv.ORCA_PANE_KEY, {
-        launchToken: spawnEnv.ORCA_AGENT_LAUNCH_TOKEN
-      })
-    ).toBeDefined()
     expect((await runtime.listTerminals()).terminals).toEqual([
       expect.objectContaining({ handle: terminal.handle, agentIdentity: 'codex' })
     ])
@@ -276,11 +271,6 @@ describe('OrcaRuntimeService', () => {
 
     expect(retireAuthority).toHaveBeenCalledWith(spawnEnv.ORCA_PANE_KEY)
     expect(runtime.verifyOrchestrationCompatibilityCaller(evidence)).toBeNull()
-    expect(
-      runtime.getAgentStatusLaunchConfigForPaneKey(spawnEnv.ORCA_PANE_KEY, {
-        launchToken: spawnEnv.ORCA_AGENT_LAUNCH_TOKEN
-      })
-    ).toBeUndefined()
     expect((await runtime.listTerminals()).terminals).toEqual([
       expect.not.objectContaining({ agentIdentity: expect.anything() })
     ])

src/renderer/src/components/terminal-pane/fish-color-scheme-child-stdin.node-pty.test.ts

@@ -393,7 +393,6 @@ describe('fish never receives a color-scheme report it did not query (#9993)', (
       suppressedPtyExitIds: {},
       agentLaunchConfigByPaneKey: {},
       getAgentLaunchConfigForStatusEntry: vi.fn(),
-      getAgentLaunchConfigForStatusMetadata: vi.fn(),
       clearSleepingAgentSession: vi.fn(),
       registerAgentLaunchConfig: vi.fn(),
       clearAgentLaunchConfig: vi.fn(),

src/renderer/src/components/terminal-pane/pty-connection-agent-session-resume.test.ts

@@ -524,7 +524,6 @@ describe('connectPanePty', () => {
         }
       },
       getAgentLaunchConfigForStatusEntry: vi.fn(() => undefined),
-      getAgentLaunchConfigForStatusMetadata: vi.fn(() => undefined),
       sleepingAgentSessionsByPaneKey: {
         [paneKey]: {
           paneKey,

src/renderer/src/components/terminal-pane/pty-connection-test-store-fixtures.ts

@@ -54,13 +54,6 @@ export function createInitialStoreState(getState: () => StoreState): StoreState
     getAgentLaunchConfigForStatusEntry: vi.fn((entry: { paneKey: string }) => {
       return getState().agentLaunchConfigByPaneKey[entry.paneKey]?.launchConfig
     }),
-    getAgentLaunchConfigForStatusMetadata: vi.fn(
-      (metadata: { paneKey: string; launchToken?: string }) => {
-        return metadata.launchToken
-          ? getState().agentLaunchConfigByPaneKey[metadata.paneKey]?.launchConfig
-          : undefined
-      }
-    ),
     clearSleepingAgentSession: vi.fn((paneKey: string) => {
       delete getState().sleepingAgentSessionsByPaneKey[paneKey]
     }),

src/renderer/src/components/terminal-pane/pty-connection-test-store-state.ts

@@ -107,7 +107,6 @@ export type StoreState = {
     { launchConfig: unknown; identity?: { agentType?: string } }
   >
   getAgentLaunchConfigForStatusEntry: ReturnType<typeof vi.fn>
-  getAgentLaunchConfigForStatusMetadata: ReturnType<typeof vi.fn>
   clearSleepingAgentSession: ReturnType<typeof vi.fn>
   registerAgentLaunchConfig: ReturnType<typeof vi.fn>
   clearAgentLaunchConfig: ReturnType<typeof vi.fn>

src/renderer/src/components/terminal-pane/remote-hidden-output-restore-outcomes.test.ts

@@ -516,7 +516,6 @@ describe('remote hidden-output restore outcomes', () => {
         >
         return byPaneKey[entry.paneKey]?.launchConfig
       }),
-      getAgentLaunchConfigForStatusMetadata: vi.fn(() => undefined),
       clearSleepingAgentSession: vi.fn((paneKey: string) => {
         delete (mockStoreState.sleepingAgentSessionsByPaneKey as Record<string, unknown>)[paneKey]
       }),

src/renderer/src/components/terminal-pane/remote-hidden-output-restore-unavailable-banner.repro.test.ts

@@ -545,7 +545,6 @@ describe('remote hidden-output restore abandonment (issue2-hidden-output-skip)',
         >
         return byPaneKey[entry.paneKey]?.launchConfig
       }),
-      getAgentLaunchConfigForStatusMetadata: vi.fn(() => undefined),
       clearSleepingAgentSession: vi.fn((paneKey: string) => {
         delete (mockStoreState.sleepingAgentSessionsByPaneKey as Record<string, unknown>)[paneKey]
       }),

src/renderer/src/hooks/agent-hook-completion-background-turn-notifications.test.ts

@@ -27,7 +27,6 @@ type MockStoreState = {
   agentLaunchConfigByPaneKey: Record<string, unknown>
   agentStatusByPaneKey: Record<string, unknown>
   getAgentLaunchConfigForStatusEntry: () => undefined
-  getAgentLaunchConfigForStatusMetadata: () => undefined
 }
 
 let mockStoreState: MockStoreState
@@ -84,8 +83,7 @@ describe('Claude background-turn completion notifications', () => {
       terminalLayoutsByTabId: {},
       agentLaunchConfigByPaneKey: {},
       agentStatusByPaneKey: {},
-      getAgentLaunchConfigForStatusEntry: () => undefined,
-      getAgentLaunchConfigForStatusMetadata: () => undefined
+      getAgentLaunchConfigForStatusEntry: () => undefined
     }
   })
 

src/renderer/src/hooks/agent-hook-completion-fresh-working.test.ts

@@ -20,7 +20,6 @@ type MockStoreState = {
   agentLaunchConfigByPaneKey: Record<string, unknown>
   agentStatusByPaneKey: Record<string, unknown>
   getAgentLaunchConfigForStatusEntry: () => undefined
-  getAgentLaunchConfigForStatusMetadata: () => undefined
 }
 
 let mockStoreState: MockStoreState
@@ -64,8 +63,7 @@ describe('agent hook completion fresh-working gate', () => {
       terminalLayoutsByTabId: {},
       agentLaunchConfigByPaneKey: {},
       agentStatusByPaneKey: {},
-      getAgentLaunchConfigForStatusEntry: () => undefined,
-      getAgentLaunchConfigForStatusMetadata: () => undefined
+      getAgentLaunchConfigForStatusEntry: () => undefined
     }
   })
 

src/renderer/src/hooks/agent-hook-completion-grok-notifications.test.ts

@@ -43,7 +43,6 @@ type MockStoreState = {
   agentLaunchConfigByPaneKey: Record<string, unknown>
   agentStatusByPaneKey: Record<string, unknown>
   getAgentLaunchConfigForStatusEntry: () => undefined
-  getAgentLaunchConfigForStatusMetadata: () => undefined
 }
 
 let mockStoreState: MockStoreState
@@ -78,8 +77,7 @@ describe('Grok hook completion notifications', () => {
       terminalLayoutsByTabId: {},
       agentLaunchConfigByPaneKey: {},
       agentStatusByPaneKey: {},
-      getAgentLaunchConfigForStatusEntry: () => undefined,
-      getAgentLaunchConfigForStatusMetadata: () => undefined
+      getAgentLaunchConfigForStatusEntry: () => undefined
     }
   })
 

src/renderer/src/hooks/agent-hook-completion-notifications.test.ts

@@ -48,10 +48,6 @@ type MockStoreState = {
   getAgentLaunchConfigForStatusEntry: (entry: {
     paneKey: string
   }) => { agentArgs: string; agentEnv: Record<string, string> } | undefined
-  getAgentLaunchConfigForStatusMetadata: (metadata: {
-    paneKey: string
-    launchToken?: string
-  }) => { agentArgs: string; agentEnv: Record<string, string> } | undefined
 }
 
 let mockStoreState: MockStoreState
@@ -148,13 +144,7 @@ describe('agent hook completion notifications', () => {
       agentLaunchConfigByPaneKey: {},
       agentStatusByPaneKey: {},
       getAgentLaunchConfigForStatusEntry: (entry) =>
-        mockStoreState.agentLaunchConfigByPaneKey[entry.paneKey]?.launchConfig,
-      getAgentLaunchConfigForStatusMetadata: (metadata) =>
-        metadata.launchToken &&
-        metadata.launchToken ===
-          mockStoreState.agentLaunchConfigByPaneKey[metadata.paneKey]?.launchToken
-          ? mockStoreState.agentLaunchConfigByPaneKey[metadata.paneKey]?.launchConfig
-          : undefined
+        mockStoreState.agentLaunchConfigByPaneKey[entry.paneKey]?.launchConfig
     }
   })
 

src/renderer/src/hooks/ipc-events-agent-status-store-test-fixtures.ts

@@ -175,7 +175,6 @@ export function buildStoreState(overrides: StoreLike): StoreLike {
     setAgentStatuses: vi.fn(() => []),
     recordAgentProviderSession: vi.fn(),
     clearTransientAgentStatuses: vi.fn(),
-    getAgentLaunchConfigForStatusMetadata: vi.fn(() => undefined),
     recentlyClosedAgentStatusTabIds: {},
     repos: [],
     worktreesByRepo: {},

src/renderer/src/store/slices/agent-status-contract.ts

@@ -65,17 +65,6 @@ export type AgentLaunchConfigRegistrationMetadata = {
   providerSession?: AgentProviderSessionMetadata
 }
 
-export type AgentLaunchConfigStatusMetadata = {
-  paneKey: string
-  agentType?: AgentType
-  tabId?: string
-  terminalHandle?: string
-  launchToken?: string
-  providerSession?: AgentProviderSessionMetadata
-  existingProviderSession?: AgentProviderSessionMetadata
-  providerSessionChanged?: boolean
-}
-
 export type AgentLaunchConfigRegistryEntry = {
   launchConfig: SleepingAgentLaunchConfig
   registeredAt: number

src/renderer/src/store/slices/agent-status-launch-actions.ts

@@ -4,7 +4,6 @@ import type { AgentLaunchConfigRegistryEntry } from './agent-status-contract'
 import { copyLaunchConfig, sleepingRecordFromEntry } from './agent-status-sleeping-records'
 import {
   getLaunchConfigForEntry,
-  getLaunchConfigForStatusMetadata,
   launchConfigRegistryEntriesEqual,
   normalizeLaunchConfigRegistrationMetadata,
   registryEntryMatchesStatus
@@ -15,10 +14,7 @@ export function createAgentStatusLaunchActions(
   runtime: AgentStatusRuntime
 ): Pick<
   AgentStatusSlice,
-  | 'registerAgentLaunchConfig'
-  | 'getAgentLaunchConfigForStatusEntry'
-  | 'getAgentLaunchConfigForStatusMetadata'
-  | 'clearAgentLaunchConfig'
+  'registerAgentLaunchConfig' | 'getAgentLaunchConfigForStatusEntry' | 'clearAgentLaunchConfig'
 > {
   const { get, set } = runtime
   return {
@@ -93,9 +89,6 @@ export function createAgentStatusLaunchActions(
       })
     },
     getAgentLaunchConfigForStatusEntry: (entry) => getLaunchConfigForEntry(get(), entry),
-    getAgentLaunchConfigForStatusMetadata: (metadata) =>
-      getLaunchConfigForStatusMetadata(get(), metadata),
-
     clearAgentLaunchConfig: (paneKey) => {
       set((s) => {
         if (!(paneKey in s.agentLaunchConfigByPaneKey)) {

src/renderer/src/store/slices/agent-status-launch-config.ts

@@ -7,8 +7,7 @@ import {
 } from '../../../../shared/agent-session-resume'
 import type {
   AgentLaunchConfigRegistryEntry,
-  AgentLaunchConfigRegistrationMetadata,
-  AgentLaunchConfigStatusMetadata
+  AgentLaunchConfigRegistrationMetadata
 } from './agent-status-contract'
 import { getLeafIdFromPaneKey, getTabIdFromPaneKey } from './agent-status-pane-key-tab-binding'
 import { launchConfigsEqual } from './agent-status-recovery-equivalence'
@@ -141,23 +140,3 @@ export function getLaunchConfigForEntry(
     ? sleepingRecord.launchConfig
     : undefined
 }
-
-export function getLaunchConfigForStatusMetadata(
-  state: AppState,
-  metadata: AgentLaunchConfigStatusMetadata
-): SleepingAgentLaunchConfig | undefined {
-  const registryEntry = state.agentLaunchConfigByPaneKey[metadata.paneKey]
-  return registryEntryMatchesStatus({
-    entry: registryEntry,
-    paneKey: metadata.paneKey,
-    agentType: metadata.agentType,
-    tabId: metadata.tabId ?? getTabIdFromPaneKey(metadata.paneKey) ?? undefined,
-    terminalHandle: metadata.terminalHandle,
-    launchToken: metadata.launchToken,
-    providerSession: metadata.providerSession,
-    existingProviderSession: metadata.existingProviderSession,
-    providerSessionChanged: metadata.providerSessionChanged ?? false
-  })
-    ? registryEntry?.launchConfig
-    : undefined
-}

src/renderer/src/store/slices/agent-status-slice-contract.ts

@@ -1,7 +1,6 @@
 import type {
   AgentLaunchConfigRegistryEntry,
   AgentLaunchConfigRegistrationMetadata,
-  AgentLaunchConfigStatusMetadata,
   AgentProviderSessionRecordMetadata,
   AgentProviderSessionRouting,
   AgentProviderSessionTiming,
@@ -112,9 +111,6 @@ export type AgentStatusSlice = {
   getAgentLaunchConfigForStatusEntry: (
     entry: AgentStatusEntry
   ) => SleepingAgentLaunchConfig | undefined
-  getAgentLaunchConfigForStatusMetadata: (
-    metadata: AgentLaunchConfigStatusMetadata
-  ) => SleepingAgentLaunchConfig | undefined
   clearAgentLaunchConfig: (paneKey: string) => void
 
   setRuntimeAgentOrchestrationByPaneKey: (

src/renderer/src/store/slices/agent-status.ts

@@ -17,7 +17,6 @@ import { createAgentStatusRetentionActions } from './agent-status-retention-acti
 export type {
   AgentLaunchConfigRegistryEntry,
   AgentLaunchConfigRegistrationMetadata,
-  AgentLaunchConfigStatusMetadata,
   AgentProviderSessionRecordMetadata,
   AgentProviderSessionRouting,
   AgentProviderSessionTiming,

tests/e2e/paired-runtime-rejected-input-remount.unit.test.ts

@@ -323,7 +323,6 @@ describe('host-rejected paired-runtime input reaches a pane remount', () => {
       suppressedPtyExitIds: {},
       agentLaunchConfigByPaneKey: {},
       getAgentLaunchConfigForStatusEntry: vi.fn(),
-      getAgentLaunchConfigForStatusMetadata: vi.fn(),
       clearSleepingAgentSession: vi.fn(),
       registerAgentLaunchConfig: vi.fn(),
       clearAgentLaunchConfig: vi.fn(),