test: remove two low-value copy and language retry suites (#43051)

Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
This commit is contained in:
OrcaWin
2026-11-16 01:16:18 -08:00
committed by GitHub
co-authored by OrcaWin
parent 083a9a8f4d
commit 84da54ae3d
4 changed files with 2 additions and 249 deletions
File diff suppressed because one or more lines are too long
@@ -16,11 +16,7 @@ function featureRoute(id, specs, prefixes) {
// Feature areas whose specs the nightly suite alone used to select (gap audit, Oct 2026).
export const PR_FEATURE_AREA_E2E_SOURCE_ROUTES = [
featureRoute('feature.sparse-checkout', ['sparse-explorer-proof'], [`${COMPONENTS}sparse/`]),
featureRoute(
'feature.onboarding',
['onboarding', 'onboarding-language-catalog-retry'],
[`${COMPONENTS}onboarding/`]
),
featureRoute('feature.onboarding', ['onboarding'], [`${COMPONENTS}onboarding/`]),
featureRoute(
'feature.diff-notes',
[
@@ -1,119 +0,0 @@
// @vitest-environment happy-dom
import type { ReactNode } from 'react'
import { cleanup, fireEvent, render, screen, waitFor } from '@testing-library/react'
import { afterEach, describe, expect, it, vi } from 'vitest'
import type { LinkActionRequest } from './link-action-request'
const mocks = vi.hoisted(() => ({
openSettingsPage: vi.fn(),
openSettingsTarget: vi.fn(),
toastError: vi.fn(),
toastSuccess: vi.fn(),
writeClipboardText: vi.fn()
}))
vi.mock('sonner', () => ({
toast: { error: mocks.toastError, success: mocks.toastSuccess }
}))
vi.mock('@/store', () => ({
useAppStore: (
selector: (state: {
openSettingsPage: () => void
openSettingsTarget: (target: unknown) => void
}) => unknown
) =>
selector({
openSettingsPage: mocks.openSettingsPage,
openSettingsTarget: mocks.openSettingsTarget
})
}))
vi.mock('@/components/ui/tooltip', () => ({
Tooltip: ({ children }: { children: ReactNode }) => children,
TooltipTrigger: ({ children }: { children: ReactNode }) => children,
TooltipContent: ({ children }: { children: ReactNode }) => <span>{children}</span>
}))
vi.mock('@/components/ui/popover', () => ({
Popover: ({
children,
open,
onOpenChange
}: {
children: ReactNode
open: boolean
onOpenChange: (open: boolean) => void
}) =>
open ? (
<div>
<button data-testid="dismiss-popover" onClick={() => onOpenChange(false)} />
{children}
</div>
) : null,
PopoverAnchor: () => null,
PopoverContent: ({ children, className }: { children: ReactNode; className?: string }) => (
<div className={className}>{children}</div>
)
}))
import { LinkActionPopover } from './LinkActionPopover'
afterEach(() => {
cleanup()
vi.clearAllMocks()
vi.unstubAllGlobals()
})
describe('LinkActionPopover', () => {
it('ignores duplicate copy clicks while the clipboard write is in flight', async () => {
vi.stubGlobal('navigator', { userAgent: 'Macintosh' })
Object.assign(window, { api: { ui: { writeClipboardText: mocks.writeClipboardText } } })
let resolveWrite: (() => void) | undefined
mocks.writeClipboardText.mockReturnValue(
new Promise<void>((resolve) => {
resolveWrite = resolve
})
)
const request: LinkActionRequest = {
anchorX: 100,
anchorY: 200,
destination: 'https://example.com/hidden-destination',
kind: 'url',
primary: { label: 'Open link', run: vi.fn() },
restoreFocus: vi.fn()
}
render(<LinkActionPopover request={request} onClose={vi.fn()} />)
const copyButton = screen.getByRole('button', { name: 'Copy link' })
fireEvent.click(copyButton)
fireEvent.click(copyButton)
expect(mocks.writeClipboardText).toHaveBeenCalledOnce()
resolveWrite?.()
await waitFor(() => expect(mocks.toastSuccess).toHaveBeenCalledOnce())
fireEvent.click(copyButton)
await waitFor(() => expect(mocks.writeClipboardText).toHaveBeenCalledTimes(2))
})
it('shows a failure toast when copying fails', async () => {
vi.stubGlobal('navigator', { userAgent: 'Macintosh' })
Object.assign(window, { api: { ui: { writeClipboardText: mocks.writeClipboardText } } })
mocks.writeClipboardText.mockRejectedValue(new Error('denied'))
const request: LinkActionRequest = {
anchorX: 100,
anchorY: 200,
destination: 'https://example.com/hidden-destination',
kind: 'url',
primary: { label: 'Open link', run: vi.fn() },
restoreFocus: vi.fn()
}
render(<LinkActionPopover request={request} onClose={vi.fn()} />)
fireEvent.click(screen.getByRole('button', { name: 'Copy link' }))
await waitFor(() => expect(mocks.toastError).toHaveBeenCalledWith('Failed to copy link'))
fireEvent.click(screen.getByRole('button', { name: 'Copy link' }))
await waitFor(() => expect(mocks.writeClipboardText).toHaveBeenCalledTimes(2))
})
})
@@ -1,122 +0,0 @@
import { test, expect } from './helpers/orca-app'
test.use({ dismissOnboarding: false, seedTestRepo: false })
test('recovers rejected language catalogs without reloading', async ({
electronApp,
orcaPage
}, testInfo) => {
const startupLanguage = await orcaPage.evaluate(async () => {
const detection = await window.api.app.getSystemLanguageDetection?.([navigator.language])
return detection?.locale
})
const candidates = (
[
{ locale: 'fr', name: 'Français', title: 'Langue d’affichage' },
{ locale: 'ja', name: '日本語', title: '表示言語' },
{ locale: 'es', name: 'Español', title: 'Idioma de la interfaz' }
] as const
).filter((candidate) => candidate.locale !== startupLanguage)
const [first, second] = candidates
if (!first || !second) {
throw new Error('Two unloaded languages are required')
}
await orcaPage.evaluate(async () => {
const store = window.__store
if (!store) {
throw new Error('Renderer store unavailable')
}
const settings = await window.api.settings.get()
if (!settings.telemetry) {
throw new Error('Telemetry settings unavailable')
}
await store.getState().updateSettingsOrThrow({
uiLanguage: 'en',
telemetry: { ...settings.telemetry, onboardingLanguageCohort: 'control' }
})
})
const language = first.locale
const catalogPattern = new RegExp(`/${language}-[^/]+\\.(?:json|js)(?:\\?|$)`)
await electronApp.evaluate(({ session }, selectedLanguage) => {
const pattern = new RegExp(`/${selectedLanguage}-[^/]+\\.(?:json|js)(?:\\?|$)`)
session.defaultSession.webRequest.onBeforeRequest((details, callback) => {
callback({ cancel: pattern.test(details.url) })
})
}, language)
const rejected = orcaPage.waitForEvent('requestfailed', {
predicate: (request) => catalogPattern.test(request.url())
})
const timeOrigin = await orcaPage.evaluate(() => performance.timeOrigin)
await orcaPage.evaluate(async (selectedLanguage) => {
const store = window.__store
if (!store) {
throw new Error('Renderer store unavailable')
}
await store.getState().updateSettingsOrThrow({
uiLanguage: selectedLanguage
})
}, language)
const failedRequest = await rejected
await orcaPage.getByRole('button', { name: /^Language/ }).click()
// Why by title: onboarding is a dialog too; the picker's title follows the active language.
const picker = orcaPage.getByRole('dialog', {
name: new RegExp(`^(Display language|${first.title}|${second.title})$`)
})
// Why a prefix match: a row's name also carries its muted English gloss and state text.
const row = (name: string) => picker.getByRole('button', { name: new RegExp(`^${name}`) })
await expect(picker.getByRole('alert')).toContainText(first.name)
await orcaPage.screenshot({ path: testInfo.outputPath('catalog-request-rejected.png') })
await electronApp.evaluate(({ session }) => {
session.defaultSession.webRequest.onBeforeRequest(null)
})
expect(
await orcaPage.evaluate(async (url) => (await fetch(url)).status, failedRequest.url())
).toBe(200)
await picker.getByRole('alert').getByRole('button', { name: 'Retry', exact: true }).click()
await expect(row(first.name)).toHaveAttribute('aria-current', 'true')
await expect(orcaPage.getByRole('dialog', { name: first.title, exact: true })).toBeVisible()
await expect(picker.getByRole('alert')).toHaveCount(0)
await expect
.poll(() => orcaPage.evaluate(() => window.api.settings.get().then((s) => s.uiLanguage)))
.toBe(language)
expect(await orcaPage.evaluate(() => performance.timeOrigin)).toBe(timeOrigin)
await orcaPage.screenshot({ path: testInfo.outputPath('catalog-retry-recovered.png') })
const nextLanguage = second.locale
const nextName = second.name
const previousName = first.name
const nextPattern = new RegExp(`/${nextLanguage}-[^/]+\\.(?:json|js)(?:\\?|$)`)
await electronApp.evaluate(({ session }, selectedLanguage) => {
const pattern = new RegExp(`/${selectedLanguage}-[^/]+\\.(?:json|js)(?:\\?|$)`)
session.defaultSession.webRequest.onBeforeRequest((details, callback) => {
callback({ cancel: pattern.test(details.url) })
})
}, nextLanguage)
const nextRejected = orcaPage.waitForEvent('requestfailed', {
predicate: (request) => nextPattern.test(request.url())
})
await row(nextName).click()
await nextRejected
// Why on the row: a failed switch reports under the language that was chosen.
await expect(row(nextName)).toHaveAttribute('aria-describedby', /.+/)
await expect(picker.getByRole('alert')).toBeVisible()
await expect(row(previousName)).toHaveAttribute('aria-current', 'true')
await expect
.poll(() => orcaPage.evaluate(() => window.api.settings.get().then((s) => s.uiLanguage)))
.toBe(language)
await electronApp.evaluate(({ session }) => {
session.defaultSession.webRequest.onBeforeRequest(null)
})
// Why the row: choosing the failed language again is the retry.
await row(nextName).click()
await expect(row(nextName)).toHaveAttribute('aria-current', 'true')
await expect(orcaPage.getByRole('dialog', { name: second.title, exact: true })).toBeVisible()
await expect(picker.getByRole('alert')).toHaveCount(0)
await expect
.poll(() => orcaPage.evaluate(() => window.api.settings.get().then((s) => s.uiLanguage)))
.toBe(nextLanguage)
expect(await orcaPage.evaluate(() => performance.timeOrigin)).toBe(timeOrigin)
})