starred/orca
1
0
Fork 0
mirror of https://github.com/stablyai/orca.git synced 2026-10-20 16:03:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix undeclared dynamic localization key check

Browse Source
This commit is contained in:
Brennan Benson
2026-07-29 16:57:13 -07:00
parent c1ee448bcd
commit 885884034d
2 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
config/scripts/verify-localization-extraction.mjs
+1 -4
View File
@@ -34,10 +34,7 @@ export function compareExtraction(extractedCatalog, englishCatalog) {
const dynamicDefaults = [...extracted.entries()]
.filter(([, value]) => value.length === 0)
.map(([key]) => key)
const missingFromEnglish = [...extracted.entries()]
.filter(([, value]) => value.length > 0)
.map(([key]) => key)
.filter((key) => !english.has(key))
const missingFromEnglish = [...extracted.keys()].filter((key) => !english.has(key))
const orphans = [...english.keys()].filter((key) => !extracted.has(key))
const fallbackDrift = []
const placeholderMismatches = []
config/scripts/verify-localization-extraction.test.mjs
+6
View File
@@ -25,6 +25,12 @@ describe('verify-localization-extraction', () => {
expect(result.placeholderMismatches).toEqual([])
})
it('rejects undeclared keys even when their defaults are dynamic', () => {
const result = compareExtraction({ menu: { dynamic: '' } }, {})
expect(result.missingFromEnglish).toEqual(['menu.dynamic'])
})
it('rejects missing English declarations and incompatible placeholders', () => {
const result = compareExtraction(
{