Use current chat test fixtures and name the handover journal owner

This commit is contained in:
Brennan Benson
2026-11-09 02:21:18 -08:00
parent f1cd02bc41
commit 889a3233fe
16 changed files with 21 additions and 20 deletions
@@ -3,9 +3,10 @@
import type { AgentJournalSubmission } from '../../../../shared/agent-session/journal/agent-session-journal-types'
import type { UnsentSendHold } from '../../agent-session-journal/queued-messages/journal-unsent-send-hold'
import type { AgentSessionJournal } from '../../agent-session-journal/journal-store'
/** The chat's journal, which identifies the conversation for as long as it is held. */
type HandoverJournal = object
type HandoverJournal = AgentSessionJournal
type HandoverInput = {
owner: () => void
@@ -174,7 +175,7 @@ export function beginStructuredAgentSessionHandover(
/** Finite policy snapshots retain their synchronous membership check. Live handles read it in-worker. */
function hasSubmissionSnapshot(
journal: object
): journal is { submission: (id: string) => AgentJournalSubmission | undefined } {
journal: HandoverJournal
): journal is HandoverJournal & { submission: (id: string) => AgentJournalSubmission | undefined } {
return 'submission' in journal && typeof journal.submission === 'function'
}
@@ -33,7 +33,7 @@ import {
import { StructuredAgentSessionHost } from '../../src/main/native-chat/agent-session-wire/host/structured-agent-session-host'
import { setStructuredAgentSessionHost } from '../../src/main/native-chat/agent-session-wire/host/structured-agent-session-registry'
import { structuredAgentsDeclaringNothing } from '../../src/main/native-chat/agent-session-wire/providers/testing/structured-agent-session-adapter-router-test-support'
import { recordingStructuredAgentSessionLogger } from '../../src/main/native-chat/agent-session-wire/host/testing/structured-agent-session-logger-test-support'
import { recordingStructuredAgentSessionLogger } from '../../src/main/native-chat/agent-session-wire/host/testing/structured-agent-session-logger.test-fixture'
import { createStructuredChatNamingHandler } from '../../src/main/native-chat/structured-chat-naming'
import { PI_RPC_AGENT } from '../../src/main/pi/rpc-agent-definition'
import type { AgentSessionStatusEvent } from '../../src/shared/agent-session/agent-session-wire'
@@ -12,7 +12,7 @@ import {
HOST_TEST_NOW,
HOST_TEST_SESSION,
HOST_TEST_LOCATION
} from '../../src/main/native-chat/agent-session-wire/host/testing/structured-agent-session-host-test-data'
} from '../../src/main/native-chat/agent-session-wire/host/testing/structured-agent-session-host-test-data.test-fixture'
import type { callStructuredAgentSession } from '@/runtime/structured-agent-session-client'
import type { StructuredAgentSessionHost } from '../../src/main/native-chat/agent-session-wire/host/structured-agent-session-host'
import { createQueuedMessageTestRig } from '../../src/main/native-chat/agent-session-wire/host/testing/structured-agent-session-queued-message-rig.test-fixture'
@@ -25,7 +25,7 @@ import { CODEX_COMMAND_APPROVAL_METHOD } from '../../src/main/codex/structured/p
import { createTrackedJournalOpener } from '../../src/main/native-chat/agent-session-journal/store-lifecycle/journal-host-database-test-support'
import { createDeferredStructuredAgentSessionEventSink } from '../../src/main/native-chat/agent-session-wire/journal-ingress/structured-agent-session-event-sink'
import { StructuredAgentSessionStatusFeed } from '../../src/main/native-chat/agent-session-wire/observations/structured-agent-session-status-feed'
import { indexedStatusFeedSession } from '../../src/main/native-chat/agent-session-wire/observations/testing/structured-agent-session-status-feed-test-session'
import { indexedStatusFeedSession } from '../../src/main/native-chat/agent-session-wire/observations/testing/structured-agent-session-status-feed-test-session.test-fixture'
import {
makeRepo,
makeWorktree
@@ -67,7 +67,7 @@ vi.mock('@/runtime/structured-agent-session-client', () => ({
import { StructuredAgentSessionStatusBridge } from '../../src/renderer/src/components/native-chat/session/status/StructuredAgentSessionStatusBridge'
import { resetStructuredAgentSessionStatusFeedsForTests } from '../../src/renderer/src/runtime/structured-agent-session-status-feed'
import { createStructuredAgentSessionLogger } from '../../src/main/native-chat/agent-session-wire/host/structured-agent-session-logger'
import { testEventSinkLogging } from '../../src/main/native-chat/agent-session-wire/host/testing/structured-agent-session-logger-test-support'
import { testEventSinkLogging } from '../../src/main/native-chat/agent-session-wire/host/testing/structured-agent-session-logger.test-fixture'
import { codexProviderHandle } from '../../src/shared/agent-session/lifecycle/agent-session-provider-handle-encoding'
const SESSION = 'codex-child-approval'
@@ -11,7 +11,7 @@ import { eventually } from '../../../src/main/native-chat/agent-session-wire/hos
import {
HOST_TEST_SESSION as SESSION,
hostTestOperationId
} from '../../../src/main/native-chat/agent-session-wire/host/testing/structured-agent-session-host-test-data'
} from '../../../src/main/native-chat/agent-session-wire/host/testing/structured-agent-session-host-test-data.test-fixture'
import { agentJournalSubmissionKey } from '../../../src/shared/agent-session/journal/agent-session-journal-item-key'
import { EMPTY_STRUCTURED_AGENT_SESSION } from '../../../src/shared/agent-session/structured-agent-session-reducer'
import type { useNativeChatRewind } from '../../../src/renderer/src/components/native-chat/use-native-chat-rewind'
@@ -3,7 +3,7 @@ import { importReleaseCheckoutModule, materializeReleaseCheckout } from './relea
import {
HOST_TEST_SESSION,
HOST_TEST_NOW
} from '../../../src/main/native-chat/agent-session-wire/host/testing/structured-agent-session-host-test-data'
} from '../../../src/main/native-chat/agent-session-wire/host/testing/structured-agent-session-host-test-data.test-fixture'
import {
WORKTREE,
createChat,
@@ -7,7 +7,7 @@ import { listResult } from '../../../src/main/ai-vault/structured-session-owners
import {
HOST_TEST_SESSION,
HOST_TEST_LOCATION
} from '../../../src/main/native-chat/agent-session-wire/host/testing/structured-agent-session-host-test-data'
} from '../../../src/main/native-chat/agent-session-wire/host/testing/structured-agent-session-host-test-data.test-fixture'
import {
WORKTREE,
createChat,
@@ -8,7 +8,7 @@ import { afterEach, beforeAll, beforeEach, describe, expect, it, vi } from 'vite
import type { StructuredAgentSessionAdapter } from '../../../src/main/native-chat/agent-session-wire/providers/structured-agent-session-adapter'
import { StructuredAgentSessionHost } from '../../../src/main/native-chat/agent-session-wire/host/structured-agent-session-host'
import { emptyAgentSessionBatch } from '../../../src/main/native-chat/agent-session-wire/publication/subscribers/agent-session-empty-batch'
import { startsWhenPublished } from '../../../src/main/native-chat/agent-session-wire/host/testing/structured-agent-session-instant-start.test-support'
import { startsWhenPublished } from '../../../src/main/native-chat/agent-session-wire/host/testing/structured-agent-session-instant-start.test-fixture'
import { setStructuredAgentSessionHost } from '../../../src/main/native-chat/agent-session-wire/host/structured-agent-session-registry'
import type { AgentSessionRecordStore } from '../../../src/main/runtime/agent-session/records/agent-session-record-store'
import { openTestAgentSessionRecordStore } from '../../../src/main/runtime/agent-session/records/agent-session-record-store-test-harness'
@@ -4,7 +4,7 @@ import { join } from 'node:path'
import { afterEach, beforeAll, beforeEach, expect } from 'vitest'
import { StructuredAgentSessionHost } from '../../../src/main/native-chat/agent-session-wire/host/structured-agent-session-host'
import { NO_STRUCTURED_AGENTS } from '../../../src/main/native-chat/agent-session-wire/providers/testing/structured-agent-session-adapter-router-test-support'
import { startsWhenPublished } from '../../../src/main/native-chat/agent-session-wire/host/testing/structured-agent-session-instant-start.test-support'
import { startsWhenPublished } from '../../../src/main/native-chat/agent-session-wire/host/testing/structured-agent-session-instant-start.test-fixture'
import { setStructuredAgentSessionHost } from '../../../src/main/native-chat/agent-session-wire/host/structured-agent-session-registry'
import { createStructuredAgentSessionLogger } from '../../../src/main/native-chat/agent-session-wire/host/structured-agent-session-logger'
import { openTestAgentSessionRecordStore } from '../../../src/main/runtime/agent-session/records/agent-session-record-store-test-harness'
@@ -19,7 +19,7 @@ import {
HOST_TEST_SESSION as REST_TEST_SESSION,
hostTestAttachParams,
hostTestOperationId
} from '../../../src/main/native-chat/agent-session-wire/host/testing/structured-agent-session-host-test-data'
} from '../../../src/main/native-chat/agent-session-wire/host/testing/structured-agent-session-host-test-data.test-fixture'
import { setStructuredAgentSessionHost } from '../../../src/main/native-chat/agent-session-wire/host/structured-agent-session-registry'
import { computeAgentSessionPayloadFingerprint } from '../../../src/shared/agent-session/lifecycle/agent-session-mutation-envelope'
@@ -2,7 +2,7 @@ import { agentSessionRecordFixture } from '../../../src/shared/agent-session/lif
import { agentSessionConversationView } from '../../../src/shared/agent-session/lifecycle/agent-session-conversation-view'
import { vi, type Mock } from 'vitest'
import type { StructuredAgentSessionAdapter } from '../../../src/main/native-chat/agent-session-wire/providers/structured-agent-session-adapter'
import { startsWhenPublished } from '../../../src/main/native-chat/agent-session-wire/host/testing/structured-agent-session-instant-start.test-support'
import { startsWhenPublished } from '../../../src/main/native-chat/agent-session-wire/host/testing/structured-agent-session-instant-start.test-fixture'
import type { AgentSessionRecordStore } from '../../../src/main/runtime/agent-session/records/agent-session-record-store'
import { codexProviderHandle } from '../../../src/shared/agent-session/lifecycle/agent-session-provider-handle-encoding'
import type { StructuredAgentSessionHost } from '../../../src/main/native-chat/agent-session-wire/host/structured-agent-session-host'
@@ -22,7 +22,7 @@ import {
HOST_TEST_NOW,
HOST_TEST_THREAD,
HOST_TEST_LOCATION
} from '../../../src/main/native-chat/agent-session-wire/host/testing/structured-agent-session-host-test-data'
} from '../../../src/main/native-chat/agent-session-wire/host/testing/structured-agent-session-host-test-data.test-fixture'
import { createQueuedMessageTestRig } from '../../../src/main/native-chat/agent-session-wire/host/testing/structured-agent-session-queued-message-rig.test-fixture'
import { eventually } from '../../../src/main/native-chat/agent-session-wire/host/testing/structured-agent-session-queued-message-rig-provider.test-fixture'
@@ -43,7 +43,7 @@ import type { JournalRow } from '../../src/main/native-chat/agent-session-journa
import {
hostTestAttachParams,
HOST_TEST_SESSION as SESSION
} from '../../src/main/native-chat/agent-session-wire/host/testing/structured-agent-session-host-test-data'
} from '../../src/main/native-chat/agent-session-wire/host/testing/structured-agent-session-host-test-data.test-fixture'
import { seedQueuedRigLegacyJournal } from '../../src/main/native-chat/agent-session-wire/host/testing/structured-agent-session-queued-legacy-journal.test-fixture'
import {
createRestTestRig,
@@ -5,7 +5,7 @@ import { createElement } from 'react'
import { afterEach, expect, it, vi } from 'vitest'
import { computeAgentSessionPayloadFingerprint } from '../../src/shared/agent-session/lifecycle/agent-session-mutation-envelope'
import { claudeSessionIdForOrcaSession } from '../../src/main/claude/structured/claude-structured-session-id'
import { hostTestMessage } from '../../src/main/native-chat/agent-session-wire/host/testing/structured-agent-session-host-test-data'
import { hostTestMessage } from '../../src/main/native-chat/agent-session-wire/host/testing/structured-agent-session-host-test-data.test-fixture'
import { StructuredAgentSessionStartupAttempts } from '../../src/main/native-chat/agent-session-wire/startup/structured-agent-session-startup-attempt'
import { createScriptedClaudeRuntime } from '../../src/main/runtime/agent-session/installation/structured-claude-scripted-runtime-test-support'
import { TooltipProvider } from '../../src/renderer/src/components/ui/tooltip'
@@ -13,7 +13,7 @@ import {
import {
HOST_TEST_LOCATION,
HOST_TEST_SESSION
} from '../../src/main/native-chat/agent-session-wire/host/testing/structured-agent-session-host-test-data'
} from '../../src/main/native-chat/agent-session-wire/host/testing/structured-agent-session-host-test-data.test-fixture'
import { OrcaRuntimeService } from '../../src/main/runtime/orca-runtime'
import { readPersistedTestAgentSessionStore } from '../../src/main/runtime/agent-session/records/agent-session-record-store-test-harness'
import { openTestJournalHostDatabase } from '../../src/main/native-chat/agent-session-journal/store-lifecycle/journal-host-database-test-support'
@@ -34,11 +34,11 @@ import {
attachParams,
envelope,
CALLER
} from '../../src/main/native-chat/agent-session-wire/host/testing/structured-agent-session-host-test-harness'
} from '../../src/main/native-chat/agent-session-wire/host/testing/structured-agent-session-host.test-fixture'
import {
HOST_TEST_NOW,
HOST_TEST_SESSION as sessionId
} from '../../src/main/native-chat/agent-session-wire/host/testing/structured-agent-session-host-test-data'
} from '../../src/main/native-chat/agent-session-wire/host/testing/structured-agent-session-host-test-data.test-fixture'
import { setLocalRuntimeCapabilitiesForTests } from '@/runtime/hosts/capabilities/local-runtime-capabilities'
import { AGENT_SESSION_PERMISSION_OWN_RUNTIME_CAPABILITY } from '../../src/shared/agent-session/agent-session-permission-modes-capability'
import { resetStructuredAgentSessionStatusFeedsForTests } from '@/runtime/structured-agent-session-status-feed'