starred/orca
1
0
Fork 0
mirror of https://github.com/stablyai/orca.git synced 2026-09-28 16:02:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: guard pr reviewer removal state (#3671)

Browse Source
This commit is contained in:
Neil
2026-05-30 05:39:29 -07:00
committed by GitHub
parent c858c6f89e
commit 8f07d45a96
2 changed files with 18 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/renderer/src/components/GitHubItemDialog.tsx
+9 -2
View File
@@ -748,6 +748,9 @@ function PRReviewersPanel({
prNumber: item.number,
reviewers: logins
})
if (!reviewerPanelMountedRef.current) {
return
}
if (!result.ok) {
toast.error(result.error ?? 'Failed to remove reviewer')
return
@@ -762,9 +765,13 @@ function PRReviewersPanel({
setReviewerInput('')
toast.success(logins.length === 1 ? 'Reviewer removed' : 'Reviewers removed')
} catch {
toast.error('Failed to remove reviewer')
if (reviewerPanelMountedRef.current) {
toast.error('Failed to remove reviewer')
}
} finally {
setSubmitting(false)
if (reviewerPanelMountedRef.current) {
setSubmitting(false)
}
}
}
src/renderer/src/components/PullRequestPage.tsx
+9 -2
View File
@@ -748,6 +748,9 @@ function PRReviewersPanel({
prNumber: item.number,
reviewers: logins
})
if (!reviewerPanelMountedRef.current) {
return
}
if (!result.ok) {
toast.error(result.error ?? 'Failed to remove reviewer')
return
@@ -762,9 +765,13 @@ function PRReviewersPanel({
setReviewerInput('')
toast.success(logins.length === 1 ? 'Reviewer removed' : 'Reviewers removed')
} catch {
toast.error('Failed to remove reviewer')
if (reviewerPanelMountedRef.current) {
toast.error('Failed to remove reviewer')
}
} finally {
setSubmitting(false)
if (reviewerPanelMountedRef.current) {
setSubmitting(false)
}
}
}