starred/orca
1
0
Fork 0
mirror of https://github.com/stablyai/orca.git synced 2026-10-07 00:02:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Preserve OpenCode named errors without a data message

Browse Source
This commit is contained in:
Neil
2026-10-02 05:25:23 -07:00
parent 1b60ec5d11
commit 98fdecc7a3
2 changed files with 26 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/shared/opencode-generation-output.test.ts
+25 -8
View File
@@ -55,13 +55,30 @@ describe('OpenCode generation event output', () => {
})
})
it.each(['{broken', '{"title":"not an event"}', 'null'])(
'rejects malformed events %s',
(output) => {
expect(parseOpenCodeGenerationOutput(output)).toEqual({
ok: false,
error: 'OpenCode returned invalid JSON events.'
})
it.each([
{ error: { name: 'MessageOutputLengthError', data: {} }, expected: 'MessageOutputLengthError' },
{
error: { name: 'ProviderError', data: { retryable: false } },
expected: 'ProviderError'
},
{
error: { name: 'ProviderError', message: 'Provider rejected the request', data: {} },
expected: 'Provider rejected the request'
}
)
])('reports named errors without a data message', ({ error, expected }) => {
const output = `${frame('text', 'partial')}\n${JSON.stringify({ type: 'error', error })}`
expect(parseOpenCodeGenerationOutput(output)).toEqual({ ok: false, error: expected })
})
it.each([
'{broken',
'{"title":"not an event"}',
'null',
JSON.stringify({ type: 'error', error: { name: 'ProviderError', data: { message: 42 } } })
])('rejects malformed events %s', (output) => {
expect(parseOpenCodeGenerationOutput(output)).toEqual({
ok: false,
error: 'OpenCode returned invalid JSON events.'
})
})
})
src/shared/opencode-generation-output.ts
+1 -1
View File
@@ -7,7 +7,7 @@ const eventSchema = z.object({
.object({
name: z.string().optional(),
message: z.string().optional(),
data: z.object({ message: z.string() }).optional()
data: z.object({ message: z.string().optional() }).optional()
})
.optional()
})