starred/orca
1
0
Fork 0
mirror of https://github.com/stablyai/orca.git synced 2026-09-22 00:02:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(sidebar): let heuristic 'working' beat retained 'done' in worktree dot (#1228)

Browse Source 
Co-authored-by: Orca <help@stably.ai>
This commit is contained in:
Brennan Benson
2026-04-28 14:06:19 -07:00
committed by GitHub
co-authored by Orca
parent e4f9c2496f
commit af284dbac7
1 changed files with 15 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/renderer/src/components/sidebar/WorktreeCard.tsx
+15 -3
View File
@@ -154,10 +154,16 @@ const WorktreeCard = React.memo(function WorktreeCard({
// consulted too so the sky dot keeps glowing after the agent process exits,
// matching the dashboard's retention behavior.
//
// Priority (highest first): permission (blocked/waiting) > done > heuristic.
// permission wins over done because a newer blocked agent in the same
// Priority (highest first): permission (blocked/waiting) > heuristic
// 'working' > done > other heuristic ('active'/'inactive').
// permission wins over everything because a newer blocked agent in the same
// worktree means the user needs to act now, not admire a previous
// completion.
// heuristic 'working' wins over done because a spinner means the user has
// already re-prompted the agent after it reported done — the newer "work
// in progress" signal is more informative than a retained completion dot.
// Only the 'working' heuristic earns this precedence; 'active'/'inactive'
// mean "quiet terminal", which shouldn't drown out a recent done.
// Why: collapse live hook entries to booleans inside the selector so the
// snapshot is a stable scalar (useShallow compares element identity — an
// array of freshly-constructed {state,updatedAt} objects would never hit
@@ -217,10 +223,16 @@ const WorktreeCard = React.memo(function WorktreeCard({
if (hasPermission) {
return 'permission'
}
// Compute the heuristic once so we can let 'working' beat done without
// letting quieter heuristic states ('active'/'inactive') erase a done.
const heuristic = getWorktreeStatus(tabs, browserTabs, runtimePaneTitlesForWorktree)
if (heuristic === 'working') {
return 'working'
}
if (hasLiveDone || hasRetainedDone) {
return 'done'
}
return getWorktreeStatus(tabs, browserTabs, runtimePaneTitlesForWorktree)
return heuristic
}, [tabs, browserTabs, runtimePaneTitlesForWorktree, hasPermission, hasLiveDone, hasRetainedDone])
const showPR = cardProps.includes('pr')