starred/orca
1
0
Fork 0
mirror of https://github.com/stablyai/orca.git synced 2026-09-22 00:02:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

perf(vault): look up resume worktrees through the shared index (#11317)

Browse Source 
Resolving a session's resume target scanned every worktree in every repo:
two `Object.values(worktreesByRepo).flat().find(...)` calls, which also
allocate a fresh 1124-element array each time, plus an equivalent `some()`
walk. All three run per visible session row, so a panel render repeated
them ~20 times.

`getIndexedWorktreeMap` already exists for this and is WeakMap-cached on
`worktreesByRepo`, so the index is built once per store snapshot rather
than per call. `connection-owner-resolution.ts` already resolves worktrees
this way.

~1.6ms -> ~0.002ms per render pass at 1124 worktrees. Net -4 lines.

Behavior is unchanged: the map dedupes by id, which only diverges from
`find()` when one id appears twice with different objects. Worktree ids are
`repoId::path`, so a duplicate id within a repo array — the documented race
the index was built for — refers to the same worktree.
This commit is contained in:
Neil
2026-07-29 00:20:47 -07:00
committed by GitHub
parent 6cc579a48c
commit b4b3bcdb84
2 changed files with 5 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/renderer/src/components/right-sidebar/ai-vault-session-resume.ts
+2 -3
View File
@@ -9,6 +9,7 @@ import {
type AiVaultSession
} from '../../../../shared/ai-vault-types'
import type { AppState } from '@/store/types'
import { getIndexedWorktreeMap } from '@/store/worktree-repo-index'
import { translate } from '@/i18n/i18n'
import { parseWorkspaceKey } from '../../../../shared/workspace-scope'
import {
@@ -145,9 +146,7 @@ export function isKnownAiVaultResumeWorkspaceTarget(
}
const worktreeId = workspaceKey?.type === 'worktree' ? workspaceKey.worktreeId : workspaceId
return Object.values(state.worktreesByRepo).some((worktrees) =>
worktrees.some((worktree) => worktree.id === worktreeId)
)
return getIndexedWorktreeMap(state.worktreesByRepo).has(worktreeId)
}
function resolveSupportedResumeWorktreeId(args: {
src/renderer/src/lib/ai-vault-resume-target.ts
+3 -6
View File
@@ -11,6 +11,7 @@ import { getRepoIdFromWorktreeId } from '../../../shared/worktree-id'
import { parseWorkspaceKey } from '../../../shared/workspace-scope'
import { isWslUncPath } from '../../../shared/wsl-paths'
import type { AppState } from '@/store/types'
import { getIndexedWorktreeMap } from '@/store/worktree-repo-index'
import { getFolderWorkspaceCandidateRepos } from './folder-workspace-connection'
export type AiVaultResumeTargetStatus = 'local' | 'ssh' | 'runtime' | 'unknown'
@@ -132,9 +133,7 @@ export function getAiVaultResumeWorkspaceExecutionHostId(
}
const worktreeId = workspaceKey?.type === 'worktree' ? workspaceKey.worktreeId : workspaceId
const worktree = Object.values(state.worktreesByRepo ?? {})
.flat()
.find((candidate) => candidate.id === worktreeId)
const worktree = getIndexedWorktreeMap(state.worktreesByRepo ?? {}).get(worktreeId)
const worktreeHostId = normalizeExecutionHostId(worktree?.hostId)
if (worktreeHostId) {
return worktreeHostId
@@ -158,9 +157,7 @@ export function getAiVaultResumeWorkspaceTargetStatus(
}
const worktreeId = workspaceKey?.type === 'worktree' ? workspaceKey.worktreeId : workspaceId
const worktree = Object.values(state.worktreesByRepo ?? {})
.flat()
.find((candidate) => candidate.id === worktreeId)
const worktree = getIndexedWorktreeMap(state.worktreesByRepo ?? {}).get(worktreeId)
const worktreeHost = getAiVaultResumeExecutionHostTargetStatus(worktree?.hostId)
if (worktreeHost !== 'unknown') {
return worktreeHost