starred/orca
1
0
Fork 0
mirror of https://github.com/stablyai/orca.git synced 2026-09-21 16:02:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: trim small macOS app icon slots (#3896)

Browse Source
This commit is contained in:
Neil
2026-05-30 13:09:15 -07:00
committed by GitHub
parent d963419ba8
commit bbff68c85b
2 changed files with 37 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
resources/build/icon.icns
BIN
View File
Binary file not shown.
resources/icon-source/generate.sh
+37 -10
View File
@@ -12,6 +12,13 @@ TMP_DIR=$(mktemp -d)
trap 'rm -rf "$TMP_DIR"' EXIT
MAGICK_BIN=$(command -v magick || true)
if [ -z "$MAGICK_BIN" ]; then
echo "Error: ImageMagick is required to trim the small macOS icon slots." >&2
echo "Install with: brew install imagemagick" >&2
exit 1
fi
echo "Compiling icon from $ICON_SOURCE..."
# Generate .icns using actool (requires Xcode)
@@ -29,22 +36,42 @@ if [ ! -f "$TMP_DIR/icon.icns" ]; then
fi
cp "$TMP_DIR/icon.icns" "$BUILD_DIR/icon.icns"
# macOS list views use the small .icns slots directly. Icon Composer keeps the
# safe-area inset there, so trim only those slots while preserving larger icons.
ICONSET_DIR="$TMP_DIR/icon.iconset"
iconutil -c iconset "$BUILD_DIR/icon.icns" -o "$ICONSET_DIR"
for icon_file in \
icon_16x16.png \
icon_16x16@2x.png \
icon_32x32.png \
icon_32x32@2x.png; do
case "$icon_file" in
icon_16x16.png) icon_size=16 ;;
icon_16x16@2x.png | icon_32x32.png) icon_size=32 ;;
icon_32x32@2x.png) icon_size=64 ;;
esac
"$MAGICK_BIN" "$ICONSET_DIR/$icon_file" \
-trim +repage \
-resize "${icon_size}x${icon_size}" \
-background none \
-gravity center \
-extent "${icon_size}x${icon_size}" \
"$ICONSET_DIR/$icon_file"
done
iconutil -c icns "$ICONSET_DIR" -o "$BUILD_DIR/icon.icns"
echo " -> resources/build/icon.icns"
# Extract 1024x1024 PNG from icns for electron-builder fallback & resources
sips -s format png --resampleWidth 1024 "$BUILD_DIR/icon.icns" --out "$BUILD_DIR/icon.png" >/dev/null 2>&1
# Extract PNG fallbacks from the unmodified compiled icon; small-slot trimming is
# only for the macOS .icns list representations.
sips -s format png --resampleWidth 1024 "$TMP_DIR/icon.icns" --out "$BUILD_DIR/icon.png" >/dev/null 2>&1
echo " -> resources/build/icon.png (1024x1024)"
sips -s format png --resampleWidth 256 "$BUILD_DIR/icon.icns" --out "$RESOURCES_DIR/icon.png" >/dev/null 2>&1
sips -s format png --resampleWidth 256 "$TMP_DIR/icon.icns" --out "$RESOURCES_DIR/icon.png" >/dev/null 2>&1
echo " -> resources/icon.png (256x256)"
# Generate .ico for Windows (proper ICO format with multiple sizes)
if command -v magick &>/dev/null; then
magick "$BUILD_DIR/icon.png" -define icon:auto-resize=256,128,64,48,32,16 "$BUILD_DIR/icon.ico"
echo " -> resources/build/icon.ico (multi-size ICO via ImageMagick)"
else
echo "Warning: ImageMagick not found, skipping icon.ico generation" >&2
echo "Install with: brew install imagemagick" >&2
fi
"$MAGICK_BIN" "$BUILD_DIR/icon.png" -define icon:auto-resize=256,128,64,48,32,16 "$BUILD_DIR/icon.ico"
echo " -> resources/build/icon.ico (multi-size ICO via ImageMagick)"
echo "Done! Icons generated in resources/build/ and resources/"