fix(daemon): roll the daemon-side terminal fixes since v1.4.240 into a fresh v52 daemon (#33705)

This commit is contained in:
Jinwoo Hong
2026-10-25 20:36:10 -04:00
committed by GitHub
parent 405ce9bcc9
commit bd2f46359d
4 changed files with 9 additions and 8 deletions
@@ -3,7 +3,7 @@ import { PREVIOUS_DAEMON_PROTOCOL_VERSIONS, PROTOCOL_VERSION } from './types'
describe('foreground-confirmation daemon protocol', () => {
it('rejects daemons from before the fresh-confirmation RPC', () => {
expect(PROTOCOL_VERSION).toBe(51)
expect(PROTOCOL_VERSION).toBe(52)
expect(PREVIOUS_DAEMON_PROTOCOL_VERSIONS).toContain(19)
expect(PREVIOUS_DAEMON_PROTOCOL_VERSIONS).toContain(22)
expect(PREVIOUS_DAEMON_PROTOCOL_VERSIONS).toContain(23)
@@ -23,6 +23,6 @@ describe('foreground-confirmation daemon protocol', () => {
expect(PREVIOUS_DAEMON_PROTOCOL_VERSIONS).toContain(37)
expect(PREVIOUS_DAEMON_PROTOCOL_VERSIONS).toContain(38)
expect(PREVIOUS_DAEMON_PROTOCOL_VERSIONS).toContain(39)
expect(PREVIOUS_DAEMON_PROTOCOL_VERSIONS).toContain(50)
expect(PREVIOUS_DAEMON_PROTOCOL_VERSIONS).toContain(51)
})
})
+3 -2
View File
@@ -1,4 +1,5 @@
// Why: daemons survive app updates, so wire behavior must be version-gated.
// v52 rolls the daemon-side terminal fixes since v1.4.240 (ConPTY, teardown, spawn pane keys) into a fresh daemon.
// v51 checks terminal identity, ownership and attachments before reserving teardown.
// v50 makes the `codex` function keep Orca's terminal identity under a filtering shell_environment_policy.
// v49 makes the `claude` function follow the selection over the user's own CLAUDE_CONFIG_DIR.
@@ -9,7 +10,7 @@
// v43 dropped it with the revert); v41 stages long startup commands as sourced scripts; v40 rolled
// the #25130/#24636 shell-wrapper changes and the wider agent list into a fresh daemon; older owners
// stay attachable.
export const PROTOCOL_VERSION = 51
export const PROTOCOL_VERSION = 52
export const FENCED_TERMINATION_PROTOCOL_VERSION = 51
export const CLAUDE_ACCOUNT_FUNCTION_DAEMON_PROTOCOL_VERSION = 42
export const CLAUDE_ACCOUNT_FUNCTION_REVERTED_DAEMON_PROTOCOL_VERSION = 43
@@ -44,7 +45,7 @@ export const CLEAN_DISCONNECT_PROTOCOL_VERSION = 24
export const MODE_2031_UNSUBSCRIBE_FACT_PROTOCOL_VERSION = 29
export const PREVIOUS_DAEMON_PROTOCOL_VERSIONS = [
1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27,
28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50
28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51
] as const
export function supportsColorQueryReplyColors(protocolVersion: number): boolean {
@@ -3,10 +3,10 @@
"appId": "com.stablyai.orca",
"stateSchemaVersion": 1,
"readableStateSchemaVersions": [1],
"daemonProtocolVersion": 51,
"daemonProtocolVersion": 52,
"attachableDaemonProtocolVersions": [
1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26,
27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50,
51
51, 52
]
}
@@ -3,10 +3,10 @@ export const LOCAL_BUILD_COMPATIBILITY_CONTRACT = {
appId: 'com.stablyai.orca',
stateSchemaVersion: 1,
readableStateSchemaVersions: [1],
daemonProtocolVersion: 51,
daemonProtocolVersion: 52,
attachableDaemonProtocolVersions: [
1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26,
27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50,
51
51, 52
]
} as const