test(omp): prevent duplicate tab on worktree reselect (#21670)

2026-09-21 16:02:20 +00:00 · 2026-09-19 05:48:35 -07:00
parent 2e278426ef
commit bf250b1200
1 changed files with 66 additions and 0 deletions
@@ -82,4 +82,70 @@ describe('activateAndRevealWorktree', () => {
      executionHostId: 'ssh:box'
    })
  })
+
+  it('reselects a live worktree without creating a second terminal tab', () => {
+    const createTab = vi.fn(() => ({ id: 'tab-2' }))
+    const existingTab = { id: 'tab-1' }
+    // oxlint-disable-next-line typescript/consistent-type-assertions -- SAFETY: This fixture supplies only the activation slice used by the test.
+    useAppStore.setState({
+      activeRepoId: 'repo-1',
+      activeWorktreeId: 'wt-1',
+      activeView: 'terminal',
+      filterRepoIds: [],
+      isNavigatingHistory: false,
+      repos: [{ id: 'repo-1', connectionId: null }],
+      worktreesByRepo: {
+        'repo-1': [
+          {
+            id: 'wt-1',
+            repoId: 'repo-1',
+            path: '/repo',
+            displayName: 'main',
+            branch: 'main',
+            head: 'abc',
+            isBare: false,
+            isMainWorktree: true
+          }
+        ]
+      },
+      tabsByWorktree: { 'wt-1': [existingTab] },
+      getKnownWorktreeById: (worktreeId: string) =>
+        worktreeId === 'wt-1'
+          ? // oxlint-disable-next-line typescript/consistent-type-assertions -- SAFETY: The fixture omits unrelated worktree metadata.
+            ({
+              id: 'wt-1',
+              repoId: 'repo-1',
+              path: '/repo',
+              displayName: 'main',
+              branch: 'main',
+              head: 'abc',
+              isBare: false,
+              isMainWorktree: true
+            } as never)
+          : null,
+      setActiveRepo: vi.fn(),
+      setActiveView: vi.fn(),
+      setActiveWorktree: vi.fn(),
+      markWorktreeVisited: vi.fn(),
+      recordWorktreeVisit: vi.fn(),
+      reconcileWorktreeTabModel: vi.fn(() => ({ renderableTabCount: 1 })),
+      createTab,
+      setActiveTab: vi.fn(),
+      setTabCustomTitle: vi.fn(),
+      setTabColor: vi.fn(),
+      markDefaultTerminalTabsApplied: vi.fn(),
+      queueTabStartupCommand: vi.fn(),
+      queueTabInitialCwd: vi.fn(),
+      queueTabSetupSplit: vi.fn(),
+      queueTabIssueCommandSplit: vi.fn(),
+      revealWorktreeInSidebar: vi.fn()
+      // oxlint-disable-next-line typescript/consistent-type-assertions -- SAFETY: The fixture supplies only the activation slice used by the test.
+    } as never)
+
+    const result = activateAndRevealWorktree('wt-1')
+
+    expect(result).toEqual({ primaryTabId: null })
+    expect(createTab).not.toHaveBeenCalled()
+    expect(useAppStore.getState().tabsByWorktree['wt-1']).toEqual([existingTab])
+  })
 })