fix: address review findings (#4442)

This commit is contained in:
Jinjing
2026-06-01 21:54:30 -07:00
committed by GitHub
parent 8c6dae3345
commit c60fe4ebd7
2 changed files with 11 additions and 17 deletions
@@ -277,7 +277,7 @@ function SetupScriptPromptCard(): React.JSX.Element | null {
)
showSavedInProjectSettingsToast({
onOpenSettings: () => openLocalCommandSettings(importedRepoId),
description: 'Orca will run this command each time a new worktree is created.'
description: 'Runs when Orca creates a new worktree.'
})
}
return
@@ -293,8 +293,8 @@ function SetupScriptPromptCard(): React.JSX.Element | null {
onOpenSettings: () => openLocalCommandSettings(importedRepoId),
description:
skippedCount > 0
? `${skippedCount} unsupported field${skippedCount === 1 ? '' : 's'} skipped. Saved locally; move it to orca.yaml later to share it.`
: 'Move it to orca.yaml later to share it.'
? `${skippedCount} unsupported field${skippedCount === 1 ? '' : 's'} skipped. Saved the setup command.`
: 'Saved the setup command.'
})
}
} catch (error) {
@@ -129,38 +129,32 @@ export function SetupScriptPromptBody({
if (sharedSetupIgnored) {
return (
<>
This repo is set to ignore <code>orca.yaml</code> setup scripts. Configure a local setup
command or change the script source in Settings.
This repo ignores shared <code>orca.yaml</code> setup scripts. Add a local command, or
change the source in Settings.
</>
)
}
if (isPackageManagerSuggestion) {
return (
<>
Setup scripts run automatically when you create a new worktree, so you don&apos;t have to
run the same command every time.
</>
)
return <>Save the detected command to run it whenever Orca creates a worktree.</>
}
if (candidateSource) {
return (
<>
Detected setup config from <span className="break-words">{candidateSource}</span>. Save it
locally so every workspace starts ready automatically. You can move it to{' '}
<code>orca.yaml</code> later to share it.
Found a setup command in <span className="break-words">{candidateSource}</span>. Save it to
run for new worktrees.
</>
)
}
return (
<>
Add a local setup command so each new workspace starts ready automatically. You can move it to{' '}
<code>orca.yaml</code> later to share it for{' '}
Add a setup command for{' '}
<span className="inline-flex items-center gap-1.5 align-baseline px-1.5 py-0.5 rounded-[4px] bg-accent border border-border dark:bg-accent/50 dark:border-border/60">
<RepoBadgeMark color={repo.badgeColor} />
<span className="text-[10px] font-semibold text-foreground truncate max-w-[8rem] leading-none lowercase">
{repo.displayName}
</span>
</span>
</span>{' '}
to run when Orca creates new worktrees.
</>
)
}