starred/orca
1
0
Fork 0
mirror of https://github.com/stablyai/orca.git synced 2026-09-21 16:02:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(config): wait for the benchmark fixture before timing out its group (#21982)

Browse Source 
The owner-loss group case spawned its fixture with a 100ms kill timeout and
then read the child.pid handshake the fixture writes, so under full-suite load
the launcher was SIGKILLed before it booted and the read failed with ENOENT.
Start the launcher detached, wait for the handshake, and only then send the
trial timeout's own SIGKILL, which leaves the same orphaned group the cleanup
path validates.

Claude-Session: https://claude.ai/code/session_01JNnE9qzUZMMnqpZWCqM3nb
This commit is contained in:
Jinwoo Hong
2026-09-21 07:51:12 -04:00
committed by GitHub
parent 6ed961b322
commit d199e71a8e
1 changed files with 15 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
config/scripts/macos-computer-helper-owner-loss-processes.test.mjs
+15 -6
View File
@@ -133,25 +133,34 @@ describeMacOS('macOS helper owner-loss benchmark process cleanup', () => {
writeFileSync(${JSON.stringify(childPidPath)}, String(child.pid))
setInterval(() => {}, 1000)
`
const result = spawnBenchmarkProcess(process.execPath, ['-e', fixture], {
const launcher = spawn(process.execPath, ['-e', fixture], {
detached: true,
env: { ...process.env, [environmentName]: environmentValue },
stdio: 'ignore',
timeout: 100
stdio: 'ignore'
})
spawnedPids.add(launcher.pid)
launcher.unref()
const launcherExited = new Promise((resolve) => launcher.once('exit', resolve))
await expect.poll(() => existsSync(childPidPath), { timeout: 10_000 }).toBe(true)
const childPid = Number(readFileSync(childPidPath, 'utf8'))
spawnedPids.add(childPid)
// Send the trial timeout's own kill signal once the group is up; a real timeout would race its startup.
process.kill(launcher.pid, 'SIGKILL')
await launcherExited
spawnedPids.delete(launcher.pid)
const environmentFragment = `${environmentName}=${environmentValue}`
const groupState = { stopped: false }
expect(() => process.kill(launcher.pid, 0)).toThrow()
expect(() =>
signalValidatedProcessGroup(result.pid, `${environmentName}=wrong`, 'SIGSTOP')
signalValidatedProcessGroup(launcher.pid, `${environmentName}=wrong`, 'SIGSTOP')
).toThrow('Benchmark process group no longer belongs to this trial')
expect(() => process.kill(childPid, 0)).not.toThrow()
expect(
signalValidatedProcessGroup(result.pid, environmentFragment, 'SIGSTOP', groupState)
signalValidatedProcessGroup(launcher.pid, environmentFragment, 'SIGSTOP', groupState)
).toBe(true)
expect(
signalValidatedProcessGroup(result.pid, environmentFragment, 'SIGKILL', groupState)
signalValidatedProcessGroup(launcher.pid, environmentFragment, 'SIGKILL', groupState)
).toBe(true)
await expect
.poll(() => {