starred/orca
1
0
Fork 0
mirror of https://github.com/stablyai/orca.git synced 2026-10-30 16:47:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(e2e): stage the WSL inline-image payload in a file (#29633)

Browse Source 
* test(e2e): stage the WSL inline-image payload in a file instead of a 25 KB typed line

* ci: run the real WSL lane when its inline-image spec changes
This commit is contained in:
Neil
2026-10-16 05:20:59 -07:00
committed by GitHub
parent bf22760392
commit d3cafe234d
3 changed files with 16 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
config/scripts/pr-e2e-source-routing.mjs
+1 -1
View File
@@ -267,7 +267,7 @@ export const PR_E2E_SOURCE_ROUTES = [
],
matches: (file) =>
isProductSource(file) &&
/^(?:config\/scripts\/(?:verify-wsl-e2e-participation|verify-playwright-participation)\.mjs$|src\/main\/(?:wsl[/-]|pty\/.*wsl|providers\/wsl)|src\/shared\/(?:wsl-|windows-terminal-shell)|src\/renderer\/src\/.*(?:terminal-paste|pty-paste)|tests\/e2e\/(?:golden-tab-bar-agent-launch\.spec|terminal-windows-shell-paste-ownership\.spec|helpers\/(?:wsl-golden-stub-agent|golden-stub-agent))|\.github\/(?:actions\/setup-wsl-test-runtime\/|workflows\/windows-wsl-e2e\.yml))/.test(
/^(?:config\/scripts\/(?:verify-wsl-e2e-participation|verify-playwright-participation)\.mjs$|src\/main\/(?:wsl[/-]|pty\/.*wsl|providers\/wsl)|src\/shared\/(?:wsl-|windows-terminal-shell)|src\/renderer\/src\/.*(?:terminal-paste|pty-paste)|tests\/e2e\/(?:golden-tab-bar-agent-launch\.spec|terminal-windows-shell-paste-ownership\.spec|terminal-inline-images-windows\.spec|helpers\/(?:wsl-golden-stub-agent|golden-stub-agent))|\.github\/(?:actions\/setup-wsl-test-runtime\/|workflows\/windows-wsl-e2e\.yml))/.test(
file
)
},
config/scripts/wsl-e2e-lane-contract.test.mjs
+1
View File
@@ -17,6 +17,7 @@ describe('real WSL terminal lane', () => {
'tests/e2e/helpers/wsl-golden-stub-agent.ts',
'tests/e2e/golden-tab-bar-agent-launch.spec.ts',
'tests/e2e/terminal-windows-shell-paste-ownership.spec.ts',
'tests/e2e/terminal-inline-images-windows.spec.ts',
'.github/actions/setup-wsl-test-runtime/setup.ps1',
'.github/workflows/windows-wsl-e2e.yml'
])('routes %s to both WSL sentinels', (path) => {
tests/e2e/terminal-inline-images-windows.spec.ts
+14 -3
View File
@@ -1,3 +1,6 @@
import { randomUUID } from 'node:crypto'
import { writeFileSync } from 'node:fs'
import path from 'node:path'
import { expect, test } from './helpers/orca-app'
import { ensureTerminalVisible, waitForSessionReady } from './helpers/store'
import {
@@ -21,7 +24,8 @@ test.skip(process.platform !== 'win32', 'Native Windows and WSL PTY coverage')
for (const runtime of ['native', 'wsl'] as const) {
for (const acceleration of ['off', 'on'] as const) {
test(`@headful ${runtime}, ${acceleration}: PTY images and Kitty placeholders render on Windows`, async ({
orcaPage
orcaPage,
testRepoPath
}, testInfo) => {
await waitForSessionReady(orcaPage)
await ensureTerminalVisible(orcaPage)
@@ -70,10 +74,17 @@ for (const runtime of ['native', 'wsl'] as const) {
.toBe(acceleration === 'on')
const ptyId = await waitForActivePanePtyId(orcaPage)
const marker = 'WINDOWS_INLINE_IMAGES_DONE'
const payload = Buffer.from(`${inlineImagePayload(true)}${marker}\r\n`).toString('base64')
const rawPayload = `${inlineImagePayload(true)}${marker}\r\n`
const payload = Buffer.from(rawPayload).toString('base64')
// Why a file: this command is typed at PTY bind, before WSL bash reaches readline; a
// ~25 KB line in the kernel's cooked mode loses everything past 4095 bytes.
const payloadFile = `.orca-inline-images-${randomUUID()}.bin`
if (runtime === 'wsl') {
writeFileSync(path.join(testRepoPath, payloadFile), rawPayload)
}
const command =
runtime === 'wsl'
? `printf '%s' '${payload}' | base64 -d; printf 'WSL_IMAGE_PROTOCOL=%s\\n' "$ORCA_IMAGE_PROTOCOL"`
? `cat ${payloadFile}; rm -f ${payloadFile}; printf 'WSL_IMAGE_PROTOCOL=%s\\n' "$ORCA_IMAGE_PROTOCOL"`
: nodeTerminalCommand(['-e', `process.stdout.write(Buffer.from('${payload}', 'base64'))`])
await execInTerminal(orcaPage, ptyId, command)
await waitForTerminalOutput(orcaPage, marker, 30_000)