refactor(orchestration): drop the dead remote-transcript endOffset window

Nothing has produced an endOffset since the v1 pin archive reader was removed,
so both remote readers carried an unreachable bound.
This commit is contained in:
Jinwoo-H
2026-09-04 03:08:49 -04:00
parent c1cbdc31b0
commit d764e4b791
2 changed files with 3 additions and 19 deletions
@@ -42,7 +42,6 @@ export async function readRemoteTranscriptRangedWindow(args: {
provider: IFilesystemProvider
filePath: string
requestedOffset?: number
endOffset?: number
expectedBoundaryCheckpoint?: string
maxScanBytes: number
}): Promise<RemoteTranscriptWindow | null> {
@@ -51,10 +50,7 @@ export async function readRemoteTranscriptRangedWindow(args: {
if (!sourceIdentity) {
throw new Error('Remote transcript host did not provide stable file identity')
}
if (args.endOffset !== undefined && remoteStat.size < args.endOffset) {
return null
}
const fileSize = Math.min(remoteStat.size, args.endOffset ?? remoteStat.size)
const fileSize = remoteStat.size
const startOffset = args.requestedOffset ?? Math.max(0, fileSize - args.maxScanBytes)
if (startOffset > fileSize) {
return null
@@ -32,7 +32,6 @@ type RemoteReadArgs = {
sessionId: string
transcriptPath?: string
offset?: number
endOffset?: number
limit?: number
expectedBoundaryCheckpoint?: string
filesystemProvider?: IFilesystemProvider
@@ -90,7 +89,6 @@ async function readTranscriptWindow(
provider,
filePath,
requestedOffset: args.offset,
endOffset: args.endOffset,
expectedBoundaryCheckpoint: args.expectedBoundaryCheckpoint,
maxScanBytes: MAX_REMOTE_TRANSCRIPT_SCAN_BYTES
})
@@ -101,20 +99,13 @@ async function readTranscriptWindow(
}
}
}
return readLegacyWindow(
provider,
filePath,
args.offset,
args.endOffset,
args.expectedBoundaryCheckpoint
)
return readLegacyWindow(provider, filePath, args.offset, args.expectedBoundaryCheckpoint)
}
async function readLegacyWindow(
provider: IFilesystemProvider,
filePath: string,
requestedOffset: number | undefined,
endOffset: number | undefined,
expectedBoundaryCheckpoint: string | undefined
): Promise<RemoteTranscriptWindow | null> {
const sourceIdentity = remoteWorkerTranscriptSourceIdentity(await provider.stat(filePath))
@@ -130,10 +121,7 @@ async function readLegacyWindow(
throw new Error('Remote transcript read returned invalid content')
}
const allBytes = Buffer.from(result.content, 'utf8')
if (endOffset !== undefined && allBytes.length < endOffset) {
return null
}
const fileSize = Math.min(allBytes.length, endOffset ?? allBytes.length)
const fileSize = allBytes.length
const startOffset = requestedOffset ?? Math.max(0, fileSize - MAX_REMOTE_TRANSCRIPT_SCAN_BYTES)
if (startOffset > fileSize) {
return null