starred/orca
1
0
Fork 0
mirror of https://github.com/stablyai/orca.git synced 2026-09-22 08:02:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(floating-workspace): record why the launch does not take the global selection

Browse Source
This commit is contained in:
Brennan Benson
2026-09-21 15:17:08 -07:00
parent 71e069ecbb
commit de8fb41006
2 changed files with 11 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/renderer/src/components/floating-terminal/FloatingTerminalWindowControls.tsx
+7 -5
View File
@@ -64,15 +64,17 @@ export function FloatingTerminalWindowControls({
if (!defaultAgent) {
return
}
// Why: the shared launcher owns the startup plan, the route (floating always resolves a
// terminal) and the tab-bar order, so this button stays one more caller of it rather than a
// second copy of new-agent-tab startup.
// Why: the shared launcher owns the startup plan, the route and the tab identity, so this
// button stays one more caller of it rather than a second copy of new-agent-tab startup.
// Floating resolves the terminal-backed lane: a chat view over a PTY when the chat default is
// on, never a structured session.
const result = launchAgentInNewTab({
agent: defaultAgent,
worktreeId: FLOATING_TERMINAL_WORKTREE_ID,
launchSource: 'shortcut',
// Why: the floating panel must not move the main window's selection; it selects in its own
// group below, matching the other floating tab creators.
// Why: `agent-auto-ack-targets` relies on the floating panel's active tab never becoming the
// global `activeTabId`; activating here would also flip the main view off an open editor.
// This selects within the floating group below instead.
activate: false
})
if (!result) {
src/renderer/src/lib/launch-agent-in-new-tab.ts
+4 -1
View File
@@ -31,7 +31,10 @@ import { seedNativeChatAppliedSessionOptions } from '@/components/native-chat/na
import { launchAgentInStructuredNewTab } from '@/lib/launch-agent-in-new-tab-structured'
import type { StructuredAgentLaunchSettlement } from '@/lib/structured-agent-launch-settlement'
import { workspaceKindForWorktreeId } from '@/lib/agent-launch-route-input'
import { planAgentSessionLaunch, type AgentSessionLaunchPlan } from './agent-session-launch-plan'
import {
planAgentSessionLaunch,
type AgentSessionLaunchPlan
} from '@/lib/agent-session-launch-plan'
export type LaunchAgentInNewTabArgs = {
agent: TuiAgent