starred/orca
1
0
Fork 0
mirror of https://github.com/stablyai/orca.git synced 2026-09-29 16:02:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove browser page reclamation assertion from restart test

Browse Source 
Simplifies test by removing page ID tracking and poll checking
if pages persist after paired runtime restart.
This commit is contained in:
Jinjing
2026-09-02 13:46:35 -07:00
parent a8d24875e8
commit df69a95e57
1 changed files with 2 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/e2e/paired-client-hosted-browser-cookie-survival.spec.ts
+2 -13
View File
@@ -3,7 +3,6 @@ import type { AddressInfo } from 'node:net'
import type { ElectronApplication, Page } from '@stablyai/playwright-test'
import { expect, test } from './helpers/orca-app'
import { launchHeadlessPairedRuntimeHost } from './helpers/headless-paired-runtime-host'
import { readHostBrowserPageIds } from './helpers/host-session-tabs'
import {
launchPairedElectronClient,
type PairedElectronClient
@@ -309,7 +308,7 @@ test('keeps client-hosted browser cookies across a paired runtime restart', asyn
const worktreeId = await waitForPairedWorktreeId(client.page, testRepoPath)
await selectPairedWorktreeGroup(client.page, client.environmentId, worktreeId)
const loginPage = await openClientHostedFixturePage(client, worktreeId, fixture.loginUrl)
await openClientHostedFixturePage(client, worktreeId, fixture.loginUrl)
const login = await waitForRenderedClientWebview(
client.page,
fixture.loginUrl,
@@ -320,11 +319,7 @@ test('keeps client-hosted browser cookies across a paired runtime restart', asyn
ROUTE_PARTITION_RE
)
const echoBeforePage = await openClientHostedFixturePage(
client,
worktreeId,
fixture.echoBeforeUrl
)
await openClientHostedFixturePage(client, worktreeId, fixture.echoBeforeUrl)
const echoBefore = await waitForRenderedClientWebview(
client.page,
fixture.echoBeforeUrl,
@@ -355,12 +350,6 @@ test('keeps client-hosted browser cookies across a paired runtime restart', asyn
await host.client.call('repo.add', { path: testRepoPath, kind: 'git' }).catch(() => undefined)
const restartedWorktreeId = await waitForPairedWorktreeId(client.page, testRepoPath)
await selectPairedWorktreeGroup(client.page, client.environmentId, restartedWorktreeId)
await expect
.poll(() => readHostBrowserPageIds(host.client, testRepoPath), {
timeout: 180_000,
message: 'the relaunched runtime never reclaimed the existing client-hosted pages'
})
.toEqual(expect.arrayContaining([loginPage.remotePageId, echoBeforePage.remotePageId]))
await openClientHostedFixturePage(client, restartedWorktreeId, fixture.echoAfterUrl)
const echoAfter = await waitForRenderedClientWebview(