fix(agent-picker): keep model rows keyed across sections; let launch search find legacy models

This commit is contained in:
Brennan Benson
2026-11-11 14:04:01 -08:00
parent e48b294671
commit e705e87ab2
3 changed files with 24 additions and 16 deletions
@@ -266,14 +266,18 @@ export function AgentLaunchSetupPanel({
modelInArguments={modelInArguments}
onSelect={editDraft}
/>
{modelRows.rows.map(renderModelRow)}
<AgentPickerLegacyModelsToggle
total={modelRows.legacyCount}
expanded={legacyExpanded}
disabled={disabled}
onToggle={() => setLegacyExpanded((expanded) => !expanded)}
/>
{modelRows.legacyRows.map(renderModelRow)}
{/* One keyed array, so a row moving between sections keeps its highlight. */}
{[
...modelRows.rows.map(renderModelRow),
<AgentPickerLegacyModelsToggle
key="legacy-toggle"
total={modelRows.legacyCount}
expanded={legacyExpanded}
disabled={disabled}
onToggle={() => setLegacyExpanded((expanded) => !expanded)}
/>,
...modelRows.legacyRows.map(renderModelRow)
]}
</CommandGroup>
</CommandList>
</Command>
@@ -109,13 +109,17 @@ export function NativeChatModelCombobox({
</CommandEmpty>
<NativeChatSessionOptionWriteGroup busy={busy}>
<CommandGroup>
{choices.filter((choice) => !folded(choice)).map(renderChoice)}
<AgentPickerLegacyModelsToggle
total={legacyChoices.length}
expanded={legacyExpanded}
onToggle={() => setLegacyExpanded((expanded) => !expanded)}
/>
{legacyExpanded ? legacyChoices.map(renderChoice) : null}
{/* One keyed array, so a row moving between sections keeps its highlight. */}
{[
...choices.filter((choice) => !folded(choice)).map(renderChoice),
<AgentPickerLegacyModelsToggle
key="legacy-toggle"
total={legacyChoices.length}
expanded={legacyExpanded}
onToggle={() => setLegacyExpanded((expanded) => !expanded)}
/>,
...(legacyExpanded ? legacyChoices.map(renderChoice) : [])
]}
</CommandGroup>
</NativeChatSessionOptionWriteGroup>
</CommandList>
@@ -72,7 +72,7 @@ export function searchAgentPickerSetups(
continue
}
for (const model of agentPickerModels(entry)) {
if (model.isLegacy || model.hidden) {
if (model.hidden) {
continue
}
const modelWords = tokens([model.id, model.label].join(' '))