starred/orca
1
0
Fork 0
mirror of https://github.com/stablyai/orca.git synced 2026-09-22 16:02:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(relay): clear the changed-code casting gate

Browse Source 
Four of the eleven findings were removable rather than suppressible: annotate
the variable instead of asserting the literal. The rest carry a line-specific
SAFETY rationale on the line that opens the cast expression, which is where the
diagnostic points -- not the `} as Foo` that closes it.

Measured: gate exit 0, tc exit 0, relay 32 files / 251 tests passed.
This commit is contained in:
Neil
2026-09-17 00:14:18 -07:00
parent 4eb2f7e6fe
commit e936e5dab1
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/main/runtime/relay/desktop-relay-service-transient-demand-teardown.test.ts
+8 -2
View File
@@ -24,15 +24,17 @@ function serviceWithTeardown(options: {
release?: () => void
refreshDemand?: () => void
}): (operation: () => Promise<unknown>) => Promise<unknown> {
// oxlint-disable-next-line typescript/consistent-type-assertions -- SAFETY: builds the instance without running the constructor, which would open a real broker.
const service = Object.create(DesktopRelayService.prototype) as DesktopRelayService
Object.assign(service, {
hostMobilePairingConnectionMode: () => 'automatic' as MobilePairingConnectionMode,
hostMobilePairingConnectionMode: (): MobilePairingConnectionMode => 'automatic',
runtimeRpc: {
getDeviceRegistry: () => ({ getMobilePairingConnectionMode: () => 'automatic' })
},
demandLedger: { acquireTransient: () => options.release ?? ((): void => {}) },
refreshDemand: options.refreshDemand ?? ((): void => {})
})
// oxlint-disable-next-line typescript/consistent-type-assertions -- SAFETY: withTransientDemand is private; the fixture calls it directly with only the fields it touches.
const host = service as unknown as TransientDemandHost
return (operation) => host.withTransientDemand.call(service, 'pairing', 'device-1', operation)
}
@@ -86,7 +88,8 @@ describe('DesktopRelayService transient-demand teardown', () => {
})
it('carries the original failure as the cause of a mid-operation policy flip', async () => {
const mode = { current: 'automatic' as MobilePairingConnectionMode }
const mode: { current: MobilePairingConnectionMode } = { current: 'automatic' }
// oxlint-disable-next-line typescript/consistent-type-assertions -- SAFETY: builds the instance without running the constructor, which would open a real broker.
const service = Object.create(DesktopRelayService.prototype) as DesktopRelayService
Object.assign(service, {
hostMobilePairingConnectionMode: () => mode.current,
@@ -96,6 +99,7 @@ describe('DesktopRelayService transient-demand teardown', () => {
demandLedger: { acquireTransient: () => (): void => {} },
refreshDemand: () => {}
})
// oxlint-disable-next-line typescript/consistent-type-assertions -- SAFETY: withTransientDemand is private; the fixture calls it directly with only the fields it touches.
const host = service as unknown as TransientDemandHost
const rejection = await host.withTransientDemand
@@ -105,7 +109,9 @@ describe('DesktopRelayService transient-demand teardown', () => {
})
.catch((error: unknown) => error)
// oxlint-disable-next-line typescript/consistent-type-assertions -- SAFETY: the rejection is this suite's own thrown Error; only message and cause are read.
expect((rejection as Error).message).toBe('relay_disabled_for_device')
// oxlint-disable-next-line typescript/consistent-type-assertions -- SAFETY: the rejection is this suite's own thrown Error; only message and cause are read.
expect(((rejection as Error).cause as Error | undefined)?.message).toBe(
'relay_token_exchange_failed_503'
)