starred/orca
1
0
Fork 0
mirror of https://github.com/stablyai/orca.git synced 2026-10-16 00:03:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: address pr-bug-scan validated finding from #4850

Browse Source 
Effect cleanup now clears every local pane transport's renderer-active flag on hide, not just the single captured ptyId, so an onActivePaneChange-focused pane (ptyB) cannot leak active.
This commit is contained in:
orca-bug-scan-bot
2026-06-08 12:51:41 -07:00
parent f15dcd928c
commit ea918cf699
1 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/renderer/src/components/terminal-pane/use-terminal-pane-global-effects.ts
+12 -1
View File
@@ -147,7 +147,18 @@ export function useTerminalPaneGlobalEffects({
// Why: main uses this as a scheduler hint only, so the foreground pane's
// renderer output gets first chance at the bounded ACK reserve.
window.api.pty.setActiveRendererPty?.(ptyId, true)
return () => window.api.pty.setActiveRendererPty?.(ptyId, false)
return () => {
// Why: split-pane focus can move to another pane via onActivePaneChange
// after this effect captured ptyId, flagging that pane's PTY active
// without re-running this effect. Clear every local pane transport on
// hide so a focus-changed pane's PTY cannot stay flagged active in main.
for (const transport of paneTransportsRef.current.values()) {
const cleanupPtyId = transport.getPtyId()
if (cleanupPtyId && !cleanupPtyId.startsWith('remote:')) {
window.api.pty.setActiveRendererPty?.(cleanupPtyId, false)
}
}
}
}, [isActive, isVisible, managerRef, paneTransportsRef])
useEffect(() => {