Commit Graph
20101 Commits
Author SHA1 Message Date
Kelvin Amoaba 9a0292fc10 fix(mobile): refresh native Home when worktree rows change 2026-11-08 20:23:59 +00:00
Neil 0d1220c31f Organize SSH and managed-server modules by concrete owner (#39937)
* refactor(main): organize SSH transport and managed server owners

* Remove orphan deploy readiness fixture and shrink test baselines

* refactor(wsl): import lock records from their defining owner

* refactor(wsl): use the canonical deferred update contract
2026-11-08 12:20:22 -08:00
OrcaWinandOrcaWin 49d74f57b1 test: remove 6 low-value query and cache tests (#39953)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 12:06:50 -08:00
Kelvin Amoaba 2881d6f5c6 fix(native-chat): drop Open in new tab from the file link menu (#39950)
Chat file links share the terminal's row builder, which added the row
whenever the source tab had a split or neighbor. Open file already places
the file beside the chat, so the extra row was noise. Terminal links keep it.
2026-11-08 20:06:12 +00:00
Kelvin Amoaba d0f273f5dd perf(ai-vault): skip re-rendering unchanged Session History rows (#39944)
* perf(ai-vault): skip re-rendering unchanged Session History rows

* fix(ai-vault): keep memoized history rows current with host capabilities and time

* fix(ai-vault): recompute chat-resume eligibility when host agent facts change

* refactor(ai-vault): simplify the history row memo comparator

* fix(ai-vault): drop the hook-deps suppression React Compiler bails on
2026-11-08 20:04:15 +00:00
OrcaWinandOrcaWin 41e980f4d6 test: remove 9 low-value IPC and SQLite tests (#39947)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 11:59:11 -08:00
Brennan Benson ed78b51cad Let native chats finish slow agent startup (#38727)
* Let native chat startup follow provider readiness

* Remove obsolete startup deadline expectation

* Preserve startup retry when Claude exits before initialize

* Join startup cleanup with the observed Claude exit

* Model the observed Claude exit in the startup fixture

* Wake Pi startup on fatal session failure

* Keep Pi refusal assertion typed as an unknown result

* Keep startup tests tied to the fixed regressions
2026-11-08 11:58:34 -08:00
Brennan Benson 252b427dfd Display private GitHub attachment images in fetched items (#39250)
* Display private GitHub attachment images in fetched items

* Keep attachment event identity aligned with committed renders

* Complete GitHub image response type contracts

* Return private image sources with accepted issue edits

* Keep issue edits successful without optional display data

* Cover unusable issue edit image responses

* Keep optional GitHub image parsing from failing accepted saves

* Fetch GitHub body images with the existing body read
2026-11-08 11:58:15 -08:00
OrcaWinandOrcaWin b4f198379a test: remove 17 low-value mobile test cases (#39941)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 11:43:36 -08:00
Kelvin Amoaba 51c77320bc feat(mobile): mark agents read and clear them from the Agents tab (#39245)
Unread rows show the desktop's bell, swipe right toggles read, swipe
left clears a finished agent, and the long-press and options menus get
Mark read/unread, Unread only, Mark all read and Clear finished. Writes
go through agentActivity.setRead/clear and show optimistically until the
desktop's list confirms them.
2026-11-08 19:40:47 +00:00
Brennan Benson 8f58492e3f fix(toasts): match toast action buttons to Orca's Button (#39935)
* fix(toasts): match toast action buttons to Orca's Button

* fix(toasts): keep toast cancel buttons on the secondary color in dark mode
2026-11-08 11:37:14 -08:00
Kelvin Amoaba c5c12af6f7 fix(session-history): match more Claude and Pi folder names in scope recovery (#39936)
Workspace and Project add older in-scope sessions by matching agent
folder names to the scope. Several real names were missed: Claude's
truncated long-path buckets, Windows paths in another case, drive and
filesystem roots, the other WSL share spelling, and Pi buckets under
PI_CODING_AGENT_DIR's sessions/ folder. An unreadable folder now shows
up as a scan issue instead of looking empty.
2026-11-08 19:32:44 +00:00
Kelvin Amoaba c18515a5d9 fix(ai-vault): keep search results on screen while typing in Session History (#39325)
* fix(ai-vault): keep search results on screen while typing in Session History

* perf(ai-vault): fold session search text once and keep resolver maps stable on empty replies
2026-11-08 19:32:30 +00:00
Kelvin Amoabaandggbdpq ba6b11cd8b fix(ai-vault): cut session search index disk writes with wider FTS merges and fewer vacuums (#39314)
* fix(ai-vault): cut search-index disk writes from merge rewrites and idle vacuums

The session-search index sustained tens of GB of daily writes on busy
multi-agent days (#36666): ~650 KB/s of file-backed pages dirtied by the
Orca Helper process that owns the index, against a ~214 MB database.

Two write paths compound there:

1. FTS5 merges whole segment levels on every steady append. With the
   default automerge=4, an index of this size rewrites several bytes of
   deep segments for each byte appended, and every merge page is then
   copied from WAL into the database by autocheckpoint.
2. Every full purge ran `incremental_vacuum(2000)` even when it deleted
   nothing, moving free pages around the file. Full purges back every
   freshness wait (`reconcile({ full: true })`) and the periodic sweep,
   so idle sweeps themselves became a write source. A measured loop
   (one busy transcript appending 100 KB per 20 s cycle, sweeps every
   15 cycles) shows sweeps dropping from 428-736 KB to 132-144 KB per
   pass and merge spikes from ~1 MB to 432-800 KB (-28% total WAL bytes
   at 10 MB index scale; the merge saving grows with index size).

Fix:

- Set FTS5 `automerge` to 8 on every open (new and existing databases,
  no schema rebuild): merging wider rewrites roughly half the
  deep-level pages on this insert-heavy, rarely-deleted index, at a
  small read fan-in cost.
- Gate the trailing `incremental_vacuum` in retention drains on actual
  deletion work. Drains scheduled after real deletions (retention,
  replacement, retirement) keep reclaiming pages; recurring unlimited
  purges with nothing to delete leave the freelist for page reuse
  instead of shuffling it.

Read paths, cache semantics, and the on-disk schema are unchanged.

Fixes #36666

* fix(ai-vault): vacuum the search index only when free pages pile up

FTS merges free pages on every write and later writes reuse them, so a
vacuum after every drain batch and sweep only moved pages around. Gate it
on the free share of the file instead of on whether a purge deleted
anything, which also covers drains after whole-session replaces.

---------

Co-authored-by: ggbdpq <ggbdpq@gmail.com>
2026-11-08 19:32:09 +00:00
Kelvin Amoaba 96ac06c00f feat(mobile): add an Agents tab listing every agent across your desktops (#39244)
* feat(agents): send paired phones the desktop Agents list's verdict per agent

While a phone is paired, the desktop window publishes its own Agents-list
classification for each pane (listed, status, unread, clearable, title,
worker parent) and worktree.ps attaches it to each agent row, so the phone
lists agents exactly as the sidebar does. agentActivity.setRead/clear apply
through the sidebar's own Activity actions and resolve once the new
verdicts are stored.

* feat(mobile): add an Agents tab to Home

One row per agent across every paired desktop, grouped by status, with
a desktop filter, search, group-by, nested workers and a long-press
menu. Feed's per-workspace Agents section becomes a short Needs you
list, and the needs-you badge moves to the Agents tab.
2026-11-08 19:31:50 +00:00
Kelvin Amoaba 9abd095d08 feat(agents): send paired phones the desktop Agents list's verdict per agent (#39243)
While a phone is paired, the desktop window publishes its own Agents-list
classification for each pane (listed, status, unread, clearable, title,
worker parent) and worktree.ps attaches it to each agent row, so the phone
lists agents exactly as the sidebar does. agentActivity.setRead/clear apply
through the sidebar's own Activity actions and resolve once the new
verdicts are stored.
2026-11-08 19:30:27 +00:00
OrcaWinandOrcaWin e1a20be7ad test: remove 8 low-value mobile test cases (#39939)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 11:26:44 -08:00
OrcaWinandOrcaWin 4e70998609 test: remove 8 low-value test cases (#39934)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 11:23:56 -08:00
Kelvin Amoaba b032aa5615 feat(runtime): tell phones which settings changed (#39718)
* feat(runtime): tell phones which settings changed

* test(mobile): re-record Source Control goldens for the settings stream
2026-11-08 19:12:26 +00:00
Jinjing 8781bcb6be Reduce the maximum height of the model picker (#39774) 2026-11-08 10:58:00 -08:00
OrcaWinandOrcaWin 069cc7e22e test: remove 10 low-value mobile test cases (#39927)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 10:57:42 -08:00
OrcaWinandOrcaWin fcd356ad88 test: remove 6 low-value test cases (#39925)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 10:50:46 -08:00
Kelvin Amoaba f74bb65fa1 feat(runtime): tell phones when git status changes (#39672)
* feat(runtime): tell phones when git status changes

* fix(runtime): tell phones about HEAD and packed-refs moves too

* fix(runtime): don't let a phone's status re-read join a read begun before the change

* perf(runtime): limit status-read invalidation to the checkouts an outside change touched

* fix(runtime): match a checkout's status keys under any execution host

* fix(runtime): invalidate globally while a primary checkout is unread

* test(mobile): re-record the Changes and settings goldens on the rebased main

* fix(runtime): invalidate globally while a listed checkout has no cached path

* test: follow the moved paired-client harness

* refactor(mobile): let the host list's catalog read hold the event router
2026-11-08 18:36:13 +00:00
Kelvin Amoaba 2aa47c91d2 fix(runtime): send a terminal's first screen before closing its stream on exit (#39681)
* fix(runtime): send a terminal's first screen before closing its stream on exit

A PTY exit while terminal.subscribe was still publishing its first snapshot
ended the stream at once: the phone got end with no screen. The exit now
waits for that publication, the exited PTY's model stays readable (off the
live map) until it finishes, and queued layout work settles on exit so it
can't hold the stream open.

* fix(runtime): skip the renderer seed when the PTY exits while its screen is read
2026-11-08 18:34:16 +00:00
Brennan Benson 5266dbe53b fix(github): stop PR pages and GitHub requests from hanging forever when the rate-limit cache expires (#39581)
* fix(github): stop PR pages from hanging when the rate-limit cache expires

Slot holders await assertRateLimitBudget -> getRateLimit while holding a
gh semaphore slot, and the /rate_limit probe queued for a slot behind
them. With all four slots held by budget waiters nothing ever released.
The probe is quota-exempt and deduped, so it no longer takes a slot.

* fix(github): bound rate-limit probe concurrency without the gh semaphore

Forced getRateLimit calls now join an in-flight probe, and all /rate_limit
probes share a small probe-only limiter that acquires nothing else.
Fold the deadlock regression test into rate-limit.test.ts as a direct await.

* fix(github): make forced rate-limit probes read quota after the call

Forced callers (403 reset refinement) share one follow-up probe queued
behind the running one instead of joining a probe that may predate the
403, so a stale positive budget cannot clear a fresh breaker block.

* fix(github): hand forced rate-limit follow-ups off synchronously

A pending forced follow-up could outlive its probe's settlement, so a
later forced caller joined a probe that predated it. Settlement now
detaches the shared deferred follow-up and starts its probe in one
synchronous step. Run rate-limit.test.ts on the Node runtime, where the
V8 scheduling that opens the race is reproducible.
2026-11-08 10:29:37 -08:00
OrcaWinandOrcaWin 4eadc6623e test: remove 19 low-value skill and renderer tests (#39921)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 10:28:11 -08:00
buf0-bot[bot] 1af2a4b804 Update README downloads badge (#39922)
Co-authored-by: buf0-bot[bot] <252831055+buf0-bot[bot]@users.noreply.github.com>
2026-11-08 18:20:37 +00:00
Brennan Benson ace74af490 Open search-result agent setup as a hover submenu (#39569)
* Open search-result agent setup as a hover submenu

The + menu's search-result agent rows opened setup through a separate
click popover. Route them through the same native submenu the regular
agent rows use, delete the popover path, and keep hover from moving
focus off the omnibox input.

* Keep omnibox typing in the search box when agent setup opens or closes

Hovering a search row's › no longer moves focus into the setup panel, and
Escape, ArrowLeft or leaving the open row return focus to the search input.
Also stop dimming disabled setup rows twice.

* Give omnibox agent setup pointer grace before another row closes it

Crossing an ordinary result on the way to the panel no longer closes the
setup; another row closes it after 300 ms unless the pointer reaches the
panel or returns to its row, like Radix submenus.

* Keep a hover-opened omnibox setup from taking focus after a keystroke

Typing can shift a row under a resting pointer and open its setup while
Radix is in keyboard mode; its content autofocus now returns to the
search input until the pointer moves into the panel.

* Open omnibox agent setup on pointer movement, and keep panel typing on leave

Per the decider ruling: a row shifting under a resting pointer no longer
opens its setup (Radix sub-triggers also open on pointermove), and leaving
the row after clicking › keeps focus in the setup editor instead of moving
typing back to the search box.

* Return omnibox focus to the search box when a focused setup closes on its own

Clicking › and then moving to another row let the hover grace close the
panel while it held focus, dropping focus to the page; closing it now
returns typing to the search input.

* Test that a caller-closed setup returns focus to the omnibox input

* Render omnibox search tests inside the + menu so agent setup has its menu

* Keep omnibox setup wiring React Compiler friendly

Build each row's setup handlers at the call site from plain hook state, and
configure the launched option inside the handler, so nothing that reads refs
runs during render.
2026-11-08 10:08:52 -08:00
Brennan Benson 7220069db0 Open the branch picker from the branch name under the chat composer (#39692)
* Open the branch picker from the branch name under the chat composer

* Copy the current branch from its row in the composer's branch picker

* Keep the composer copy button clickable and out of the list's keyboard, and keep a twin copy's status out of the picker

* Read a twin copy's status privately in the branch picker and drop refreshes that land after its twin is selected

* Block on a twin's returned read error, re-read after the picker closes itself, and distrust a twin's leftover status on becoming owner

* Build the environment name selector outside the component so the React compiler can lower the picker

* Trust a copy's status again once its picker refresh settles, even when an identical newer poll superseded it

* Read a newly owning copy's own status until the inherited slot changes, instead of trusting a settled refresh

* Route the composer picker through the copy's owner and block while this chat's turn is active

* Keep the composer picker's agent gate on the shared working check, as in Source Control
2026-11-08 10:06:53 -08:00
Brennan Benson 87947ae868 Show CI results as one-line cards on desktop and phone, following the desktop setting (#39658)
* Show CI result lines on the phone, following the desktop setting

The host now sends nativeChatCiResultLines resolved in settings.get, the
ready snapshot and a nativeChatCiResultLinesChanged event, from one
publisher that tracks each pushed chat preference separately. The phone
keeps one store per desktop connection and preference, reads the CI value
only from the paired desktop, and hides the lines until that desktop
reports one. CI rows stay in the projection and are filtered after it, so
a flip rebuilds nothing. The phone draws the line with links to the pull
request and commit.

* Let the phone CI line wrap and select like other notices

Long repository names at large font scale no longer push the commit link
past an ellipsis: the line wraps, centered, with the icon on its first
line. Its text follows the system-notice selection policy, so iOS selects
natively and Android keeps the long-press actions sheet. The CI strings
are translated in every mobile locale, the filter copies only once it
meets a CI row, and the tests drop a token assertion and a duplicate case.

* Draw CI results as one-line cards on desktop and phone

The CI result line becomes a one-line card in the same frame as the
opened pull request card, with the Hide button inline at its right end
on desktop, and in the phone's chat card frame without one. Only the
lead and pull request name truncate, so the commit link and the Hide
button stay reachable on narrow widths. The fixture uses real
percent-encoded item ids so its links render.

* Make the CI card's whole lead open its pull request

A translated lead at large font scale can push the ellipsis before
repo#N, which left no visible way to open the pull request. The
truncating segment is now the pull request's target on desktop and
phone, named for it, while "at <sha>" stays the commit's own target.
The ja, zh and zh-Hant leads use a plain colon so the space after it
isn't doubled.

* Read the CI result lines setting only for structured chats

CI result lines come only from structured sessions' journals, so a
terminal chat no longer sends the setting read. The prompt-controller
fixture stubs the setting hook: its tests count only the chat's prompt
writes, and the structured chat's one read per desktop connection is
expected.
2026-11-08 10:05:27 -08:00
OrcaWinandOrcaWin f2d1d5782c test: remove 12 low-value skill transfer tests (#39911)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 10:01:47 -08:00
Neil cd546dc3d0 refactor(skills): retire unused removal service and test concrete owners (#39902) 2026-11-08 09:19:54 -08:00
OrcaWinandOrcaWin 492ccce634 test: remove 5 low-value skills tests (#39903)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 09:07:53 -08:00
OrcaWinandOrcaWin d5f7081243 test: remove 8 low-value skills tests (#39899)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 08:55:00 -08:00
Neil a964c9e0b5 refactor(acp): group transport, session, launch, and timeline owners (#39897) 2026-11-08 08:42:10 -08:00
OrcaWinandOrcaWin 078bda27f8 test: remove 7 low-value workspace-store tests (#39896)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 08:34:08 -08:00
OrcaWinandOrcaWin 89422778ee test: remove 11 low-value agent-status tests (#39893)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 08:16:45 -08:00
OrcaWinandOrcaWin 4ec21a86df test: remove 13 low-value hook tests (#39892)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 08:07:11 -08:00
OrcaWinandOrcaWin 786a5b21a2 test: remove 23 low-value hook tests (#39889)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 07:56:03 -08:00
Neil 26a4db6b4e refactor(skills): group discovery, install, cloud, and transfer owners (#39874)
* refactor(skills): organize installation, discovery, and transfer owners

* chore(skills): reconcile move validation metadata
2026-11-08 07:39:57 -08:00
OrcaWinandOrcaWin 459128006c test: remove 6 low-value renderer work-count tests (#39885)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 07:34:34 -08:00
Neil 19043a3d76 refactor(mobile): organize pairing, session, RPC and host owners (#39846)
* refactor(mobile): give relay and encryption concrete owners

* refactor(mobile): organize session and review feature owners

* refactor(mobile): organize RPC and host ownership

* test(mobile): point render fixtures at concrete owners

* refactor(mobile): use explicit type-only owner imports
2026-11-08 07:19:05 -08:00
OrcaWinandOrcaWin e0ea78c7d4 test: remove 6 low-value resume and lifetime tests (#39881)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 07:17:34 -08:00
OrcaWinandOrcaWin 749829b2a6 test: remove 5 low-value agent launch tests (#39875)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 07:09:20 -08:00
OrcaWinandOrcaWin 9f28435ca2 test: hover the grab target before clicking in the split grab e2e (#39868)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 07:08:13 -08:00
Neil c10881fa8c refactor(shared): organize execution and automation defining owners (#39776)
* refactor: import journal queue state from defining owners

* refactor(shared): organize execution and automation owners

* fix: retain type imports used by surviving test cases

* refactor: finish work item owners and refresh validation metadata

* test: infer reconnect status fixture type

* test(claude): resolve source files beside same-named directories

* test(runtime): group repository creation mock registrations
2026-11-08 06:46:09 -08:00
784aefee50 perf(tasks): look up the GitLab comment viewer only on phone reads (#39860)
* perf(tasks): look up the GitLab comment viewer only on phone reads

The phone is the only reader of viewerDidAuthor, so GitLab detail reads
from desktop IPC and the Checks poll skip the `glab api user` lookup.
The phone sends markViewerComments on every GitLab detail read.

Ported from #39749 (GitLab part only); GitHub REST-fallback viewer
lookup is unchanged.

Co-authored-by: AmoabaKelvin <97001695+AmoabaKelvin@users.noreply.github.com>

* perf(tasks): keep GitLab viewer marks by default; desktop detail reads opt out

Older phones and callers that omit markViewerComments keep author marks.

Co-authored-by: AmoabaKelvin <97001695+AmoabaKelvin@users.noreply.github.com>

---------

Co-authored-by: m4air <m4air@m4airs-MacBook-Air.local>
Co-authored-by: AmoabaKelvin <97001695+AmoabaKelvin@users.noreply.github.com>
2026-11-08 06:27:50 -08:00
OrcaWinandOrcaWin b67159291b test: remove 14 low-value renderer tests (#39871)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 06:26:47 -08:00
Neilandm4air dddc1260e5 chore(lint): oxlint 1.91, cheap perf/correctness rules, return-await fixes (#39730)
* chore(lint): bump oxlint to 1.91, add perf lint rules and perf audits

* fix(lint): await promises returned inside try/catch/finally for return-await

Prepare typescript/return-await with error-handling-correctness-only: await
returns whose catch or finally was meant to cover them, and suppress the eight
sites where the catch must not re-handle the returned promise.

* chore(lint): enable return-await (error-handling-correctness-only); exempt secondary-scan directives in the changed gate

* refactor(mobile): move file preview discard modal into its own module

Keeps MobileFilePreviewScreen under the 400-line limit after merging main.

---------

Co-authored-by: m4air <m4air@m4airs-MacBook-Air.local>
2026-11-08 06:21:54 -08:00
ae6675d67c fix(window): cancelling a quit prompt clears the quit latch so later closes aren't treated as quits (#39597)
* fix(window): cancelling a quit prompt now cancels the quit

Renderer-owned quit prompts (running-work "Close Window?", Save dialog,
close-guard and shutdown-checkpoint vetoes) never reach
will-prevent-unload, so main kept isQuitting latched after Cancel. A later
plain close was treated as a quit and renderer crashes were not recovered.

Add a window:close-cancelled IPC (preload ui.cancelWindowClose; no-op in the
web client) that the renderer sends on each cancel path. Main accepts it only
from its own renderer, only while quitting, and only once that renderer has
acknowledged the newest close request, then runs the same abort path as a
beforeunload veto.

Fixes #39596

Co-authored-by: Neil <neil@stably.ai>

* test(window): expose webContents.send on the renderer recovery harness type

---------

Co-authored-by: tomarai85 <tomarai85@users.noreply.github.com>
Co-authored-by: Neil <neil@stably.ai>
2026-11-08 06:17:53 -08:00