Commit Graph
20622 Commits
Author SHA1 Message Date
Neil 8e7b08c617 refactor(ssh): delete the unused SFTP session late-error latch (#31909) 2026-10-22 01:30:33 -07:00
Neil f3f12a8b03 refactor(ssh): stop exporting declarations used only inside their own module (#31897) 2026-10-22 01:20:00 -07:00
Neil 8d6ad5ffe0 Keep push busy-device lookup correlated to its existing index (#31899) 2026-10-22 01:18:28 -07:00
Brennan Benson 6cd2550e61 refactor(native-chat): share the catch-up open runner across agents (#31622)
* refactor(native-chat): share the catch-up open runner across agents

The Codex catch-up's agent-neutral parts move to one module: the open-time
envelope (its own deadline and cancellation, never gating the open), the
bounded staged batch, the single settlement commit that re-checks the
journal before writing, and the "Continued outside this chat." divider.
Codex keeps only how it reads its saved turns and what the chat already
holds. No behavior change; the other agents' catch-up builds on this
instead of copying it.

* chore: remove unrelated pnpm executable metadata

* refactor(native-chat): the catch-up runner reads the chat's view only when the agent asks

* chore: remove regenerated pnpm executable metadata

* fix(native-chat): the catch-up deadline also bounds waiting for its commit to be written

A journal write barrier that never settled after the import was admitted held
the provider's open past the catch-up deadline. The wait now ends with the
deadline or the open's cancellation, like every other step.

* test: type the history catch-up sink fixture without assertions

* fix(native-chat): bound and revoke history preparation

* feat(native-chat): validate expected saved items during history catch-up
2026-10-22 01:08:46 -07:00
Brennan Benson f6585a3916 Keep Session History checking totals fixed throughout a scan (#30949)
* fix(session-history): freeze scan workload before checking candidates

* test(session-history): handle native fixture path separators

* test(session-history): control bucket fixture enumeration order

* test(session-history): preserve scoped fixture timestamps

* fix(session-history): repair integrated test and locale catalog

* ci: refresh history checks against current main

* ci: refresh history checks after catalog repair
2026-10-22 01:03:09 -07:00
Brennan Benson 33ec2ba9e7 fix(claude): close a cancelled approval card when the journal drains (#31735)
A Claude approval card cancelled while the chat journal was briefly full
waited for a later provider event to retry the cancellation, so an idle
session could leave the card open. The sink's drain wake now retries owed
prompt cancellations alongside owed background-task rows, and reading
still waits for the next drain if the retry fills the sink again.

Tracked in STA-7630.
2026-10-22 01:02:39 -07:00
Neil 4778133a1f ci: share the mobile bundle across SSH Windows host cells (#31883) 2026-10-22 01:01:05 -07:00
Neil d5d9170475 refactor(managed-server): stop exporting declarations used only inside their own module (#31888) 2026-10-22 01:01:01 -07:00
Neil e4959a6bed ci: canary a smaller WSL distro matrix for runtime changes (#31873) 2026-10-22 00:59:49 -07:00
Neil e6ce82f676 test: isolate Windows tree-kill load fixture startup and cleanup (#31891) 2026-10-22 00:56:03 -07:00
Brennan Benson 7c34a48529 fix(native-chat): show a prompt hook's block as its own row for every agent (#30898)
* fix(native-chat): show a prompt hook's block as its own row for every agent

When a prompt hook refused a message, Codex showed nothing, Claude showed
an unmarked warning the turn fold could hide (with a copy of the prompt),
and Grok read as the user stopping the turn.

Each adapter now writes one warning row, "Blocked by hook: <reason>" or
"Hook stopped: <reason>", marked with the hook-outcome presentation that
the turn fold never hides:
- Codex: a blocked or stopped UserPromptSubmit hook/completed frame
- Claude: a warning informational frame that halts the prompt, worded from
  its structured prompt_submit_outcome when present
- Grok: a HookDenied end, from either completion signal under one row
  identity; the turn ends completed instead of interrupted

Nothing new is saved and nothing changes on the wire beyond the new
presentation value.

* fix(native-chat): end a hook-denied Grok turn on its first signal, and clean older Claude block wording

Follow-ups from the size review of the hook-row change:
- Grok: a hook-denied turn_completed now ends the turn and writes the row
  straight away, instead of waiting for the prompt's answer; a later answer
  changes nothing.
- Claude: when an older Claude sends only its sentence, the row keeps the
  hook's reason and drops the hook path and the copy of the prompt. Whether
  the row shows still depends only on prevent_continuation.
- The turn-ending shape is declared once, the Codex hook payload is read
  once, and the Codex hook row returns early instead of threading through
  the generic frame row.

* test(native-chat): cover hook-block rows with real Grok frames and a preserved send

- Replace the source-derived Grok fixture with frames captured from Grok
  1.0.62 (session, prompt ids renamed to the test's).
- One whole-flow file, three parameterized cases (Codex, Claude current and
  older wording, Grok in every completion order), on the shared timeline
  rig with a per-agent journal identity.
- Each case starts with a send on record and checks it is unchanged after
  the reopen.

* fix(native-chat): word every Claude prompt-hook refusal, and draw the Codex hook row like the others

- Claude: a plugin module's dropped_by_hook / not_passed_on refusal reads "Blocked by hook" too.
- Older Claude sentence: an empty reason no longer turns the prompt copy into the reason; each hook's
  path label goes per line, while a hook's own [TAG]: stays.
- Codex: the prompt-hook row is read once, before classification, and carries no raw-frame
  disclosure, so it matches the Claude and Grok rows. The hook/completed table entry is back to main's.
- Comments the change had made wrong are corrected.

* fix(native-chat): strip only the older Claude sentence's first hook label, as before

Command labels without a slash were kept and labels inside a hook's own text were removed; the
first-line strip is back, with the empty-reason fix kept.

* refactor(native-chat): keep a hook's block row visible as a generic turn notice

The fold never hides a row presented as 'turn-notice', a host notice about the turn, instead of
a hook-specific value; the hook rows write it for every agent.

* fix(native-chat): report a Claude prompt hook's exit-2 block once

With hook events on, Claude also sends the blocking UserPromptSubmit hook's exit 2 as an error
hook_response; that is the block itself, already shown by the halting warning, so it writes no
red hook-failed row. Other hook events and exit codes are unchanged.

* docs(native-chat): say a prompt hook's exit 2 may also be a missing plugin script

* test(native-chat): type the Claude hook-outcome frame as a record

* fix(native-chat): keep a blocked Codex prompt's turn on its own message

Codex never echoes a prompt its hook refused, so its turn was anchored on the send only while
the send read in flight. Once the turn ended the host publishes the send as in doubt, the anchor
fell back to the turn record, and the block row moved to a second turn: live, the chat drew two
"Worked for" bars; after a reopen the bar sat on the row instead of the message. A send in doubt
now keeps anchoring the turn it opened (the first send in flight, else the newest in doubt).

* fix(native-chat): keep refused Codex hook notices outside turns

* revert(native-chat): keep Claude's exit-2 prompt hook_response as main's red row

A missing plugin script also reports exit 2 without blocking, so suppressing it hid a real failure main shows. With a user-added --include-hook-events an exit-2 block shows both rows (known limit).
2026-10-22 00:56:00 -07:00
Neil 43c32582e0 refactor(orcad): stop exporting declarations used only inside their own module (#31894) 2026-10-22 00:51:22 -07:00
Neil 2078db93ec ci: check dependency vulnerabilities on PRs and stable releases (#31858)
* ci: audit dependency security without gating releases

* ci: audit stable release tags instead of running daily

* ci: isolate release audit data and fix integration checks

* ci: require exact audit inputs and ignore candidate archive attributes
2026-10-22 00:43:07 -07:00
Neil 213bc4684d ci: distinguish indirect unit inputs from comments and data (#31876) 2026-10-22 00:42:21 -07:00
Neil 66e50e22cc fix(images): avoid backtracking in data URI parameter parsing (#31882) 2026-10-22 00:24:41 -07:00
Neil 0964562786 refactor(orcad): drop the toolchain probe's unread toolchainMissing verdict (#31875) 2026-10-22 00:23:32 -07:00
Neil 7e967c8968 refactor(ssh): split host key verification, the ssh2 handshake, the system ssh probe and the credential fallback out of SshConnection (#31878) 2026-10-22 00:23:12 -07:00
Neil 005060ac7a refactor(relay): group assignment cleanup and diagnostics (#31871) 2026-10-22 00:21:02 -07:00
Neil 3d1b8e396e fix(ci): restrict manual candidate test workflows to read-only caches (#31887) 2026-10-22 00:19:38 -07:00
Neil 7ff3a071c6 fix(docs): avoid backtracking in excerpt link destinations (#31884) 2026-10-22 00:19:14 -07:00
Neil 9e1ffb2333 fix(plugins): validate example panel reply dispatch (#31877)
* fix(plugins): validate example panel reply dispatch

* style(plugins): brace panel reply admission guard
2026-10-22 00:19:10 -07:00
Neil 95f8f73b9a ci: include retry attempts in runner demand reports (#31865) 2026-10-22 00:05:32 -07:00
Neil 73841a0720 fix(worktrees): pick a repo's catalog watcher transport from its resolved SSH target (#31872) 2026-10-22 00:02:14 -07:00
Neil 57f1fce9bb refactor(runtime): type worktree query stores with checked guards instead of casts (#31864) 2026-10-21 23:53:30 -07:00
Neil 70e997f4e5 refactor(runtime): resolve a watched repo's host through the canonical routing API (#31866)
* refactor(runtime): resolve a watched repo's host through the canonical routing API

* test(runtime): drop an unused mock reset
2026-10-21 23:44:49 -07:00
Jinwoo Hong 01db1b89af Main titles agent tabs and applies phone tab moves itself, and tab moves name the tab they follow (dark, layout-owner build only) (#31812)
* Layout groundwork (switched off): main derives agent tab titles from its own hook status

With the layout-owner switch on, main gives agent tabs their generated titles from
the hook-server status it owns, on the desktop, headless serve and orcad: one
renameTabs per status batch, so one write and one frame. It keeps the window's
rules (setting, custom and quick-command titles, first title wins, dispatch labels).
The window stops sending generated titles for tabs main holds; a paired server's
tab, or one main has no tab-bar entry for, is still titled by the window as today.

The title rules move to src/shared (agent-row-primary-text, and the new
agent-generated-tab-title-rules) so both sides share them; switch-off behaviour
is unchanged.

* feat(layout): main applies a phone's or paired client's tab move itself, and a tab move names the tab it follows so a stale index can't misplace it (layout-owner build, L193)

* fix(layout): a move in a group showing a tab main lacks goes the window's way, a twin's agent tab keeps its window title, and orcad subscribes titles through the store attach (layout-owner build)

* chore(layout): main's tab move reaches the old-client translation through its compat entry

* chore(layout): mark the window-only-row move fallback as bridge code (ledger L280)

* test(layout): attaching the hook store follows its rows for main's tab titles once

* chore(layout): the old-client move translation is a compat entry of its own, with no cyclic re-export

* test(config): the boundary message test names the old-client folder's configured entries
2026-10-22 02:24:37 -04:00
Neil 1769476014 fix(wsl-host): pair again from the distro when a WSL host refuses the enrolled token (#31745)
* fix(wsl-host): pair again from the distro when a WSL host refuses the enrolled token

A WSL host that lost its device registry, or revoked this desktop, refused the
enrolled token forever, and an update over it read as deferred. The connect now
re-pairs through the managed repair gate SSH uses (one repair at a time, a
capped number per window, only an offer under the pinned host key), reading the
host's published offer from the distro. The incumbent's terminal count uses the
same enrolled-or-live pairing the connect does.

* fix(wsl-host): retire a bridge whose pairing was refused, and let a user's Connect retry a repair

A refused or repaired-then-refused pairing on a reused bridge left its stale
token cached, and the failure status then saved it over the repair. That bridge
now closes first. A user-initiated Connect clears a standing repair failure or a
spent cap, as an explicit SSH connect does.

* fix(wsl-host): retire a refused bridge without cancelling a queued Update or Force

* fix(wsl-host): repair only a stored pairing, dispose the repair's transport directly, and log refusals neutrally

A host still being added has no stored record for the gate to re-pair, so its
live bridge is reused as before. The WSL repair deps are typed with the WSL
transport, and the shared refusal log no longer says SSH for WSL.
2026-10-21 23:15:59 -07:00
Neil 8e1ee111e4 ci: avoid global fan-out for routing test changes (#31856)
* ci: avoid global fan-out for routing test changes

* test(ci): isolate routing-test classification cases
2026-10-21 23:15:55 -07:00
Neil 42da9f430f refactor(mobile): group platform-seam analysis tools (#31845) 2026-10-21 23:15:21 -07:00
NeilandClaude 57ecdc2ca2 fix(ssh): say what plain SSH is for beside its button, and polish the plain SSH window (#31732)
* fix(ssh): point unclearable move conflicts at plain SSH, and polish the plain SSH window

Conflicts retrying can't clear now say how to keep working on the host. The
plain SSH terminal paints its theme background past the grid, and a failed
open shows only its error, not an empty terminal.

Co-Authored-By: Claude <noreply@anthropic.com>

* fix(ssh): say what plain SSH is for beside its button, not in main's refusal text

Main's refusal text also reaches clients without a plain SSH terminal, so the
next step is shown next to the button wherever it renders. Also: a translucent
theme isn't painted twice, and a failed open shrinks to its error.

Co-Authored-By: Claude <noreply@anthropic.com>

* fix(ssh): treat only opacity below 1 as a translucent plain SSH background

Co-Authored-By: Claude <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-10-21 23:06:39 -07:00
NeilandWooseong Kim 051221c3bf fix(mobile): preserve prompt taps after terminal scrolling (#31471)
Preserve deliberate terminal taps after scrolling and keep them ordered with Live input. Retain fresh keyless edits, cap coalesced sends at the existing UTF-8 request limit, and settle cancelled flush barriers without waiting for retired acknowledgements.

Adapted from @innocarpe's community PR #30514, with additional ordering, lifecycle and bounded-send regressions.

Fixes #30510

Co-authored-by: Wooseong Kim <innocarpe@gmail.com>
2026-10-21 23:01:13 -07:00
Neil 9b060ebec0 fix(i18n): preserve runtime entries after removing untracked settings (#31852) 2026-10-21 23:01:10 -07:00
Neil ad4952e1da ci: retire completed relocation and pnpm cache experiments (#31843) 2026-10-21 22:37:06 -07:00
Neil 8b5c732e6e ci: skip relay integration for renderer-only PRs (#31842) 2026-10-21 22:31:54 -07:00
Neil 6698df3277 Polish explorer search layout and collapsible filters (#31825)
* Polish explorer search layout and filter disclosure

* Use compact search details disclosure and lowercase filter labels

* fix: preserve query focus when switching explorer modes

* fix: announce active explorer search filter counts
2026-10-21 22:26:05 -07:00
Jinjing 8b6f31c68b Stabilize pending admission refusal option retry test (#31840) 2026-10-21 22:24:05 -07:00
Jinjing 8aa7f9c047 Combine untracked files into Changes (#31831)
* Combine untracked files into the Changes section

* Localize discard warnings
2026-10-21 22:23:59 -07:00
Neil 6c6ad7520f ci: vet adhoc source before build preparation (#31839) 2026-10-21 22:22:45 -07:00
Neil 019ff406f0 ci: deny cache writes from benchmark candidate code (#31838) 2026-10-21 22:20:30 -07:00
Neil b342d29cc1 test: drop obsolete streamparser dependency (#31835) 2026-10-21 22:19:46 -07:00
Neil f9c9cedad3 ci: declare read-only workflow token permissions (#31836) 2026-10-21 22:17:05 -07:00
Jinjing aa5594d536 fix(native-chat): handle inline image preview edge cases (#31742)
* fix(native-chat): handle inline image preview edge cases

* Improve native chat image preview resilience
2026-10-21 22:15:33 -07:00
Neil 70ab09ca2f refactor(settings): group repository identity modules (#31830) 2026-10-21 21:54:24 -07:00
eba0124de9 [mem] Backpressure worker subprocess output without dropping bytes (#30698)
* fix(memory): backpressure worker subprocess output without dropping bytes

* style(wsl): clear formatting gates without increasing line limits

* test: cover Codex deadlines and shutdown under worker backpressure

* test: synchronize backpressured Codex deadline fixture

---------

Co-authored-by: m4air <m4air@Mac.localdomain>
Co-authored-by: Neil <neil@stably.ai>
2026-10-21 21:52:41 -07:00
Neil 35596d16a5 chore: replace electron-toolkit utilities with Electron APIs (#31824)
* chore: replace electron-toolkit utilities with Electron APIs

* refactor: reuse development flag within startup preflight
2026-10-21 21:52:08 -07:00
Jinjing b0778082cb fix(i18n): recover language selection after rejected catalog loads (#31822)
* fix(i18n): allow retrying rejected language catalog loads

* fix(test): return null for unhandled locale asset imports
2026-10-21 21:46:29 -07:00
Jinjing dfa8788533 fix(i18n): restore localized editor safety copy (#31259)
* fix(i18n): restore localized editor safety copy

* Refine French and Chinese file change translations
2026-10-21 21:46:10 -07:00
Neil 0a7d6bb2d5 refactor(main): group ephemeral VM lifecycle modules (#31771) 2026-10-21 21:31:21 -07:00
Jinjing 60f5cd7118 fix(mobile): announce locked picker notice on iOS (#31674)
* fix(mobile): announce locked picker notice on iOS

* Prevent stale queued iOS picker announcements

* update test
2026-10-21 21:21:59 -07:00
Neil 3cca64bef6 fix(mobile): keep a closed branch preview from reopening when loading finishes (#31707)
* fix(mobile): retire dismissed branch diff requests

A pending branch diff reopens a dismissed drawer and blocks replacement previews. Retire requests on dismissal and host/workspace changes, and keep spinner ownership with the current request.

* fix(mobile): retain branch preview through suspended transitions

* test(mobile): retain confirmed branch previews across connection cutover
2026-10-21 21:20:56 -07:00