A restored plaintext envelope can match the rejected replacement byte for
byte. Do not delete that file, since it is the previous key rather than a
new secret.
A failed plaintext replacement can publish the new key before file
restriction is confirmed. If restoring the previous key fails before it
replaces that file, delete only the rejected envelope so a completed
restore is left intact.
Automatic inactive Claude account refreshes now reuse each account’s existing retry deadline before sending requests. Healthy accounts keep refreshing, and manual forced refresh retains its current behavior.
Partially addresses #26588.
Co-authored-by: Tauri-EPO <enrico.pin@gmail.com>
* docs(rpc): paired workspace access runs commands as the user; pairing dialogs say so
* docs(rpc): mobile is gated by its allowlist, not by tier
* docs(rpc): wrap comment
---------
Co-authored-by: m4air <m4air@Mac.localdomain>
Preserve names entered after selecting a work item in desktop, mobile and folder creation. Reuse the existing source and last-generated-name state, and avoid repeating source naming when a delayed base lookup finishes.
Verified the current-main merge composition: 70 focused tests and renderer typecheck pass; newer execution-host routing and folder launch checks remain intact. The reviewed PR head has no failed or pending CI checks and no unresolved review threads.
* chore(settings): rename "Active Server" to "Default host for new projects"
The setting (still activeRuntimeEnvironmentId) now only picks the host for new
projects with no source and the initial host of the Settings host picker, so
the copy says that. Refusal and help text say existing projects stay on their
own host, the provider-scope hints point at the Settings Host menu, and the
Remote Orca Servers search entry keeps "active server" as a keyword.
* fix(settings): credential hints point at the setting that still scopes them
---------
Co-authored-by: m4air <m4air@Mac.localdomain>
* chore(lint): delete the focus-routing helpers; bypassing owner routing fails lint
The last six renderer sites (Settings visibility defaults, preflight readiness,
Linear key dialog copy) mirror the default scope host and now say so through
defaultScopeHost. getActiveRuntimeTarget and settingsForRuntimeOwner are
deleted with their re-exports, the unused settings-fabrication helpers go with
them, and the owner-routing baseline is empty, so any new use fails lint. The
provider dispatch rationale is rewritten in neutral, shorter terms.
* test(preflight): keep the existing cast's rationale on the edited line
---------
Co-authored-by: m4air <m4air@Mac.localdomain>
* refactor(worktrees): worktree create, listing, removal and repo hook/ref reads route by their owner
Worktree create, prefetch, detected listings and missing-terminal teardown,
preserved-branch cleanup and removal follow the repo or workspace owner.
Repo hook and base-ref reads take the repo's host id instead of settings.
Composer, settings panes and the setup guide pass the selected repo's host.
* test(hooks): build the duplicate-row state without a cast
---------
Co-authored-by: m4air <m4air@Mac.localdomain>
* [CI] Reduce repeated test setup and remove source text checks
* [CI] Consolidate transcript tests and preserve fixture-only CI routing
* [CI] Retarget reliability gate to consolidated transcript suite
* refactor(git): git calls route by the worktree's owner
RuntimeGitContext carries the owner's transport (target) instead of a
settings object, so raw focus settings no longer compile at a git call.
Source control, the checks panel, diff loaders, fork sync, lineage,
worktree metadata, review push targets and diff-comment persistence derive
it from the repo or worktree rows (resolveOwner) or a captured owner.
Editor-slice remote actions take an explicit runtimeTarget and otherwise
resolve the worktree owner; an unresolved owner is refused, never sent to
the focused server. Generation preferences ride a separate prefs field.
* fix(work-items): one owner row routes direct-launch preflight, PR start point and create
* fix(review): PR dialog effects key on the host, not the target object
A fresh target literal per render re-ran base-ref discovery forever and ran the
test worker out of memory.
---------
Co-authored-by: m4air <m4air@Mac.localdomain>
Combine related chat, worker-release, and filesystem tests while retaining their contracts. Replace fixed Codex terminal waits with observed readiness and hook completion. Keep runtime database contracts under Node.
Local measurements and all CI lifecycle costs are documented in PR #27297.
Catalog fetches, path-status probes, project and group mutations, nested
scans and imports now take the owner's host explicitly instead of falling
back to the Active Server setting. A new project with no picked host still
goes to the default host, through defaultCreationHost.
Co-authored-by: m4air <m4air@Mac.localdomain>
* refactor(sources): row-less sources and host-less surfaces name their host
Linear and Jira clients take a RowLessSource: a task-source context, an
explicit host, or defaultScopeSource(settings) when no Tasks source is
chosen, so raw settings no longer compile. defaultScopeHost joins
defaultCreationHost as the second sanctioned reader of the default-host
setting (both behind one private read, both ratchet seeds), and the status-bar
account switchers, settings navigation and the settings host picker's initial
default use it. Skill discovery routes by the owner id its install terminal
resolves, and the workspace-board Linear sync by the workspace owner.
* fix(lint): count the default scope source and assign-then-return readers
defaultScopeSource is a sanctioned read of the default host, so its call
sites count. A function that assigns a reader's result to a local and returns
that local is a reader too, which keeps the skill-discovery hook counted.
---------
Co-authored-by: m4air <m4air@Mac.localdomain>
getRuntimeRepoTarget takes the transport its caller already routed by
instead of reading the Active Server setting (with a raw focus default).
Work-item, comment, check and review-thread requests get it from
getGitHubSourceTarget (task source host, else the repo's owner); PR
lookups from the repo row; PR refreshes from the candidate's owner.
Hosted-review fetches route by hostedReviewRepoOwnerTarget. An unknown
repo stays on this computer instead of following the focused server.
Cache keys are unchanged. Deletes settingsForHostedReviewRepoOwner,
settingsForGitHubFocusedRepoOwner and getGitHubWorkItemSourceSettings.
Co-authored-by: m4air <m4air@Mac.localdomain>
Agent note sends, background agent and terminal launches, structured chat
reveal and activation, and the tab strip's Windows shell probe take their
transport from the workspace owner's environment instead of building
owner-shaped settings for getActiveRuntimeTarget. The automation observer and
the Codex selection lane read the owner from the PTY id alone, so an
ownerless remote id is never assigned the focused server. Local
advertised-URL events always rescan this computer, even when a server is
the default host.
Co-authored-by: m4air <m4air@Mac.localdomain>
* refactor(terminals): terminal input and inspection route by the PTY's owner
A remote PTY id already names the server that owns it. inspect, confirm,
send, verified send and the data subscription took settings only to fall
back to the focused server for an id without an owner segment, so an old
ownerless id could reach a server that does not own it. They now route by
the id alone: an ownerless remote id is never dialed and never confirmed
locally.
Dropping the parameter removes the settings plumbing the native chat,
agent draft paste and follow-up paths carried only for this, including the
raw focused-settings default in sendBracketedPasteToAgent, and deletes
getSettingsForAgentTabRuntimeOwner.
* test(e2e): native chat SSH delivery and remote completion follow the narrower terminal signatures
---------
Co-authored-by: m4air <m4air@Mac.localdomain>
* refactor(files): file reads and edits route by the file's owner
The runtime file clients took a settings object and turned its Active Server
field into a connection, so any caller that passed raw settings silently read
or wrote on the focused server. They now take `target: RuntimeClientTarget`,
and every caller derives it from the owner: the tab's stamped owner, else its
worktree's owner (getRuntimeTargetForFileOwner / getRuntimeTargetForWorktreeOwner),
the file-explorer operation owner, or an already captured owner id.
Behavior: single-host (local-only) users see no change. An editor tab opened
without an owner stamp, a terminal link with no PTY owner, an OS file drop and
a notebook link now go to the workspace's owner instead of whichever server is
focused when the read happens.
Removes getEditorFileDropSettingsForWorktree and the native-chat settings clone
cache; settingsForWorktreeOperationRoute loses its editor caller.
* fix(files): file owner targets come from the rows, never the focused server
getRuntimeTargetForWorktreeOwner/getRuntimeTargetForFileOwner move to
lib/file-owner-runtime-target.ts and resolve through the focus-free
resolveOwner. A workspace with no row yet stays on this app (tabs and drops
stamp a server owner when one exists); rows that disagree return null, and
callers with an error path refuse via requireRuntimeTargetForFileOwner.
* test: keep the editor content-state fixture within the line limit
* fix(files): an unresolved document owner blocks local image reads
A null owner target became runtimeContext undefined, which image readers take
as a plain local file, so a server-owned document's images were read from this
machine. It is now runtimeContext null, the readers' do-not-load sentinel, in
the rich editor and the preview, and prewarm skips it.
* fix(files): read the image node view's storage through a named type
---------
Co-authored-by: m4air <m4air@Mac.localdomain>
GitHub PR and issue dialogs, task-page cells, Project boards, slug metadata,
the repo slug index, hosted-review actions, GitLab MR base resolution and the
Settings API-budget panels now carry a RuntimeClientTarget derived from the
repo row, the row-less task source, the board row's cache key or the Settings
host scope, instead of settings-shaped objects resolved through
getActiveRuntimeTarget. A repo row with no owner stamp is local; an untracked
Project row edits on the host that loaded it.
Owner-routing ratchet 209 -> 165; focus-read ratchet 401 -> 352.
Co-authored-by: m4air <m4air@Mac.localdomain>
* refactor(runtime): owner transports, the creation default and a focus-read ratchet
Adds runtimeTargetForOwnerEnvironment, runtimeTargetForOwnerHostId and
runtimeTargetForWorkspaceOwner so routed call sites can get a transport from
the resource's owner, and defaultCreationHost as the one sanctioned reader of
the Active Server setting for creation flows with no source row.
The owner-routing ratchet gains a second per-file counter for reads of the
setting (member reads, the focus-routing helpers and defaultCreationHost), so
swapping a helper for a direct read can no longer lower a count. Baseline rows
may carry a trailing note that survives --prune.
* chore(lint): pin defaultCreationHost's own read in the focus-read baseline
* fix(lint): the focus-read ratchet counts shared focus helpers and destructuring reads
* fix(lint): discover functions that read the default host instead of hand-listing them
A hand list let a look-alike such as getAutomationListTarget replace
getActiveRuntimeTarget and lower both ratchets. Every exported top-level
function whose body reads the setting or calls a seed helper now counts as a
reader, and nested destructuring reads count too.
* fix(lint): readers are found through imports and returned values
Readers are keyed by defining file and resolved through imports and
re-exports, so a same-named function elsewhere is not mistaken for one, and
a function that returns a reader's result (a wrapper of a wrapper) is found
too. Components are not readers, and a declaration ends at the next
top-level statement.
* fix(lint): a reader called through a namespace or dynamic import still counts
* fix(lint): renamed, parenthesized and .then() dynamic imports bind readers too
---------
Co-authored-by: m4air <m4air@Mac.localdomain>
* fix(sources): GitHub Projects boards read from the task page's source host
The Projects board, its project picker and unmatched-row edits picked their
host from the Active Server setting on their own, while the Tasks header
named the selected repositories' hosts. The board now takes the same
row-less source host that Linear and Jira use, converted through
getTaskSourceRuntimeSettings, and the header names that host in Projects
mode. fetchProjectViewTable takes the source explicitly instead of reading
settings. The ownership table marks the four board-level GitHub Projects
reads as scope-picked.
* fix(github-projects): an open unmatched-row dialog keeps writing to its row's host
The dialog took the board's live source, so a source change while it was
open sent its comment and field edits to a different host than the one the
row was loaded from. It now routes by the source encoded in its row's cache
key, like the row field edits already do.
---------
Co-authored-by: m4air <m4air@Mac.localdomain>
* fix(web): the paired server is the web client's only host
A paired web client is a browser tab with no PTYs, files, browser or
second window of its own, yet owners it read as "local" still routed to
it: setup terminals and server-local rows hit the local PTY stub, the
dashboard pop-out was a silent no-op, Open in Orca Browser threw an
uncaught error, and the macOS traffic-light inset was reserved.
Route a transport-less owner through the paired server at the shared
owner resolvers, open the in-window dashboard, refuse document previews
with a reason, and reserve no traffic-light inset in the web client.
Co-Authored-By: Claude <noreply@anthropic.com>
* test(web): type the owner fixtures instead of casting
Co-Authored-By: Claude <noreply@anthropic.com>
---------
Co-authored-by: m4air <m4air@Mac.localdomain>
Co-authored-by: Claude <noreply@anthropic.com>
* feat(settings): host-owned settings panes choose their host explicitly
Settings gets a Host menu (this computer or a saved server). Provider
accounts, agent detection and terminal capabilities follow it instead of
the Active Server setting, which is only the menu's starting value. A
server that is no longer saved reads unavailable and never falls back to
another host. The provider-account client now takes the owner target
instead of settings.
* chore(i18n): regenerate runtime-required English catalog
* fix(accounts): Codex restart notices follow the host the switch wrote
A Settings account switch on the chosen host flagged panes on the focused
host instead. markLiveCodexSessionsForRestart and its lane matcher now take
the owner target explicitly; Settings passes the picker's host, the status
bar its focused target, and local sign-in this computer.
---------
Co-authored-by: m4air <m4air@Mac.localdomain>
While the Resource Manager is open, each paired server that hosts one of this
client's projects is asked for its own process samples through the existing
diagnostics.memory method, and those rows render under the server's projects,
named by host and without a kill control. A server that cannot answer is named
as unknown instead of looking idle.
Co-authored-by: m4air <m4air@Mac.localdomain>
* fix(accounts): a server's late account result stays with that server
The Accounts pane kept one roster across default-runtime changes, so a
select or remove still in flight on the previous server overwrote the new
owner's roster when it returned. Key the pane by its account owner so
rosters, account ids and in-flight results are scoped to one owner.
Co-Authored-By: Claude <noreply@anthropic.com>
* fix(accounts): drop a stale owner's result instead of remounting the pane
Remounting lost an in-progress local login's spinner and Cancel button and
hid an account added after returning to the same owner. Guard each action's
result by the owner it was sent to instead.
Co-Authored-By: Claude <noreply@anthropic.com>
* fix(accounts): keep the stale-owner check on the roster write only
The toast, settings refresh and restart prompt describe what happened on
the owner the action went to; only the roster belongs to the shown owner.
Co-Authored-By: Claude <noreply@anthropic.com>
---------
Co-authored-by: m4air <m4air@Mac.localdomain>
Co-authored-by: Claude <noreply@anthropic.com>
* fix(hosts): agent launch platform and shell come from the execution host
Agent startup commands were quoted for this client's OS (and its Windows shell
setting) whenever the workspace's repo row had no SSH connection, so a Windows
client driving a Linux Orca server sent PowerShell to bash. SSH hosts were
guessed from path shape.
One resolver now reads the OS from the host that runs the agent: the server's
reported hostPlatform, the relay-reported SSH remotePlatform (nested SSH read
through its server), WSL as linux, and this client only for local workspaces.
A missing fact withholds the launch with a reason. Plain-SSH mode now
publishes the OS the runtime ladder detected.
* fix(hosts): new-tab and background launches read the worktree's own host
Review follow-up: the new-tab resolver reads folder workspace paths (WSL folders),
a caller's platform only refines a local launch, background launches resolve the
worktree's host (nested SSH) and drop this client's shell setting for remote hosts.
* fix(hosts): background launches on an SSH worktree keep the relay CLI name
---------
Co-authored-by: m4air <m4air@Mac.localdomain>
Discovery skipped every SSH-backed repo without a trace, so the Skills page
counted only local folders and never said a repo was left out. Each skipped
SSH repo now appears as a source with skippedReason 'remote-repo', which the
Skills folder list already renders as 'Remote repo - not scanned'.
Co-authored-by: m4air <m4air@Mac.localdomain>
* fix(ports): the ports panel scans and stops on the workspace's own host
The panel now picks its host from the workspace owner instead of the repo's
connectionId and the Active Server. A direct SSH or recipe VM workspace uses the
SSH view for its own target; an SSH target behind a paired server is scanned by
that server through workspacePorts.scanHost (workspace-ports.host-scoped.v1),
and Stop goes through killHost with the host the row was scanned on. An older
server is never asked and the panel says to update it; an unknown owner says so
instead of scanning another host.
* fix(ports): scan recipe VMs through this app's runtime so an unreachable VM reads as unavailable
Recipe VM targets publish no connection state to the renderer, so the SSH view
cannot tell a reachable VM from one whose relay is reconnecting. Route them
through workspacePorts.scanHost on this app's own runtime, which reports a
missing relay as unavailable, and keep the SSH view for user SSH targets.
* fix(ports): keep the host-scoped panel's host stable without a render-time ref
---------
Co-authored-by: m4air <m4air@Mac.localdomain>
* feat(terminals): dashboard terminal previews from the owning host
A paired host's agent pane now previews over the same multiplexed terminal
stream panes already use, routed by the host named in the pty id. The web
client and desktop pop-out no longer render a blank dialog when no preview
bridge exists; they show the unavailable message instead.
* fix(terminals): hold the preview's snapshot boundary and transport credit
A requested snapshot is followed by every chunk the host buffered, covered
ones included, so live output is now trimmed against the snapshot's output
high-water for as long as the stream lives. Each emitted chunk keeps the
host's delivery credit until the preview parses it, so a slow preview
applies backpressure instead of overrunning its parser.
---------
Co-authored-by: m4air <m4air@Mac.localdomain>
* fix(review): PR reads and actions follow the repo owner, not a host-less task source
A GitHub task source without a runtime host used to spread
activeRuntimeEnvironmentId: null over the repo owner's settings, so
assignee, reviewer, label, status and merge cells for a runtime-owned
repo ran on this desktop. Every PR read and action site now routes
through getGitHubRepoRoutingSettings (renamed from the merge-only
helper), and the store's source-scoped routing defers to the repo owner
the same way. Focus is never a fallback.
Fixes#7623
* fix(review): a host-less source never inherits an ambiguous repo owner
Duplicate repo ids across hosts made the host-less source fallback pick a
server owner by focus (UI) or by first row (store), so a local item could
read or write on a paired server. The owner is now inherited only from
the single row with that id; ambiguity stays on the source's own host.
* test: drop stale repo-owner mocks from GitHub repository scripts
---------
Co-authored-by: m4air <m4air@Mac.localdomain>
* fix(review): GitLab reads and actions run on the repo's own host; failed reads show as errors
GitLab task lists, the item dialog, right-sidebar MR actions and the Checks
panel now pick their host from the repo or workspace row: a server-owned
repo asks its server over runtime RPC, a local or SSH repo uses this
computer's glab. The focused Active Server is never consulted. The runtime
arm reuses the web client's gl-over-RPC table, now shared.
A failed checks or comments read in the Checks panel renders as an error
that names the machine that answered, instead of 'No checks configured'.
* fix(review): keep the server for SSH workspaces behind it; pin the MR host for post-launch thread resolves
An SSH workspace reached through a paired server keeps ssh:<target> as its
host and names the server separately; its GitLab credentials live on that
server, so the Checks panel and job-log tab now route there.
A comment-resolution launch now records the MR's credential host when it is
queued, so the post-launch resolve no longer looks the repo up by a bare id
that two hosts can share.
---------
Co-authored-by: m4air <m4air@Mac.localdomain>
* fix(terminals): automation runs, CLI tabs and folder-workspace browser tabs follow the owner
- An automation run on a paired server opens its mirrored pane, or asks the
server to focus it when the mirror has not loaded it yet, instead of
reporting "Run terminal is unavailable." while the server still runs it.
- This desktop's CLI browser tab create/close/profile requests are refused
only for a workspace a paired server owns, not whenever a paired server is
the Active Server.
- browser.tabCreate resolves folder workspaces for server-hosted pages, as it
already did for client-hosted ones.
* fix(terminals): refuse ambiguous browser owners and name a failed run reveal
---------
Co-authored-by: m4air <m4air@Mac.localdomain>
* fix(terminals): terminal IDs, agent rows and dashboard rows follow the owner
Copy Terminal ID on a paired-server pane copies the owning server's handle
instead of asking this desktop's runtime, which has no record of that pane.
Sidebar agent rows and dashboard reveals tell the workspace's owning server
which tab was opened, as a tab-strip click does. A paired-server dashboard card
with no preview says the session is remote instead of claiming its pane closed.
* fix(terminals): owner activation keeps the picked pane and yields to later navigation
The row and dashboard reveal now send the exact split pane to the owner and
record it in the focus intent, guarded by the tab visible at the click, so a
later navigation away is never overridden when the tab arrives.
---------
Co-authored-by: m4air <m4air@Mac.localdomain>
* fix(files): a link to this computer in a paired-server terminal opens here when the host disowns it
* fix(files): keep client-local link tabs on this computer; gate the fallback on host support and native clients
---------
Co-authored-by: m4air <m4air@Mac.localdomain>
The new-workspace composer addressed a paired server's files by the project
path instead of the project's worktree id, so every drop onto a server-owned
project was refused with selector_not_found. Pass the repo's main worktree id
so the existing import transaction (unique temp, no-clobber commit, fenced
cleanup) runs against the right worktree.
Fixes#16558
Co-authored-by: m4air <m4air@Mac.localdomain>
Neil
Luchong
Jinwoo Hong
NeilandTauri-EPO
OrcaWinandm4air
github-actions[bot]