* fix(terminal): restore Polish / US-Extended Option+letter composition (#1205)
The macOptionAsAlt layout probe only inspects `navigator.keyboard.getLayoutMap()`,
which surfaces the base (unshifted) layer. Polish Pro, US Extended, ABC
Extended, and the CJK Roman IMEs all ship a US-QWERTY base layer and put
their dead-key composition on the Option layer — invisible to the
fingerprint. The probe therefore classified them as `'us'`, flipped
`macOptionIsMeta=true`, and xterm.js translated every Option+letter into
an Esc+letter readline chord, silently swallowing ą, ć, ę, ł, etc.
Adds a main-process IPC that reads macOS's
`AppleCurrentKeyboardLayoutInputSourceID` (the same signal Ghostty uses
via TISCopyCurrentKeyboardInputSource) and an explicit denylist of input
source IDs whose Option layer composes. When the active ID is on the
denylist, the probe forces `'non-us'` so `effectiveMacOptionAsAlt`
resolves to `'false'` and Option+letter compositions reach the shell.
Co-authored-by: Orca <help@stably.ai>
* fix(terminal): widen Option+letter composition fix to ABC + all non-US layouts
My earlier attempt at #1205 missed the broader bug: Option+A wasn't working
on the plain "ABC" layout either (Option+A → å got swallowed). Two
corrections:
1. systemPreferences.getUserDefault only reads NSGlobalDomain / the app's
own domain. AppleCurrentKeyboardLayoutInputSourceID lives in
com.apple.HIToolbox, so the previous IPC returned null on every
machine. Switched to execFileSync('/usr/bin/defaults') with a 500ms
timeout — the same mechanism Apple documents — so the real ID reaches
the renderer. Verified live: the IPC now returns
`com.apple.keylayout.ABC` instead of `null`.
2. The denylist approach was too narrow. macOS ships many layouts that
share a US-identical base layer but compose via Option (ABC, Polish
Pro, US Extended, ABC Extended, every CJK Roman IME). Flipped to an
allowlist matching Ghostty: only com.apple.keylayout.US and
com.apple.keylayout.USInternational-PC get Option-as-Meta; everything
else defaults to compose. When the IPC returns a concrete ID, the
classifier is authoritative and the layout fingerprint is skipped;
the fingerprint only runs as a fallback on non-Darwin / IPC failure.
Verified live in dev: on ABC, Option+A now produces å in the terminal.
Co-authored-by: Orca <help@stably.ai>
* fix(ipc): read keyboard input source ID asynchronously
Avoids blocking the main-process event loop on every focus-in probe
(up to 500ms). Same behavior, same timeout — just non-blocking.
Co-authored-by: Orca <help@stably.ai>
---------
Co-authored-by: Orca <help@stably.ai>
* Render GitHub markdown safely
Co-authored-by: Orca <help@stably.ai>
* Support PR line comment ranges in diffs
Co-authored-by: Orca <help@stably.ai>
* Add GitHub item dialog review workflow
Co-authored-by: Orca <help@stably.ai>
* Make attribution tests environment-safe
Co-authored-by: Orca <help@stably.ai>
* Wire GitHubItemDialog for row clicks and bound file cache
Row clicks in the Tasks GitHub list now open the new GitHubItemDialog
instead of the legacy GitHubItemDrawer, making the PR review workflow
reachable from the main entry point. The unused drawer and its state
are removed.
Also bounds prFileContentCache at 64 entries with LRU eviction so the
module-level map can no longer grow without limit across many PR
openings in a session.
Co-authored-by: Orca <help@stably.ai>
* Convert GitHubItemDialog to a right-side drawer
Replaces the centered Dialog modal with a Sheet drawer (side=right,
max-w 960/1100/1280 across breakpoints) so the review surface slides
in from the side instead of popping over the task list.
Co-authored-by: Orca <help@stably.ai>
* Address review feedback on GitHub work-item details
- Restore full pagination in listAssignableUsers (REST /assignees --paginate)
so repos with >100 assignees no longer silently drop users from the picker.
- Drop redundant REST /users/<login> fan-out in getMentionParticipants; the
aliased GraphQL query already returns login/name/avatarUrl.
- Parallelize mention-participant lookup with checks/participants fetch.
- Avoid mutating caller-provided objects in mergeGitHubUsers.
- Type addIssueComment / addPRReviewComment(Reply) preload wrappers as
Promise<GitHubCommentResult> instead of Promise<unknown>.
- Use typeof startLine === 'number' to harden the review-comment guard.
Co-authored-by: Orca <help@stably.ai>
---------
Co-authored-by: Orca <help@stably.ai>
Co-authored-by: Jinjing <6427696+AmethystLiang@users.noreply.github.com>
* feat(nav): back/forward traverses Tasks page visits
Widens worktree nav history entries to string | 'tasks' so the titlebar
back/forward buttons and Cmd/Ctrl+Alt+Arrow shortcut work from the Tasks
page. openTaskPage records a 'tasks' entry; closeTaskPage rewinds the
index when parked on one; goBack/goForward dispatches Tasks entries via
a separate view activator to bypass openTaskPage side effects.
Co-authored-by: Orca <help@stably.ai>
* test(ui): include worktree-nav-history slice in test store
openTaskPage calls get().recordViewVisit('tasks'), which lives in
the worktree-nav-history slice. The ui.test.ts store was composing
only the UI slice, so the two settings-navigation tests threw
TypeError: get(...).recordViewVisit is not a function.
Co-authored-by: Orca <help@stably.ai>
---------
Co-authored-by: Orca <help@stably.ai>
Widens worktree nav history entries to string | 'tasks' so the titlebar
back/forward buttons and Cmd/Ctrl+Alt+Arrow shortcut work from the Tasks
page. openTaskPage records a 'tasks' entry; closeTaskPage rewinds the
index when parked on one; goBack/goForward dispatches Tasks entries via
a separate view activator to bypass openTaskPage side effects.
Co-authored-by: Orca <help@stably.ai>
The sandboxed TS worker parses concatenated original+modified text in
the diff viewer, producing fake parse errors like "',' expected (1005)".
Disable syntax validation alongside the already-disabled semantic and
suggestion diagnostics; tokenization still provides colorization.
Co-authored-by: Orca <help@stably.ai>
Empty-query Cmd+J now uses pure recency (lastActivityAt) so it's a predictable jump-back surface. Typing still uses smart-sort for ranking. Adds a hint row when worktrees are capped and browser tabs are present.
Co-authored-by: Orca <help@stably.ai>
Skip the local shell.pathExists probe when a connectionId is present and
forward connectionId through to fs.createFile, so 'New Markdown File'
works on SSH worktrees.
Co-authored-by: Orca <help@stably.ai>
SSH workspaces previously rendered as Globe in some places and Wifi in
others. Globe implies web/internet and Wifi implies wireless network
strength — neither reads as "remote machine". Use Server/ServerOff
across every SSH context for a consistent mental model. Globe remains
in true browser/web surfaces (browser pane, address bar, tabs, clone
from URL, Browser settings pane).
Co-authored-by: Orca <help@stably.ai>
- Surface top 3 worktrees under a RECENT WORKTREES header on empty query
when there are ≥4 worktrees, with a WORKTREES header for the rest
- Support "repo/branch" composite queries in the palette search, with
highlight ranges on both segments
- Add placeholder hint for the new composite query
Co-authored-by: Orca <help@stably.ai>
Derive keyboard cycle order from an all-expanded layout so collapsed groups don't cause worktrees to be skipped, and uncollapse the All header on reveal when groupBy is 'none'.
Co-authored-by: Orca <help@stably.ai>
- fix(monaco): disable semantic validation in diff viewer
Monaco's sandboxed TS worker cannot resolve cross-file imports, cascading
into a long tail of false semantic diagnostics beyond the previously-ignored
codes. Replace the growing ignore list with noSemanticValidation; keep
syntax validation for genuine parse errors.
Co-authored-by: Orca <help@stably.ai>
* fix(pty): honor Windows shell selection on the daemon path + shell-specific icons
The "+" menu picker and the Settings → Default Shell preference both set a
shellOverride, but the daemon-backed PTY path never forwarded it. Every
Windows terminal ended up as PowerShell (or cmd.exe via COMSPEC) no matter
what the user picked.
Fix:
- Thread shellOverride through daemon-pty-adapter → createOrAttach RPC →
terminal-host → pty-subprocess, and actually resolve the correct launch
args (chcp for CMD, $PROFILE dot-sourcing for PowerShell, /mnt/<drive>
cwd translation for WSL) on the daemon path.
- Extract the Windows shell-args decision into a shared helper
(resolveWindowsShellLaunchArgs) so LocalPtyProvider and the daemon
spawner cannot drift again.
- In ipc/pty.ts, fall back to the persisted terminalWindowsShell setting
when no per-tab override is sent, so the daemon path honors the user's
Default Shell preference the same way LocalPtyProvider already did.
UI polish on the "+" dropdown and tab strip:
- Drop the "Default" tag next to the top entry (takes too much space).
- Rename "Command Prompt" → "CMD Prompt" to fit next to the Ctrl+T hint.
- Replace the generic terminal glyph with brand-style icons per shell
(ShellIcon). Both the "+" menu and the per-tab strip use the same
icon set so a WSL tab is visually distinct from a PowerShell tab.
Co-authored-by: Orca <help@stably.ai>
* fix(daemon): add oxlint-disable max-lines to daemon-server
CI counts 312 non-blank/non-comment lines for daemon-server.ts after the
shellOverride plumbing was added, exceeding the 300-line .ts override.
The file is a single RPC route table; splitting it would leak the host
reference across modules for no readability win, so add a scoped disable
with the rationale.
Co-authored-by: Orca <help@stably.ai>
* chore(lint): disable max-lines on pre-existing 312-line tabs-hydration test
Unrelated to the shell-selection fix, but surfaced on PR CI: the file is
right at oxlint's 300-line .ts ceiling; each case in the table is a
minimal fixture + assertion, so splitting it across files would scatter
closely related regression coverage for a single reducer.
Co-authored-by: Orca <help@stably.ai>
* chore(lint): disable max-lines on shared text-search module
The shared text-search module exceeds oxlint's 300-line .ts ceiling. It
is the single source of truth for rg arg construction, rg --json parsing,
git-grep submatch parsing, and relative-path normalization shared between
the local main process and the SSH relay. Re-splitting it would
re-introduce the maxBuffer divergence the design doc explicitly calls out.
Also reverts two speculative oxlint-disable directives on daemon-server
and tabs-hydration.test — those files were not the offender; CI's error
message elides the file path but running the lint locally against the
PR-merge commit pinpointed text-search.ts.
Co-authored-by: Orca <help@stably.ai>
---------
Co-authored-by: Orca <help@stably.ai>
Extracts rg and git-grep search logic into src/shared/text-search.ts so
the local main and SSH relay paths stop reinventing arg construction,
JSON parsing, submatch regex, and accumulator/truncation semantics.
Fixes silent truncation in the relay: searchWithRg used execFile with
a 50MB maxBuffer cap that rg --json easily exceeds on large repos,
dropping matches with no error surfaced to the user. The relay now
streams via spawn, matching the local path.
See docs/design/share-text-search.md for full rationale.
Co-authored-by: Orca <help@stably.ai>
- Remove queryDetailsExpanded toggle; always show scope filters in the
Search tab since it is a secondary destination used specifically for
scoped search.
- Left-truncate pre-match text in MatchResultRow so the highlight stays
visible at narrow sidebar widths instead of being pushed off the right
edge. Mirrors VS Code's lcut behavior.
Co-authored-by: Orca <help@stably.ai>
Replace the flaky Radix submenu on the "+" New-tab dropdown with a flat
list of all available shells (PowerShell, Command Prompt, WSL when
present). The configured default shell is pinned to the top, labeled
"Default", and carries the Ctrl+T shortcut hint so users can see at a
glance which shell Ctrl+T will open.
Co-authored-by: Orca <help@stably.ai>
Brennan BensonandOrca
Jinwoo HongandOrca
JinjingandOrca
NeilandOrca
Kevin Acuña
