Commit Graph
20502 Commits
Author SHA1 Message Date
Brennan Benson fa89cc994e Avoid observer handshakes on child-frame load completion 2026-11-09 21:37:07 -08:00
Brennan Benson fb972cd1be Preserve current page recency and private document audio protection 2026-11-09 21:33:11 -08:00
Brennan Benson eb9207fbc7 Update document visibility after React commits 2026-11-09 21:13:34 -08:00
Brennan Benson 8a9adb3d4c Type the browser guest retention regression fixtures 2026-11-09 21:12:59 -08:00
Brennan Benson 0d5eae6481 Bound retained desktop browser guests by idle page count 2026-11-09 21:10:10 -08:00
OrcaWinandOrcaWin fa2a622f9f test: remove low-value launch status and crew hook suites (#40608)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-09 19:24:51 -08:00
Jinjing ce1d0d99b8 Preserve review links during rebases (#40583)
* fix(review): keep the active review linked through a rebase

A detached HEAD (rebase, bisect, checkout of a commit) is no longer treated
as a branch switch. Only an attached observation can clear the active
review and push target, judged against the branch that last proved
ownership: the in-session branch before the detach, else the owning host's
rebase verdict from the listing, else unknown (never cleared). linkedItems
are never cleared.

- shared rule (hosted-review-branch-ownership) used by the renderer writer
  and the runtime WorkspaceGitIdentity
- readRebaseOperation: spawn-free, fail-closed owner-side verdict; git am is
  not a rebase
- listings annotate detached rows with the verdict
- explicit push-target pushes refuse while a rebase is active or unverifiable
- opt-in verifyRebaseOperation status verdict gates review AI launches at
  the action boundary

* fix(review): gate mobile review actions and bound the rebase listing probe

- mobile fix-checks, resolve-comments and hosted conflict launches require a
  fresh owner-side rebase verdict after agent resolution; local conflict
  recovery and generic launches are unchanged
- the listing's detached-row rebase probe has a 2s budget; unread rows stay
  unknown, and a checkout whose read outlived its budget gets no new one
  until it settles
- an empty or malformed HEAD is unverifiable, not a proven detach
- the apply-backend real-Git test is gated on Git 2.26

* fix(mobile): let folder repo review actions launch without a Git verdict

Repo-backed folder workspaces have repo::path ids, so the mobile review-action
gate sent git.status for them and refused the launch. The gate now reuses the
repo the launch context already resolved and, like desktop's isFolderRepo
check, skips the verdict for folder repos; Git workspaces still need a fresh
'none'.

* fix(review): reconcile detached ownership per host and selection

* Fix review action rebase checks for the selected workspace

- Read fresh rebase state from the owning host without a full status scan.
- Rotate detached worktree probes so later worktrees receive checks.
- Avoid reopening the composer when a rebase check refuses launch.

* refactor(review): scope rebase fix to branch ownership

Preserve review associations through detached HEAD using the last confirmed attached branch. Keep unknown ownership conservative and retain host isolation and relink race protection.

Remove the background rebase scanner, rebase-verdict transport, and launch/push gating from this change. Keep the deferred gating work separately and replace the real-Git pipeline tests with focused metadata regressions.
2026-11-09 19:22:27 -08:00
Neil 457c602b4f refactor(automations): group feature modules under defining owners (#40605)
* refactor(automations): group authoring, host catalog, listing and run owners

* Preserve protected automation confirmation copy after owner moves
2026-11-09 19:20:58 -08:00
Wooseong KimandNeil 83d20ac87d fix(claude): keep each account's newest groveChoiceSeenAt during profile state sync (#40381)
Refreshing a managed Claude profile copied the personal ~/.claude.json
groveChoiceSeenAt map over the profile's map, dropping the profile
account's Consumer Terms confirmation. Every new terminal then made
Claude wait on a network check before starting.

Merge groveChoiceSeenAt per account like projects and mcpServers, and
keep whichever timestamp is newer for accounts present on both sides.

Fixes #40380

Co-authored-by: Neil <neil@stably.ai>
2026-11-09 19:14:31 -08:00
Jinwoo Hong 06ee32a8b9 perf(daemon): stop scanning launched agents' output for command-finished (#40599) 2026-11-09 22:07:33 -05:00
OrcaWinandOrcaWin 61d9cea4cf test: remove low-value native chat recovery suites (#40601)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-09 19:03:51 -08:00
Wooseong KimandNeil 86f9bb2a16 fix(native-chat): highlight the slash item whose name best matches the typed query (#40487)
Commands render before skills in the slash menu, so typing an exact skill
name could leave a fuzzy command highlighted and Enter would pick the wrong
item. After each edit or caret move the picker now highlights the row whose
name ranks best against the query. Arrow-key navigation still owns the
highlight between edits, and a catalog refresh keeps the row the user
arrowed to (by id) instead of jumping.

Co-authored-by: Neil <neil@stably.ai>
2026-11-09 18:59:14 -08:00
Neil e6308fb35c refactor(skills): group catalog, installation, sharing and freshness owners (#40581)
* refactor(skills): group catalog, installation, sharing and freshness owners

* fix(skills): retarget inventory benchmark to catalog owner
2026-11-09 18:53:22 -08:00
Jinjing 9646b48fb8 chore(i18n): guard startup and worktree localization (#40449) 2026-11-09 18:49:52 -08:00
Benson LUOandNeil 38fe0766c3 fix(gitlab): never resolve github.com or bitbucket.org remotes as GitLab projects (#40410)
A stray github.com or bitbucket.org entry in glab's config made the failed
`glab auth status --hostname <host>` probe print a status block headed by a
bare hostname, which the configured-host parser accepted as evidence. The
known-host inventory could likewise list github.com. Because GitLab has
precedence among forge providers, GitHub and Bitbucket repos were offered
GitLab merge requests and GitLab login prompts.

Before trusting any glab evidence, resolveProjectRefForRemote now returns null
when the remote's real host (aliases folded via normalizeForgeWebHost) is
github.com or bitbucket.org. Scp remotes on an SSH alias named e.g. `github`
are unaffected.

Fixes #40386

Co-authored-by: Neil <4138956+nwparker@users.noreply.github.com>
2026-11-09 18:48:58 -08:00
Kelvin Amoaba 9d0110a95d fix(mobile): show the bytes that cross the wire on the download screen (#40594)
Download progress counted inflated asset bytes, so the caption read
"x of 12.9 MB" while about 4.3 MB of brotli copies travelled. Progress now
counts what the reader moves: each brotli copy where one is read, raw bytes
otherwise, and nothing for reused assets. The first total before any
progress uses the same rule.
2026-11-10 02:43:44 +00:00
Wooseong KimandNeil be108a4981 fix(plugins): emit workspace.changed when focus moves between identical workspaces (#40505)
The watcher deduped on the public payload (branch, displayName, terminals),
so moving focus between two workspaces that project to the same payload was
dropped. Dedupe on the focused worktree id as well; the emitted payload still
omits that id because it can embed a provider path.

Fixes #40502

Co-authored-by: Neil <neil@stably.ai>
2026-11-09 18:43:32 -08:00
c2908a07b1 Keep chat navigation focused on human messages (#33403)
* fix(chat): collapse orchestration notices and keep the rail human-only

* test(chat): assert human-only rail previews

* test(mobile): inspect compact orchestration mail through its disclosure

* test(mobile): keep orchestration coverage in a focused suite

* test: retain the agent source type used by message cases

* fix(chat): keep rail reply previews while ticks skip agent-written inputs

Restores the hover card's reply line (the issue asks to keep the existing
preview), drops the shared test fixture and folds the authorship cases
into the rail and outline tests.

* fix(chat): stop rereading an older host's outline as the history window moves

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Kelvin Amoaba <97001695+AmoabaKelvin@users.noreply.github.com>
2026-11-10 02:34:03 +00:00
SimonandNeil 793cfe5458 fix(artifacts): wrap the share popover's Update button label in long locales (#40297)
The "Update shared content" button inherited Button's whitespace-nowrap and
fixed h-8, so long translations (e.g. Russian) ran past the button edge in
the w-80 share popover. Let the label wrap, and stack the idle and
"Updating…" labels in one grid cell so the button keeps its height while
publishing instead of resizing the popover mid-update.

Fixes #40202

Co-authored-by: Neil <neil@stably.ai>
2026-11-09 18:33:00 -08:00
Wooseong Kim e39763be4b fix(native-chat): scale chat tables with the text size setting (#40396)
Chat message tables inherited the shared document renderer's fixed
text-[13px], so they ignored the chat Text size setting. Add a chat-only
0.9285714286em (13/14) override so tables stay 13px at the default 14px
size and scale with the message like the heading overrides do.

Fixes #40389
2026-11-09 18:32:50 -08:00
Kelvin Amoaba 75d7ecd3ac feat(dictation): choose how long silence lasts before dictation stops (#40530) 2026-11-10 02:25:34 +00:00
OrcaWinandOrcaWin 3d28b6fbf8 test: remove low-value Codex lifecycle and compiler examples (#40588)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-09 18:25:15 -08:00
Kelvin Amoaba c822ccc6b3 feat(mobile): show working agents on Feed in an Active section (#40587)
Feed only listed agents waiting on you, so a phone with agents busy on the
desktop showed none of them. The section now lists agents that need you
first, then working ones, still capped at three with a link to the Agents
tab.
2026-11-10 02:23:50 +00:00
Brennan Benson 80937f7eed Show a Fast-only speed as the Fast mode switch on mobile (#40523)
On the phone, Codex's Standard/Fast speed was a Speed row opening a
list while Claude's Fast mode was a switch. A Fast-only speed now uses
the same switch row; more speeds, or a lone Flex, keep the list. The
lone-Fast rule moves to shared code so desktop and mobile follow one
rule.
2026-11-09 18:11:52 -08:00
Brennan Benson 0d5d870800 test: isolate every vitest file on Windows to stop native heap-corruption crashes (#40200)
Shared workers (#40067) keep native addons such as the Windows process tree
and ConPTY loaded across files. Windows workers then exit with 0xC0000374
(STATUS_HEAP_CORRUPTION) in the node-server persistence lane. Production code
loads these addons lazily, so the per-file scan cannot detect them.
2026-11-09 18:11:01 -08:00
Jinwoo Hong 4a2726b3f6 fix(renderer): keep the right sidebar toggle during workspace creation; read the latest review provider in Source Control (#40478)
* fix(right-sidebar): keep the toggle while a workspace is being created

The creation surface has no titlebar strip and the floating toggle only rendered
with workspace chrome, so closing the right sidebar during creation (or on a
failed creation, which stays up until dismissed) left no button to reopen it.
The toggle button, its shortcut and the menu item now share one rule,
canToggleRightSidebar, so the shortcut also works during creation.

* fix(source-control): read the latest review provider when eligibility fails

The failure fallback read the provider through useEffectEvent, which keeps the
first render's handler inside memo components in React 19.2. A provider that
settled after the probe started was ignored. Read it from a ref refreshed in a
layout effect instead.
2026-11-09 21:08:21 -05:00
Jinjing be7d53e0c7 test(ssh): reset user disconnect state in connection fixtures (#40525) 2026-11-09 18:08:17 -08:00
Kelvin Amoaba c8569725a9 revert(tab-group): restore the split pane landing list (#40580)
Reverts c66199ab94 (#40469). The outline buttons didn't work out; the landing goes back to the plain list from #40113.
2026-11-10 02:07:24 +00:00
Kelvin Amoaba aa9c9a6e76 feat(settings): test the microphone in Voice settings and see what the model heard (#40493) 2026-11-10 02:04:07 +00:00
OrcaWinandOrcaWin e295b0d37c test: remove low-value settings and environment cases (#40578)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-09 17:58:42 -08:00
Brennan Benson 7777f352d8 build: fail the React Compiler ratchet on stale uncompiled-list paths (#40198)
* build: fail the React Compiler ratchet on stale uncompiled-list paths

- A listed path that no longer names a renderer source (a rename or split) fails the ratchet, so the file can't silently start compiling.
- The build and the ratchet read the lists through one parser that drops trailing notes, resolved from the repo root rather than the current directory.

* build: resolve uncompiled lists from import.meta.url and check listed paths on disk

- electron-vite's config bundle rewrites import.meta.url per file but not import.meta.dirname, so the repo root came out wrong and desktop builds failed with ENOENT.
- A listed path is stale only if no renderer file exists there; the scan's test-name filter no longer flags shipped files like notification-test-delivery.ts.

* build: require uncompiled-list entries to name the exact file the build matches

A ../ segment, a directory or a different letter case passed the existence check, but the build's exclusion matches only the exact path, so the file still compiled.

* build: reject backslashes in uncompiled-list entries

On Windows path.join turns a backslash into a separator, so the entry passed the check while the build's forward-slash match missed it.
2026-11-09 17:53:19 -08:00
Brennan BensonandNeil cae1dd44f2 perf: avoid unused workspace reference work on store updates (#40554)
* perf: defer unused workspace reference cache projection

* perf: select workspace reference cache identities directly

Resolve cache readers once per attachment request so store notifications only read raw entry identities. Keep rendering and fresh reads on the existing projection and routing paths.

Co-authored-by: Neil <neil@stably.ai>

* perf: isolate cached reference readers from store snapshots

Create memoized identity readers in a scope containing only cache name and key so they cannot retain a previous whole-store snapshot through sibling read closures.

Co-authored-by: Neil <neil@stably.ai>

* fix: preserve reference cache reader indexed types

Keep the state parameter generic so indexing a chosen cache retains the matching entry type. Runtime reader behavior is unchanged.

* fix: retain cache key correlation in the reader type

The second index loses the cache-key correlation across the record union. Assert the identical indexed return type with the structural proof documented; emitted reader code is unchanged.

---------

Co-authored-by: Neil <neil@stably.ai>
2026-11-09 17:52:04 -08:00
Neil 2104da430c refactor(native-chat): group restart recovery and notice owners (#40570) 2026-11-09 17:50:58 -08:00
Neil 48f9eb037d chore(deps): bump tsrs to 0.22.0-ts7.1.0-beta (#40572)
0.23.0 is inside the 3-day minimumReleaseAge window, so 0.22.0 is the
newest version installable without an exclusion.
2026-11-09 17:43:03 -08:00
Brennan Bensonandhiba malik 73f11a54f1 Quiet linked task and review counts on workspace cards (#40482)
Co-authored-by: hiba malik <hibamalik8799@gmail.com>
2026-11-09 17:36:23 -08:00
Brennan Benson 1e967661a8 Fix false Codex worker readiness after startup (#40246)
* Keep Codex session startup separate from prompt submission

* Use normalized hook timestamps in CLI regression fixture

* Preserve root evidence across cached starts and relay child hooks

* Check cached starts cannot refresh expired root evidence

* Preserve Codex child ownership through cached session starts

* Keep session startup context within its terminal and session

* Narrow the eligible Codex context directly for typechecking

* Keep Codex turn facts scoped to their root session
2026-11-09 17:35:42 -08:00
Brennan Benson 4d1c130e17 fix(source-control): stop the Change Base Ref dialog from clipping the search field's focus ring (#40521)
The dialog body is an overflow-y-auto scroll area with no padding, so the
focused search field's 3px ring was cut off at its edges. Give it 4px of
room with -m-1 p-1, as the Workspace Details dialog already does.

Tracked in #39381
2026-11-09 17:35:37 -08:00
OrcaWinandOrcaWin 894dbbd0ec test: remove low-value mobile generation and cache cases (#40571)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-09 17:30:34 -08:00
OrcaWinandOrcaWin 5ff661378b test: remove low-value markdown, agent, and pricing cases (#40566)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-09 17:20:55 -08:00
Brennan Benson 8573f7ce86 Create a worktree per repository from an empty folder workspace on the phone (#40139)
* feat(mobile): create a worktree per repository from an empty folder workspace

A folder workspace with no attached worktrees lists one card per
repository in its project group, as desktop's empty state does. Tapping
one creates a worktree named after the folder, attached to it, in place;
a taken name or a setup choice opens the new-workspace composer with the
repo, the name and the folder parent filled in. Shown only when the host
creating it supports exact-name creation.

* chore(mobile): merge the folder repo read's execution-host imports

* fix(mobile): folder creates keep their repository until the folder shows them

Every create from a folder's empty state, direct or through the
composer, holds its repository from admission until the folder lists
the new worktree, so a lost reply, a remount or a reopened form can't
start a second one. The composer and toasts belong to the folder
screen, stay on the folder's host, and say nothing once it's left. A
relayed server's repository read holds no desktop event stream, and a
failed read can be retried.

* test(mobile): a folder create resent after a lost reply carries the same mutation id

* fix(mobile): folder creates keep their name, and a left or replaced form shows and holds nothing

* fix(mobile): pause folder rows under the create form; a lost folder create is checked, never resent as another

* fix(mobile): a folder card never resends a form's create, and one form owns the folder screen at a time

* fix(mobile): a folder setup choice resends only its own unconfirmed create, and the newest form silences older ones

* test(mobile): declare the submit hook's folder launch in its recording fixture

* fix(mobile): a create refused on a resend after a lost reply tries no other name and stays unconfirmed

* fix(mobile): a replayed refusal after an agent-launch fallback stops the retry, and the composer says it may have been created

* test(mobile): type the replayed refusal reply in the retry test

* ci: retrigger checks

* fix(mobile): localize the folder and uncertain-create messages in the workspace composer
2026-11-09 17:18:33 -08:00
Jinwoo Hong 0bebd121b6 fix(orchestration): worker worktrees follow the project's setup setting (#40547)
worker-start defaulted --setup to run, so new worker worktrees ran the
setup script even when the project had setup turned off. Without an
explicit --setup, a worker now skips setup when the project skips it by
default; run-by-default and ask keep running it as before. Remote
workers resolve this on the host that owns the project.
2026-11-09 20:16:22 -05:00
Jinwoo Hong 82c9ba9534 fix(claude): keep a model picked mid-turn over that turn's later replies (#40546)
Picking a model while a turn runs cleared the reported model, but the
running turn's next reply, still from the old model, restored it. The
composer pill prefers the reported model, so it named the old model
while the menu checked the new one. Replies from the turn that was
running at the pick no longer report a model; the next turn's replies
and init do.
2026-11-09 20:16:12 -05:00
Neil 31eff247fa refactor(renderer): organize work-item and review defining owners (#40562) 2026-11-09 17:08:01 -08:00
OrcaWinandOrcaWin 08c0ffdec0 test: remove low-value snapshot and recovery cases (#40563)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-09 17:03:06 -08:00
Brennan Benson e96ee25c73 fix(ui): drop modal blur when the overlay starts closing (#40552)
The workspace blur was keyed on the overlay node existing, so it held through
Radix's exit fade and snapped off after the dim was already gone.
2026-11-09 16:54:11 -08:00
Jinjing d9e2f485f3 fix(agent-picker): preserve model discovery across queued waits (#40545)
* Keep saved agent models searchable while catalogs refresh

- Load saved catalogs independently of pending refreshes.
- Preserve edited presets until a completed catalog confirms removal.

* wip

* wip

* Preserve model discovery status when a read times out

Keep catalog responses provisional while discovery continues, seed account
catalogs when late results arrive, and retire queued discovery on shutdown.

* Simplify model catalog deadlines and picker state
2026-11-09 16:40:51 -08:00
buf0-bot[bot] 959923e493 Update README downloads badge (#40561)
Co-authored-by: buf0-bot[bot] <252831055+buf0-bot[bot]@users.noreply.github.com>
2026-11-10 00:38:17 +00:00
Neil b39a64d347 refactor(renderer): group clipboard and text input owners (#40337) 2026-11-09 16:36:18 -08:00
OrcaWinandOrcaWin c14ee64495 test: remove low-value IPC and SSH recovery cases (#40559)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-09 16:35:29 -08:00
0654f0d6d3 perf(activity): reuse tab indexes across agent status updates (#40536)
* perf(activity): reuse tab indexes across status updates

* perf(activity): label tab-index cache temporary

Co-authored-by: Neil <neil@stably.ai>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* perf(activity): drop temporary label on tab-index cache

Co-authored-by: Neil <neil@stably.ai>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Neil <neil@stably.ai>
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-11-09 16:30:02 -08:00