Files
orca/src/shared/remote-runtime-shared-control-boundary.test.ts
NeilandOrca 46646d7ff1 chore(lint): upgrade oxlint to 1.71 + enable 7 new rules (autofixed backlog) (#6841)
* chore(lint): upgrade oxlint to 1.71 and enable 7 new rules

Upgrade oxlint 1.67.0 -> 1.71.0 (1.72 was blocked by the repo's 3-day
minimum-release-age supply-chain guard; nothing here needs it). The
bump is a no-op on the existing config.

Enable 3 error rules (backlog autofixed to zero in this commit) and
4 warn rules (surface signal without gating CI):

error (autofixed, behavior-preserving):
- unicorn/prefer-node-protocol        (~1531 sites: bare builtin -> node:)
- typescript/no-import-type-side-effects (~36: all-inline-type -> import type)
- unicorn/no-array-reverse            (19: copy-then-reverse -> toReversed)

warn (real signal, current fires are test-only/correct):
- unicorn/no-array-fill-with-reference-type  (aliasing footgun guard)
- typescript/no-unsafe-function-type         (bans bare Function type)
- unicorn/prefer-array-flat-map              (map().flat() -> flatMap())
- unicorn/prefer-regexp-test                 (.match() in bool ctx -> .test())

mobile/.oxlintrc.json extends root, so it inherits all 7; the autofix
ran from root and covered mobile/ too.

Verification (all green): oxlint 0 errors (root+mobile+aux configs),
oxfmt clean, typecheck (node+cli+web), vitest 22795 passed / 0 failed,
builds (electron-vite + web + cli) succeed. node: rewrites confirmed to
skip embedded SSH/CLI string payloads (AST-only); all toReversed sites
verified to operate on fresh copies or write-once locals.

* chore(lint): bump mobile oxlint to 1.71 so inherited rules parse

mobile/ is a standalone pnpm project pinning its own oxlint@1.67, which
lacks unicorn/no-array-fill-with-reference-type (needs >=1.70). Since
mobile/.oxlintrc.json extends the root config, mobile CI's 'cd mobile &&
oxlint' failed to parse the new rule. Bump mobile to match root (1.71).

Verified in mobile/: oxlint 0 errors, oxfmt --check clean, tsc --noEmit
pass, vitest 978 passed / 0 failed.

Co-authored-by: Orca <help@stably.ai>

---------

Co-authored-by: Orca <help@stably.ai>
2026-06-29 22:38:29 -07:00

84 lines
2.4 KiB
TypeScript

import { readdirSync, readFileSync, statSync } from 'node:fs'
import { join } from 'node:path'
import ts from 'typescript'
import { describe, expect, it } from 'vitest'
const FORBIDDEN_REMOTE_SERVER_IMPORTS = [
'remote-runtime-shared-control',
'runtime-environment-request-connections'
]
describe('remote runtime shared-control transport boundary', () => {
it.each(['src/main/ssh', 'src/relay'])(
'does not couple %s to remote-server shared-control transport',
(root) => {
const offenders = collectTypeScriptFiles(root).filter((file) => {
const source = readFileSync(file, 'utf8')
return collectModuleSpecifiers(file, source).some((specifier) =>
FORBIDDEN_REMOTE_SERVER_IMPORTS.some((pattern) => specifier.includes(pattern))
)
})
expect(offenders).toEqual([])
}
)
})
function collectTypeScriptFiles(root: string): string[] {
const entries = readdirSync(root)
const files: string[] = []
for (const entry of entries) {
const path = join(root, entry)
const stat = statSync(path)
if (stat.isDirectory()) {
files.push(...collectTypeScriptFiles(path))
continue
}
if (path.endsWith('.ts') || path.endsWith('.tsx')) {
files.push(path)
}
}
return files
}
function collectModuleSpecifiers(fileName: string, source: string): string[] {
const file = ts.createSourceFile(fileName, source, ts.ScriptTarget.Latest, true)
const specifiers: string[] = []
const visit = (node: ts.Node): void => {
if (
(ts.isImportDeclaration(node) || ts.isExportDeclaration(node)) &&
node.moduleSpecifier &&
ts.isStringLiteral(node.moduleSpecifier)
) {
specifiers.push(node.moduleSpecifier.text)
}
if (
ts.isImportTypeNode(node) &&
ts.isLiteralTypeNode(node.argument) &&
ts.isStringLiteral(node.argument.literal)
) {
specifiers.push(node.argument.literal.text)
}
if (
ts.isCallExpression(node) &&
isModuleLoader(node.expression) &&
node.arguments.length === 1 &&
ts.isStringLiteral(node.arguments[0])
) {
specifiers.push(node.arguments[0].text)
}
ts.forEachChild(node, visit)
}
visit(file)
return specifiers
}
function isModuleLoader(expression: ts.Expression): boolean {
return (
expression.kind === ts.SyntaxKind.ImportKeyword ||
(ts.isIdentifier(expression) && expression.text === 'require')
)
}