mirror of
https://github.com/stablyai/orca.git
synced 2026-10-23 08:03:39 +00:00
Brennan Benson
0867358f37
The command-finished guard required a shell in SHELL_NAMES, so a user on ksh/dash/tcsh/csh/ash/elvish/xonsh could never settle launched-agent hook authority until the pty itself exited. Those are bare shells for every consumer of the predicate, so widening the set is the correct scope. The settle-generation Map also kept one entry per abnormally-exited SSH pty: that branch preserves launch authority by design (unverifiable, not exited), but the counter is bookkeeping for a check that can no longer land.
44 lines
1.8 KiB
TypeScript
44 lines
1.8 KiB
TypeScript
// Why: shared between the runtime (dispatch guard, tui-idle fallback) and the
|
|
// renderer (agent-ready-wait, new-workspace). A bare shell is the negative
|
|
// signal for "is an agent running" because it garbles injected preambles.
|
|
const SHELL_NAMES = new Set(
|
|
'|bash|zsh|sh|fish|cmd|cmd.exe|powershell|powershell.exe|pwsh|pwsh.exe|nu|ksh|mksh|dash|ash|tcsh|csh|elvish|xonsh'.split(
|
|
'|'
|
|
)
|
|
)
|
|
const WINDOWS_PROCESS_EXTENSION_RE = /\.(?:exe|cmd|bat|ps1)$/i
|
|
|
|
export function isShellProcess(processName: string): boolean {
|
|
const normalized = processName
|
|
.trim()
|
|
.replace(/^["']|["']$/g, '')
|
|
.toLowerCase()
|
|
const basename = normalized.split(/[\\/]/).pop() ?? normalized
|
|
// Why: Windows node-pty reports Git Bash and similar shells as `bash.exe`;
|
|
// those still need the same shell-safe handling as their POSIX basenames.
|
|
const basenameWithoutWindowsExtension = basename.replace(WINDOWS_PROCESS_EXTENSION_RE, '')
|
|
return (
|
|
SHELL_NAMES.has(normalized) ||
|
|
SHELL_NAMES.has(basename) ||
|
|
SHELL_NAMES.has(basenameWithoutWindowsExtension)
|
|
)
|
|
}
|
|
|
|
// Why: a ConPTY-side buffer clear cannot reach PSReadLine's cached cursor
|
|
// row, so the first Enter after a terminal clear still repaints the prompt at
|
|
// the stale row. Only the PowerShell family binds Ctrl+L (form feed) to a
|
|
// full prompt repaint, so the post-clear nudge must stay scoped to it.
|
|
const POWERSHELL_NAMES = new Set(['powershell', 'pwsh'])
|
|
|
|
export function isPowerShellProcess(processName: string | null | undefined): boolean {
|
|
if (!processName) {
|
|
return false
|
|
}
|
|
const normalized = processName
|
|
.trim()
|
|
.replace(/^["']|["']$/g, '')
|
|
.toLowerCase()
|
|
const basename = normalized.split(/[\\/]/).pop() ?? normalized
|
|
return POWERSHELL_NAMES.has(basename.replace(WINDOWS_PROCESS_EXTENSION_RE, ''))
|
|
}
|