mirror of
https://github.com/stablyai/orca.git
synced 2026-09-28 16:02:45 +00:00
Merge Sim
bf5e16a6f9
Adversarial review found the startup gate's only test was non-discriminating (its anchor matched twice, so deleting the real conjunct left it green) and the entire renderer half untested — removing the one line that implements the feature left the repo green. Guard the installer itself: installManagedAgentHooks now returns hooks_disabled skips when the preference is off, so an unchecked box cannot install from any caller or any later launch. No mirror guard that removes: on a fresh profile nothing of ours is installed, and removeManagedAgentHooks deletes user-global entries another Orca profile may own (STA-5679). Declined means call nothing. Make step-1 consent transactional. The checkbox write was fire-and-forget and the renderer store swallows failures, so a failed write plus an advancing wizard installed using the default-on value — for a user who had unchecked. Consent now rides along with onboarding:update and main persists it before advancing. Also: the cohort signal counted only the primary state file while the loader's own recovery path counts backups, so a user whose primary was gone but backups survived was classified fresh; pass shouldContinue and isQuitting to the onboarding install; drop userInitiated, which would have overridden Grok's opt-out for every fresh profile relative to the path it replaces; correct the codex disclosure, which claimed Orca does not touch ~/.codex.