mirror of
https://github.com/stablyai/orca.git
synced 2026-11-02 10:08:13 +00:00
NeilandKatsuma Takehisa
ce07786266
Keeps a fork issue’s details, metadata and edits bound to the repository the user opened, including same-number issues in fork and upstream. Repairs selected-assignee leakage and delayed failed edits repainting another issue. Fixes #24378 Incorporates and cross-reviews contributor PR #24379, including its source-resolver correction and regression material. Covers the contributor PR’s Project-row identity and retained-dialog mutation findings. The final published head passes focused tests, hidden macOS rendering and current CI; the callback-timing bot thread has an evidence-based response. Co-authored-by: Katsuma Takehisa <k.takehisa@nissogr.com>
47 lines
2.1 KiB
TypeScript
47 lines
2.1 KiB
TypeScript
// Why: owner/repo overrides become authenticated REST paths, so the slug gate
|
|
// must keep rejecting path-shaped input while accepting every real login shape —
|
|
// including Enterprise Managed User logins, which end in `_<shortcode>`.
|
|
import { describe, expect, it } from 'vitest'
|
|
import { isValidGitHubApiRepository } from './github-api-repository-validation'
|
|
|
|
describe('isValidGitHubApiRepository', () => {
|
|
it('accepts plain and Enterprise Managed User owners', () => {
|
|
expect(isValidGitHubApiRepository({ owner: 'acme', repo: 'orca' })).toBe(true)
|
|
expect(isValidGitHubApiRepository({ owner: 'octocat_acme', repo: 'level5' })).toBe(true)
|
|
})
|
|
|
|
it('rejects leading underscore, hyphen, dot, and path-shaped owners', () => {
|
|
expect(isValidGitHubApiRepository({ owner: '_acme', repo: 'orca' })).toBe(false)
|
|
expect(isValidGitHubApiRepository({ owner: '-acme', repo: 'orca' })).toBe(false)
|
|
expect(isValidGitHubApiRepository({ owner: '.acme', repo: 'orca' })).toBe(false)
|
|
expect(isValidGitHubApiRepository({ owner: 'a/b', repo: 'orca' })).toBe(false)
|
|
})
|
|
|
|
it('rejects reserved and path-shaped repos', () => {
|
|
expect(isValidGitHubApiRepository({ owner: 'acme', repo: '.' })).toBe(false)
|
|
expect(isValidGitHubApiRepository({ owner: 'acme', repo: '..' })).toBe(false)
|
|
expect(isValidGitHubApiRepository({ owner: 'acme', repo: 'a/b' })).toBe(false)
|
|
})
|
|
|
|
it.each([42, false, null, {}])('rejects a non-string repository host: %j', (host) => {
|
|
expect(isValidGitHubApiRepository({ owner: 'acme', repo: 'orca', host })).toBe(false)
|
|
})
|
|
|
|
it.each([undefined, 'github.com', 'github.enterprise.test:8443'])(
|
|
'accepts supported legacy or explicit repository host types: %j',
|
|
(host) => {
|
|
expect(isValidGitHubApiRepository({ owner: 'acme', repo: 'orca', host })).toBe(true)
|
|
}
|
|
)
|
|
|
|
it.each([
|
|
null,
|
|
'acme/orca',
|
|
{ owner: 42, repo: 'orca' },
|
|
{ owner: 'acme', repo: 42 },
|
|
{ owner: 'acme' }
|
|
])('rejects malformed runtime repository identities: %j', (repository) => {
|
|
expect(isValidGitHubApiRepository(repository)).toBe(false)
|
|
})
|
|
})
|