Files
orca/tests/e2e/cross-version-wire/versioned-terminal-wire.ts
T
Neil 11cd2b4310 revert(ssh): back out #13326 and #13928 — reconnect loses every tab (#14361)
* Revert "fix(daemon): stop killing live coding agents when the daemon can't report its sessions (#13928)"

This reverts commit 2e8cf589de.

Reverted together with #13326: the 1.4.182-daily.202608131439 build carrying
both loses every tab on an SSH disconnect/reconnect cycle. Reverting first so
main stays releasable and the P0 fixes in the wild remain cherry-pickable,
rather than fixing forward on a shipped regression.

* Revert "fix(ssh): stop SSH reconnect from multiplying terminals and resuming agents twice (STA-3077)" (#13326)

This reverts commit 3ab8b6a117.

Reported on 1.4.182-daily.202608131439: connect to an SSH worktree, disconnect
the host from the hosts popup, reconnect — every tab is gone. That is worse than
the behaviour this PR set out to fix, where most tabs were retained.

Reverting rather than fixing forward, so main stays releasable and the P0 fixes
already out in the wild stay cherry-pickable. STA-3077 stays open.
2026-08-13 14:54:29 -07:00

152 lines
5.2 KiB
TypeScript

import { materializeReleaseCheckout, type ReleaseCheckout } from './release-checkout'
/**
* Structural views of the three modules that make up the remote terminal wire.
* Kept minimal on purpose: the harness pairs two builds of these modules, so it
* must not depend on internals that legitimately differ between versions.
*/
export type TerminalStreamFrame = {
opcode: number
streamId: number
seq: number
payload: Uint8Array
}
export type WireCodec = {
TerminalStreamOpcode: Record<string, number | string>
encodeTerminalStreamFrame: (frame: TerminalStreamFrame) => Uint8Array
decodeTerminalStreamFrame: (bytes: Uint8Array) => TerminalStreamFrame | null
encodeTerminalStreamJson: (value: unknown) => Uint8Array
decodeTerminalStreamJson: <T>(payload: Uint8Array) => T | null
encodeTerminalStreamText: (value: string) => Uint8Array
decodeTerminalStreamText: (payload: Uint8Array) => string
}
export type HostRpcContext = {
connectionId: string
sendBinary: (bytes: Uint8Array) => boolean | void
registerBinaryStreamHandler: (
streamId: number,
handler: (frame: TerminalStreamFrame) => void
) => () => void
signal?: AbortSignal
}
export type HostWire = {
RpcDispatcher: new (options: { runtime: unknown; methods: unknown[] }) => {
dispatchStreaming: (
request: { id: string; authToken: string; method: string; params?: unknown },
onMessage: (message: string) => void,
context: HostRpcContext
) => Promise<unknown>
}
TERMINAL_METHODS: unknown[]
}
export type ClientTerminalCallbacks = {
onData: (data: string, meta?: { seq?: number; rawLength?: number }) => void
onSnapshot: (data: string, meta?: { pendingEscapeTailAnsi?: string }) => void
onSubscribed?: () => void
onOutputPauseCapability?: () => void
onEnd?: () => void
onError?: (message: string) => void
onTransportClose?: (event: { recoverable: boolean; retryWithBackoff?: boolean }) => void
}
export type ClientTerminal = {
streamId: number
sendInput: (text: string) => boolean
resize: (cols: number, rows: number) => boolean
setOutputPaused: (paused: boolean) => boolean
serializeBuffer: (opts?: { scrollbackRows?: number }) => Promise<{
data: string
cols: number
rows: number
seq?: number
source?: string
} | null>
close: () => void
}
export type ClientWire = {
getRemoteRuntimeTerminalMultiplexer: (runtimeId: string) => {
subscribeTerminal: (args: {
terminal: string
client: { id: string; type: 'desktop' | 'mobile' }
viewport?: { cols: number; rows: number }
callbacks: ClientTerminalCallbacks
}) => Promise<ClientTerminal>
}
resetRemoteRuntimeTerminalMultiplexersForTests: () => void
}
export type TerminalWireBuild = {
/** Human label used in test names and failure messages. */
label: string
/** `working-tree` for current code, otherwise the resolved release commit. */
revision: string
codec: WireCodec
host: HostWire
client: ClientWire
}
export const WORKING_TREE = 'working-tree' as const
async function loadWorkingTreeBuild(): Promise<TerminalWireBuild> {
const [codec, dispatcher, terminalMethods, client] = await Promise.all([
import('../../../src/shared/terminal-stream-protocol'),
import('../../../src/main/runtime/rpc/dispatcher'),
import('../../../src/main/runtime/rpc/methods/terminal'),
import('../../../src/renderer/src/runtime/remote-runtime-terminal-multiplexer')
])
return {
label: WORKING_TREE,
revision: WORKING_TREE,
codec: codec as unknown as WireCodec,
host: {
RpcDispatcher: dispatcher.RpcDispatcher as unknown as HostWire['RpcDispatcher'],
TERMINAL_METHODS: terminalMethods.TERMINAL_METHODS as unknown[]
},
client: client as unknown as ClientWire
}
}
// Why @vite-ignore: the checkout is created at run time, so Vite cannot glob it at
// transform time. Vite-node still resolves and transforms the target on demand.
function importFromCheckout(specifier: string): Promise<Record<string, unknown>> {
return import(/* @vite-ignore */ specifier) as Promise<Record<string, unknown>>
}
async function loadReleaseBuild(checkout: ReleaseCheckout): Promise<TerminalWireBuild> {
const base = `${checkout.root}/src`
const [codec, dispatcher, terminalMethods, client] = await Promise.all([
importFromCheckout(`${base}/shared/terminal-stream-protocol.ts`),
importFromCheckout(`${base}/main/runtime/rpc/dispatcher.ts`),
importFromCheckout(`${base}/main/runtime/rpc/methods/terminal.ts`),
importFromCheckout(`${base}/renderer/src/runtime/remote-runtime-terminal-multiplexer.ts`)
])
return {
label: checkout.ref,
revision: checkout.commit,
codec: codec as WireCodec,
host: {
RpcDispatcher: dispatcher.RpcDispatcher as HostWire['RpcDispatcher'],
TERMINAL_METHODS: terminalMethods.TERMINAL_METHODS as unknown[]
},
client: client as ClientWire
}
}
/**
* Load the wire modules for one build. `WORKING_TREE` imports current source (so a
* locally injected violation is exercised); any other value is a git ref extracted
* into a cached checkout.
*/
export async function loadTerminalWireBuild(ref: string): Promise<TerminalWireBuild> {
if (ref === WORKING_TREE) {
return loadWorkingTreeBuild()
}
return loadReleaseBuild(materializeReleaseCheckout(ref))
}