Files
orca/tests/e2e/settings-search-responsiveness.spec.ts
T
NeilandOrca 46646d7ff1 chore(lint): upgrade oxlint to 1.71 + enable 7 new rules (autofixed backlog) (#6841)
* chore(lint): upgrade oxlint to 1.71 and enable 7 new rules

Upgrade oxlint 1.67.0 -> 1.71.0 (1.72 was blocked by the repo's 3-day
minimum-release-age supply-chain guard; nothing here needs it). The
bump is a no-op on the existing config.

Enable 3 error rules (backlog autofixed to zero in this commit) and
4 warn rules (surface signal without gating CI):

error (autofixed, behavior-preserving):
- unicorn/prefer-node-protocol        (~1531 sites: bare builtin -> node:)
- typescript/no-import-type-side-effects (~36: all-inline-type -> import type)
- unicorn/no-array-reverse            (19: copy-then-reverse -> toReversed)

warn (real signal, current fires are test-only/correct):
- unicorn/no-array-fill-with-reference-type  (aliasing footgun guard)
- typescript/no-unsafe-function-type         (bans bare Function type)
- unicorn/prefer-array-flat-map              (map().flat() -> flatMap())
- unicorn/prefer-regexp-test                 (.match() in bool ctx -> .test())

mobile/.oxlintrc.json extends root, so it inherits all 7; the autofix
ran from root and covered mobile/ too.

Verification (all green): oxlint 0 errors (root+mobile+aux configs),
oxfmt clean, typecheck (node+cli+web), vitest 22795 passed / 0 failed,
builds (electron-vite + web + cli) succeed. node: rewrites confirmed to
skip embedded SSH/CLI string payloads (AST-only); all toReversed sites
verified to operate on fresh copies or write-once locals.

* chore(lint): bump mobile oxlint to 1.71 so inherited rules parse

mobile/ is a standalone pnpm project pinning its own oxlint@1.67, which
lacks unicorn/no-array-fill-with-reference-type (needs >=1.70). Since
mobile/.oxlintrc.json extends the root config, mobile CI's 'cd mobile &&
oxlint' failed to parse the new rule. Bump mobile to match root (1.71).

Verified in mobile/: oxlint 0 errors, oxfmt --check clean, tsc --noEmit
pass, vitest 978 passed / 0 failed.

Co-authored-by: Orca <help@stably.ai>

---------

Co-authored-by: Orca <help@stably.ai>
2026-06-29 22:38:29 -07:00

73 lines
2.5 KiB
TypeScript

import path from 'node:path'
import { test, expect } from './helpers/orca-app'
import { waitForSessionReady } from './helpers/store'
import type { Repo } from '../../src/shared/types'
const MATCHING_PROJECT_COUNT = 240
function buildProjectPaths(): string[] {
return Array.from({ length: MATCHING_PROJECT_COUNT }, (_, index) =>
path.join(process.cwd(), '.e2e-settings-search', `project-${String(index).padStart(3, '0')}`)
)
}
test.describe('Settings search responsiveness', () => {
test('renders only the active settings pane when many projects match search', async ({
orcaPage
}) => {
await waitForSessionReady(orcaPage)
await orcaPage.evaluate(
({ projectPaths, projectCount }) => {
const store = window.__store
if (!store) {
throw new Error('window.__store is not available')
}
const state = store.getState()
const seedRepo = state.repos[0]
if (!seedRepo) {
throw new Error('Expected seeded repo for settings search regression')
}
const now = Date.now()
const repos: Repo[] = Array.from({ length: projectCount }, (_, index) => ({
...seedRepo,
id: `settings-search-repo-${index}`,
path: projectPaths[index],
displayName: `Project Long Search ${String(index).padStart(3, '0')}`,
addedAt: now + index,
upstream: null,
hookSettings: undefined
}))
store.setState({ repos })
state.openSettingsPage()
},
{ projectPaths: buildProjectPaths(), projectCount: MATCHING_PROJECT_COUNT }
)
const searchInput = orcaPage.getByPlaceholder('Search settings')
await expect(searchInput).toBeVisible()
await searchInput.fill('Project Long Search')
await expect
.poll(() => orcaPage.evaluate(() => window.__store?.getState().settingsSearchQuery ?? ''), {
timeout: 5_000,
message: 'settings search query did not apply'
})
.toBe('Project Long Search')
await expect(orcaPage.getByRole('button', { name: 'Project Long Search 000' })).toBeVisible()
await expect
.poll(() => orcaPage.locator('section.scroll-mt-8[data-settings-section]').count(), {
timeout: 5_000,
message: 'settings search rendered more than the active pane'
})
.toBe(1)
const renderedSectionId = await orcaPage
.locator('section.scroll-mt-8[data-settings-section]')
.first()
.getAttribute('data-settings-section')
expect(renderedSectionId).toBe('repo-settings-search-repo-0')
})
})