Files
orca/tests/e2e/terminal-windows-codex-multiline-paste.spec.ts
T
OrcaWinandBrennan Benson 62c644a8bc fix(terminal): prevent Windows multiline paste submission (#8688)
* fix(terminal): prevent Windows multiline paste submission

* fix(terminal): normalize chunked forced-paste line endings

Windows multiline pastes over TERMINAL_PASTE_DIRECT_MAX_BYTES (64 KiB)
take the chunked plan and stream plainText straight to the PTY, skipping
wrapTerminalBracketedPasteText — so raw CRLF/LF still reached ConPTY and
Codex treated the LF as submit, the exact bug the direct path just fixed.

Wire the plan's newlinePolicy field: forced bracketed plans get
'terminal-cr' and the chunk iterator normalizes the full text before
chunking (a per-chunk pass could split a CRLF across a boundary and leak
the LF half). Non-forced chunked pastes keep their documented
preserve-newlines behavior, so macOS/Linux bytes are unchanged.

* fix(terminal): normalize programmatic paste newlines

* test(e2e): harden Windows Codex paste spec per review

Poll for the idle composer placeholder as a positive ready signal (the
negative boot-state check alone can pass on an empty screen), and grow
the large-paste payload so it stays above the 64 KiB direct-max after
newline normalization, keeping the chunked lane covered even if
planning ever measures post-normalization bytes.

---------

Co-authored-by: Brennan Benson <79079362+brennanb2025@users.noreply.github.com>
2026-07-14 14:40:40 -07:00

242 lines
9.3 KiB
TypeScript

import { createHash, randomUUID } from 'node:crypto'
import { rmSync, writeFileSync } from 'node:fs'
import path from 'node:path'
import { test, expect } from './helpers/orca-app'
import {
focusActiveTerminalInput,
getTerminalContent,
sendToTerminal,
waitForActivePanePtyId,
waitForActiveTerminalManager,
waitForTerminalOutput
} from './helpers/terminal'
import { ensureTerminalVisible, waitForActiveWorktree, waitForSessionReady } from './helpers/store'
const DRAFT = 'ORCA_CODEX_PASTE_DRAFT_SHOULD_STAY_UNSENT'
const CODEX_TRUST_PROMPT_RE = /Do[\s\S]*you[\s\S]*trust[\s\S]*contents/i
function pastePayload(repeats = 4): string {
const lines = [
'Repository: stablyai/orca',
'',
'Required exact revision:',
'',
'0123456789abcdef0123456789abcdef01234567',
'',
'This is validation only:',
'',
'- Do not modify files.',
'',
'- Do not commit or push.',
'',
'- If the worktree is dirty before starting, stop and report it.',
'',
'- Use native Windows PowerShell, Node 24, and pnpm 10.',
'',
'- Confirm the checked-out full SHA before testing.',
'',
'Run:',
'',
'1. pnpm typecheck',
'',
'2. pnpm lint',
'',
'3. Run the focused Node 24 suite and report every result.',
'',
'4. Run the registered Electron gate exactly as written.',
'',
'If anything fails, include the first useful stack trace and distinguish product failure from test-harness or environmental failure.'
]
return Array.from({ length: repeats }, () => lines.join('\r\n')).join('\r\n\r\n')
}
async function activateTestRepository(
page: Parameters<typeof focusActiveTerminalInput>[0],
repoPath: string
): Promise<void> {
await page.evaluate(async (targetRepoPath) => {
const normalizePath = (value: string): string => value.replaceAll('\\', '/').toLowerCase()
await window.api.repos.add({ path: targetRepoPath })
const store = window.__store
if (!store) {
throw new Error('Orca store unavailable')
}
await store.getState().fetchRepos()
const repo = store
.getState()
.repos.find((candidate) => normalizePath(candidate.path) === normalizePath(targetRepoPath))
if (!repo) {
throw new Error('Seeded repository unavailable')
}
await store.getState().updateRepo(repo.id, { externalWorktreeVisibility: 'show' })
await store.getState().fetchWorktrees(repo.id)
const worktree = store
.getState()
.worktreesByRepo[repo.id]?.find(
(candidate) => normalizePath(candidate.path) === normalizePath(targetRepoPath)
)
if (!worktree) {
throw new Error('Seeded worktree unavailable')
}
store.getState().setActiveWorktree(worktree.id)
store.getState().createTab(worktree.id)
}, repoPath)
}
function pasteCollectorScript(
expectedLength: number,
expectedHash: string,
marker: string
): string {
return `
import { createHash } from 'node:crypto'
process.stdin.setEncoding('utf8')
if (process.stdin.isTTY) process.stdin.setRawMode(true)
process.stdin.resume()
let received = ''
const start = String.fromCharCode(27) + '[200~'
const end = String.fromCharCode(27) + '[201~'
process.stdout.write(${JSON.stringify(`${marker}_READY`)} + '\\n')
process.stdin.on('data', (chunk) => {
received += chunk
const startIndex = received.indexOf(start)
const endIndex = received.indexOf(end, Math.max(0, startIndex + start.length))
if (startIndex === -1 || endIndex === -1) return
const body = received.slice(startIndex + start.length, endIndex)
const hash = createHash('sha256').update(body).digest('hex')
const matches = body.length === ${expectedLength} && hash === ${JSON.stringify(expectedHash)}
process.stdout.write(${JSON.stringify(`${marker}_RESULT:`)} + (matches ? 'MATCH' : 'MISMATCH') + ':' + body.length + ':' + hash + '\\n')
process.exit(matches ? 0 : 1)
})
`
}
async function enableTerminalAccessibilityDom(
page: Parameters<typeof focusActiveTerminalInput>[0],
ptyId: string
): Promise<void> {
await page.evaluate((targetPtyId) => {
const managers = Array.from(window.__paneManagers?.values() ?? [])
const pane = managers
.flatMap((manager) => manager.getPanes?.() ?? [])
.find((candidate) => candidate.container.dataset.ptyId === targetPtyId)
if (!pane) {
throw new Error(`Terminal pane ${targetPtyId} is unavailable`)
}
// Why: xterm paints to canvas by default. Screen-reader mode mirrors the
// visible prompt into DOM rows so the regression assertions stay user-facing.
pane.terminal.options.screenReaderMode = true
pane.terminal.refresh(0, pane.terminal.rows - 1)
}, ptyId)
await expect(
page.locator(`[data-pty-id=${JSON.stringify(ptyId)}] .xterm-accessibility-tree`)
).toBeAttached({ timeout: 10_000 })
}
async function waitForCodexComposerReady(
page: Parameters<typeof focusActiveTerminalInput>[0]
): Promise<void> {
// Why: Codex can render its header before delayed MCP startup takes over the
// composer. Let that startup begin, then paste only after the TUI is idle.
await page.waitForTimeout(5_000)
await expect
.poll(async () => await getTerminalContent(page, 12_000), { timeout: 60_000 })
.not.toMatch(/Booting MCP server|tab to queue message/i)
// Why: absence of boot states alone can pass on an empty screen; the idle
// composer placeholder is the positive ready marker (mirrors the product's
// codex-composer-prompt draft-paste signal).
await expect
.poll(async () => await getTerminalContent(page, 12_000), { timeout: 60_000 })
.toMatch(/Ask Codex/i)
}
test.describe('Windows Codex multiline paste', () => {
test.use({ seedTestRepo: false })
test('multiline Ctrl+V keeps the existing Codex draft unsent @local-real-codex', async ({
orcaPage,
testRepoPath
}) => {
test.skip(process.platform !== 'win32', 'Windows ConPTY coverage is Windows-only')
test.skip(
process.env.ORCA_E2E_REAL_CODEX !== '1',
'Set ORCA_E2E_REAL_CODEX=1 to exercise the locally installed Codex TUI'
)
test.slow()
await waitForSessionReady(orcaPage)
await activateTestRepository(orcaPage, testRepoPath)
await waitForActiveWorktree(orcaPage)
await ensureTerminalVisible(orcaPage)
await waitForActiveTerminalManager(orcaPage, 30_000)
const ptyId = await waitForActivePanePtyId(orcaPage)
await sendToTerminal(orcaPage, ptyId, 'codex -m orca-e2e-invalid-model\r')
await expect
.poll(() => getTerminalContent(orcaPage, 12_000), { timeout: 20_000 })
.toMatch(/Do[\s\S]*you[\s\S]*trust[\s\S]*contents|OpenAI Codex/i)
if (CODEX_TRUST_PROMPT_RE.test(await getTerminalContent(orcaPage, 12_000))) {
await sendToTerminal(orcaPage, ptyId, '\r')
}
await waitForTerminalOutput(orcaPage, 'OpenAI Codex', 20_000, 30_000)
await waitForCodexComposerReady(orcaPage)
await enableTerminalAccessibilityDom(orcaPage, ptyId)
await focusActiveTerminalInput(orcaPage)
await orcaPage.keyboard.type(DRAFT)
const terminalDom = orcaPage.locator(
`[data-pty-id=${JSON.stringify(ptyId)}] .xterm-accessibility-tree`
)
await expect(terminalDom).toContainText(DRAFT, { timeout: 10_000 })
await orcaPage.evaluate((text) => window.api.ui.writeClipboardText(text), pastePayload())
await orcaPage.keyboard.press('Control+V')
await expect(terminalDom).toContainText('[Pasted Content', { timeout: 10_000 })
await expect(terminalDom).toContainText(DRAFT)
await orcaPage.waitForTimeout(2_000)
await expect(terminalDom).not.toContainText('Working')
await expect(terminalDom).not.toContainText('unexpected status 404')
})
test('delivers a normalized large paste through native ConPTY', async ({
orcaPage,
testRepoPath
}) => {
test.skip(process.platform !== 'win32', 'Windows ConPTY coverage is Windows-only')
test.slow()
await waitForSessionReady(orcaPage)
await activateTestRepository(orcaPage, testRepoPath)
await waitForActiveWorktree(orcaPage)
await ensureTerminalVisible(orcaPage)
await waitForActiveTerminalManager(orcaPage, 30_000)
const ptyId = await waitForActivePanePtyId(orcaPage)
const payload = pastePayload(110)
const expectedText = payload.replace(/\r?\n/g, '\r')
// Why: assert on the normalized size so the payload keeps exercising the
// chunked (>64 KiB direct-max) lane even if planning ever measures
// post-normalization bytes.
expect(Buffer.byteLength(expectedText, 'utf8')).toBeGreaterThan(64 * 1024)
const expectedHash = createHash('sha256').update(expectedText).digest('hex')
const marker = `ORCA_LARGE_PASTE_${randomUUID().replaceAll('-', '')}`
const scriptPath = path.join(testRepoPath, `.${marker}.mjs`)
writeFileSync(scriptPath, pasteCollectorScript(expectedText.length, expectedHash, marker))
try {
await sendToTerminal(orcaPage, ptyId, `node ${JSON.stringify(scriptPath)}\r`)
await waitForTerminalOutput(orcaPage, `${marker}_READY`, 10_000, 12_000)
await enableTerminalAccessibilityDom(orcaPage, ptyId)
await focusActiveTerminalInput(orcaPage)
await orcaPage.evaluate((text) => window.api.ui.writeClipboardText(text), payload)
await orcaPage.keyboard.press('Control+V')
const terminalDom = orcaPage.locator(
`[data-pty-id=${JSON.stringify(ptyId)}] .xterm-accessibility-tree`
)
await expect(terminalDom).toContainText(`${marker}_RESULT:MATCH`, { timeout: 30_000 })
} finally {
rmSync(scriptPath, { force: true })
}
})
})