mirror of
https://github.com/stablyai/orca.git
synced 2026-10-01 16:02:03 +00:00
Neil
ec9f35e2ee
A caller's `needs` gate the whole called workflow, so while the plan job lived in unit-tests.yml it could not start until static analysis and typecheck had both finished and passed -- and the shard matrix then waited on it. The two hops were serial when they did not need to be: planning reads the checkout, a git diff against HEAD^1, the import graph and the checked-in timing baseline in config/scripts/ci-shard-timings.json, and consumes nothing that static analysis, typecheck or the native-cache primer produce. Planning moves to its own reusable workflow so pr.yml can run it against code_paths alone, overlapping it with the gate. Measured across 99 runs, the shard matrix is created a median 93s earlier (p25 47s, p90 241s, never later). Planning stays a required predecessor of the shards, so an empty assignment cannot expand the matrix. The gate itself is deliberately left in place. It fires on 22% of runs, and the shard queue wait knees hard above ~9 concurrent ARM jobs -- 4s median below that against 218s at 15-19 -- so admitting 8 doomed shards per failed run would cost more in queue pressure than it returns in latency. Cost is one 37s ubuntu-latest job, which does not touch the ARM pool the shards contend for. A planning failure still fails the PR: the shards are skipped, and verify's check_job requires success whenever the classifier says tests should run, so it reports `test: expected success, got skipped`.
145 lines
4.6 KiB
YAML
145 lines
4.6 KiB
YAML
name: Unit tests
|
|
|
|
on:
|
|
workflow_call:
|
|
inputs:
|
|
node_versions:
|
|
description: JSON array of Node.js major versions to test.
|
|
required: true
|
|
type: string
|
|
|
|
runner:
|
|
description: Hosted runner for the unit shards; relay integration keeps its x86 host.
|
|
required: false
|
|
default: ubuntu-latest
|
|
type: string
|
|
|
|
shards:
|
|
description: JSON array of shard assignments, produced by unit-plan.yml.
|
|
required: true
|
|
type: string
|
|
|
|
permissions:
|
|
contents: read
|
|
|
|
jobs:
|
|
test:
|
|
name: tests node ${{ matrix.node }} ${{ matrix.shard.index }}/${{ matrix.shard.count }}
|
|
runs-on: ${{ inputs.runner }}
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
node: ${{ fromJSON(inputs.node_versions) }}
|
|
shard: ${{ fromJSON(inputs.shards) }}
|
|
|
|
steps:
|
|
- name: Checkout
|
|
uses: actions/checkout@v6
|
|
with:
|
|
persist-credentials: false
|
|
|
|
- uses: ./.github/actions/install-node-dependencies
|
|
with:
|
|
native-runtime: node
|
|
node-version: ${{ matrix.node }}
|
|
cache-electron-package: 'true'
|
|
|
|
- name: Install Electron package binary for tests
|
|
run: node config/scripts/install-electron-package-binary.mjs
|
|
|
|
- uses: actions/download-artifact@v8
|
|
continue-on-error: true
|
|
with:
|
|
name: unit-selection-attempt-${{ github.run_attempt }}
|
|
path: ci-shards/
|
|
|
|
- name: Test shard
|
|
env:
|
|
ORCA_BALANCE_UNIT_SHARDS: '1'
|
|
ORCA_BACKGROUND_LAUNCH: '1'
|
|
run: |
|
|
ORCA_SHARD_SOURCE_SHA="$(git rev-parse HEAD)"
|
|
export ORCA_SHARD_SOURCE_SHA
|
|
pnpm exec vitest run --config config/vitest.config.ts \
|
|
--shard=${{ matrix.shard.index }}/${{ matrix.shard.count }} \
|
|
${{ inputs.runner == 'ubuntu-24.04-arm' && '--maxWorkers=4' || '' }}
|
|
|
|
- name: Upload unit shard assignment
|
|
if: always()
|
|
# Diagnostic upload outages must not change the test verdict.
|
|
continue-on-error: true
|
|
uses: actions/upload-artifact@v7
|
|
with:
|
|
name: unit-shard-node-${{ matrix.node }}-${{ matrix.shard.index }}-attempt-${{ github.run_attempt }}
|
|
path: ci-shards/
|
|
retention-days: 14
|
|
if-no-files-found: warn
|
|
|
|
selection_evidence:
|
|
needs: test
|
|
if: ${{ !cancelled() }}
|
|
continue-on-error: true
|
|
runs-on: ubuntu-slim
|
|
steps:
|
|
- uses: actions/checkout@v6
|
|
with:
|
|
sparse-checkout: config/scripts/ci-unit-selection-review.mjs
|
|
sparse-checkout-cone-mode: false
|
|
persist-credentials: false
|
|
- uses: actions/setup-node@v6
|
|
with:
|
|
node-version: '24'
|
|
- uses: actions/download-artifact@v8
|
|
with:
|
|
pattern: unit-shard-node-*-attempt-${{ github.run_attempt }}
|
|
path: unit-evidence/
|
|
- name: Compare selection with full results
|
|
continue-on-error: true
|
|
run: node config/scripts/ci-unit-selection-review.mjs unit-evidence
|
|
- uses: actions/upload-artifact@v7
|
|
if: always()
|
|
continue-on-error: true
|
|
with:
|
|
name: unit-selection-review-attempt-${{ github.run_attempt }}
|
|
path: unit-evidence/selection-review.json
|
|
retention-days: 30
|
|
|
|
relay_integration:
|
|
name: relay integration node ${{ matrix.node }}
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
node: ${{ fromJSON(inputs.node_versions) }}
|
|
runs-on: ubuntu-latest
|
|
|
|
steps:
|
|
- name: Checkout
|
|
uses: actions/checkout@v6
|
|
with:
|
|
persist-credentials: false
|
|
|
|
- uses: ./.github/actions/install-node-dependencies
|
|
with:
|
|
native-runtime: node
|
|
node-version: ${{ matrix.node }}
|
|
cache-electron-package: 'true'
|
|
cache-dependency-path: |
|
|
pnpm-lock.yaml
|
|
cloud/pnpm-lock.yaml
|
|
|
|
# These two tests import the cloud relay workspace directly. Keeping them in one job
|
|
# avoids installing and building the same workspace once per unit-test shard.
|
|
- name: Install relay integration dependencies
|
|
working-directory: cloud
|
|
run: |
|
|
npx --yes pnpm@10.24.0 --filter '@orca-cloud/relay...' install --frozen-lockfile --ignore-scripts
|
|
npx --yes pnpm@10.24.0 --filter '@orca-cloud/relay^...' build
|
|
|
|
- name: Test relay integration contracts
|
|
env:
|
|
ORCA_BACKGROUND_LAUNCH: '1'
|
|
run: >-
|
|
pnpm exec vitest run --config config/vitest.config.ts
|
|
tests/e2e/relay-region-compatibility.unit.test.ts
|
|
tests/e2e/relay-region-correction.unit.test.ts
|