fix: remove unnecessary double checks in PingBalancer (#2093)

This commit is contained in:
Aaron Chen
2026-03-19 19:07:24 +08:00
committed by GitHub
parent bb2913f6b5
commit ae80b84e22
@@ -560,18 +560,16 @@ impl PingBalancerContext {
self.best_tcp_idx.store(best_idx, Ordering::Release);
if best_idx != old_best_idx {
if best_idx != old_best_idx {
info!(
"switched best TCP server from {} to {} (best check)",
ServerConfigFormatter::new(servers[old_best_idx].server_config()),
ServerConfigFormatter::new(servers[best_idx].server_config())
);
} else {
debug!(
"kept best TCP server {} (best check)",
ServerConfigFormatter::new(servers[old_best_idx].server_config())
);
}
info!(
"switched best TCP server from {} to {} (best check)",
ServerConfigFormatter::new(servers[old_best_idx].server_config()),
ServerConfigFormatter::new(servers[best_idx].server_config())
);
} else {
debug!(
"kept best TCP server {} (best check)",
ServerConfigFormatter::new(servers[old_best_idx].server_config())
);
}
}
@@ -590,18 +588,16 @@ impl PingBalancerContext {
self.best_udp_idx.store(best_idx, Ordering::Release);
if best_idx != old_best_idx {
if best_idx != old_best_idx {
info!(
"switched best UDP server from {} to {} (best check)",
ServerConfigFormatter::new(servers[old_best_idx].server_config()),
ServerConfigFormatter::new(servers[best_idx].server_config())
);
} else {
debug!(
"kept best UDP server {} (best check)",
ServerConfigFormatter::new(servers[old_best_idx].server_config())
);
}
info!(
"switched best UDP server from {} to {} (best check)",
ServerConfigFormatter::new(servers[old_best_idx].server_config()),
ServerConfigFormatter::new(servers[best_idx].server_config())
);
} else {
debug!(
"kept best UDP server {} (best check)",
ServerConfigFormatter::new(servers[old_best_idx].server_config())
);
}
}
}