starred/tty7
1
0
Fork 0
mirror of https://github.com/l0ng-ai/tty7.git synced 2026-11-06 00:15:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(settings): light-theme controls take the page's hue instead of white (#1137)

Browse Source 
On a light theme Settings drew its dropdowns, buttons, menus, chips and switch knobs pure white, which stands out on a tinted page such as a cream theme. They are now the page colour lifted a step and made opaque, so they keep the theme's hue; a white theme still gets white controls, and dark themes are unchanged. The change is the `raised` colour in `settings/kit.rs`. `cargo test --bin tty7-app settings` gives 58 passed.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Adam Hitchcock
2026-10-09 10:49:43 +08:00
committed by GitHub
co-authored by Claude Opus 5.5
parent 45e5bde4ed
commit d9955df56b
1 changed files with 11 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ui/settings/kit.rs
+11 -5
View File
@@ -75,7 +75,13 @@ impl Tk {
let fg = theme.foreground;
let page = theme.background;
let a = |light: f32, dark_a: f32| fg.opacity(if dark { dark_a } else { light });
let white = gpui::white();
// Light controls sit a step above the page in the theme's own hue, so
// a cream theme gets cream fields and a white one stays white. Opaque:
// the page carries the window's opacity, a control should not.
let raised = Hsla {
a: 1.,
..lift(page, 0.035)
};
Self {
dark,
fg,
@@ -94,10 +100,10 @@ impl Tk {
k6: a(0.6, 0.65),
heading: a(0.9, 0.9),
nav: a(0.82, 0.8),
btn: if dark { fg.opacity(0.1) } else { white },
menu: if dark { lift(page, 0.06) } else { white },
knob: if dark { fg } else { white },
chip: if dark { fg.opacity(0.16) } else { white },
btn: if dark { fg.opacity(0.1) } else { raised },
menu: if dark { lift(page, 0.06) } else { raised },
knob: if dark { fg } else { raised },
chip: if dark { fg.opacity(0.16) } else { raised },
warn: gpui::rgb(0xe0a100).into(),
warn_text: gpui::rgb(0xb07d00).into(),
danger: gpui::rgb(0xd93025).into(),