Commit Graph
1165 Commits
Author SHA1 Message Date
l0ng-ai bd60f8c40f feat(chrome): show the window's buttons only under the pointer
The new-tab, sidebar, right-panel and app-menu tiles were on screen at
all times, so a window resting at the edge of the eye carried four
buttons nobody was reaching for. Each group now paints only while the
pointer is over the bar it belongs to: the sidebar's two follow the
rail, the trailing two follow the strip they sit in, and the collapsed
rail's pair follows the strip as well. The window mark beside them stays
put — it identifies the window rather than doing anything, and a window
that loses its mark when nobody points at it reads as a different
window.

The tiles keep their place in the layout and only lose their paint, so
revealing a group never shifts what is beside it.

The reveal is a hover flag written by a transparent sheet laid over each
region as its last child, not `group_hover` on the region itself. Group
hover asks whether the group's hitbox is the one under the pointer, and
gpui's hit test stops at the first occluding element on the way down —
tab chips and the tiles themselves all occlude, so the region stopped
counting as hovered the instant the pointer reached the button it was
revealing, and the button vanished from under the cursor. Dropping
`occlude()` from the tiles is not the way out either: they sit on the
title bar's drag area, and Windows resolves WM_NCHITTEST against the
whole hit list, so an unoccluded tile becomes draggable chrome and stops
taking clicks. Painted last, the sheet's own hitbox sits in front of
everything in the region and blocks nothing, because it is not opaque.

Claude-Session: https://claude.ai/code/session_01Mnerr8RZ23Nd4cxyfeqxiu
2026-09-08 23:27:19 +08:00
l0ng-ai 38af00fa51 Merge pull request #813 from l0ng-ai/fix/reap-seat-record
fix(daemon): let the reap wait for a seat that is coming back
2026-09-08 23:27:02 +08:00
l0ng-ai a077d47051 fix(daemon): let the reap wait for a seat that is coming back
`reap_stranded_clears_a_seat_holder_with_no_pidfile` failed on macOS CI
often enough to red a PR that touched nothing near it: after a confirmed
reap the lock file still named the dead holder.

A seat is not free the same instant its holder is confirmed dead. The
kernel releases the lock while tearing the process down, and any
descriptor a `fork` left behind holds it a moment longer — BSD `flock`
counts an inherited descriptor as another reference to the one lock
rather than a second lock, which this module already records on the
claim side (`a_reference_a_forking_neighbour_left_behind_does_not_lose_the_seat`,
and the retry loop `claim_within` exists for). `clear_record_if_free`
had no such patience: one `EWOULDBLOCK` ended the attempt, and nothing
ever revisits the file, so the dead pid stayed in it for good — where a
later pre-recording build holding the seat would make that number, by
then possibly reused, read as the holder.

It now retries for 500ms. The rule it enforces is unchanged: the record
is truncated only while the kernel says the seat is free, so a live
holder that outlasts the grace still keeps its record.

The guard was measured both ways — with the grace at zero
`clearing_the_record_waits_out_a_seat_that_is_about_to_come_back` fails
with exactly the assertion CI reported.

Claude-Session: https://claude.ai/code/session_01Mnerr8RZ23Nd4cxyfeqxiu
2026-09-08 23:12:10 +08:00
l0ng-ai ea7543490a Merge pull request #811 from l0ng-ai/feat/remote-ports
feat(ports): detect and forward what a remote pane is serving
2026-09-08 21:56:23 +08:00
l0ng-ai aafd26de72 fix(ports): restore three doc comments and name the right machine
Three items were inserted between an existing doc comment and the item it
described, so `bind_failed`, `action_strip` and one test each lost their
documentation to the newcomer above them — and the peer-procs test carried
two `#[test]` attributes as a result.

The Ports panel's fallback said "This machine's tty7-server is too old",
which reads as the local one; the server that cannot answer is the far
side's.

Claude-Session: https://claude.ai/code/session_01TPXrptp2rCGKjXaz4xE3Lq
2026-09-08 21:40:18 +08:00
l0ng-ai 03c3081a6e feat(ports): detect and forward what a remote pane is serving
A remote workspace's ports were never listed. The pane lives in the
peer's registry and QueryProcs asks this machine's daemon, which has
never heard of it, so the answer was an empty list — indistinguishable
on screen from a pane serving nothing. Add a control request so the peer
answers instead, gated on a feature so an older server says "I cannot
tell you" rather than "nothing is listening".

With the ports visible, the forward becomes something the user should
not have to think about: a port opens on a click, and a new one is
forwarded unasked, at the same number where that number is free here.
The watch runs with the panel shut, which is when a port appearing is
most worth saying something about.

Ports and Forwards were two sections that never mentioned each other; a
row is now a port, and the forward is where that row says it comes out.
Adding one by hand asks for one number instead of five fields, with the
rest of the ssh -L grammar one disclosure away.

Claude-Session: https://claude.ai/code/session_01TPXrptp2rCGKjXaz4xE3Lq
2026-09-08 21:01:50 +08:00
l0ng-ai 9842fddd4c Merge pull request #810 from l0ng-ai/feat/sidebar-custom-groups
feat(ui): custom sidebar groups a tab can be put in by hand
2026-09-08 17:44:41 +08:00
l0ng-ai 7df06538f5 Merge pull request #809 from l0ng-ai/fix/agent-icon-tint
fix(ui): give an agent's mark one colour, not one per draw site
2026-09-08 17:29:30 +08:00
l0ng-ai b063f93431 Merge origin/main into feat/sidebar-custom-groups
main's #806 changed the fold test while this branch changed
toggle_sidebar_group to take Option<&GroupKey>; the textual merge left
one call site on the old signature. Fixed here.

Claude-Session: https://claude.ai/code/session_01MS7VnqvGRtNTrJG9zxtz51
2026-09-08 17:29:10 +08:00
l0ng-ai 5c2a02f064 fix(ui): give an agent's mark one colour, not one per draw site
Two places draw an agent's mark and each decided its colour on its own:
the tab strip took a `TraeCode` branch added in #807, and the tray icon
recoloured every glyph white regardless. So TraeCode came out green on a
tab and white in the tray — one agent with two faces.

The colour now lives on `CLIAgent::icon_rgb`, next to `accent_rgb`, and
both sites read it. White for every mark that is a silhouette on its
brand colour; TraeCode is the one whose mark carries the colour itself.

`the_tray_draws_each_mark_in_the_agents_own_colour` walks `CLIAgent::ALL`
and asserts the tray's solid pixels contain the agent's own mark colour,
so a future agent whose mark is not white cannot be added to one draw
site alone.
2026-09-08 17:03:41 +08:00
l0ng-ai d72a0db420 Merge pull request #808 from l0ng-ai/fix/notice-stacking-and-form-keyboard
ui: notice stacking and form keyboard · terminal: unblock the frame · switcher: mouse can finish a Ctrl+Tab
2026-09-08 16:57:10 +08:00
ayamir fc94022ed0 feat(agent): add TraeCode CLI support (#807)
* feat(agent): add TraeCode CLI support

* fix(settings): index TraeCode agent hooks
2026-09-08 16:57:04 +08:00
l0ng-ai ca9bb747e4 fix(ui): let a folded sidebar group hide its active row too (#806)
A fold left the active tab's row on screen, so folding the group you are
working in drew a shut chevron with one row hanging under it and a header
counting rows that were not there — it reads as a list that failed to load,
not as a group you closed.

The exception existed to keep Cmd-T inside a folded group visible, since
`spawn_group` seeds a new tab with the group it came from. That cost is
taken instead: the pane area shows the fresh shell and the header count goes
up, and the row waits for the group to be opened. Auto-unfolding on spawn was
the other option and is worse — it only fires when the repo probe already hit
the cache, so a cold tab parks in Scratch and moves into its group later
without passing through it, and a magic that works half the time is harder to
read than none.

Claude-Session: https://claude.ai/code/session_01XD6R419Hy1CV1CeVZSRBf7
2026-09-08 16:56:57 +08:00
l0ng-ai 177eff5d77 fix(switcher): let the pointer finish a Ctrl+Tab gesture the keyboard started
Ctrl+Tab raises the panel and holds it up until Ctrl comes back up, which
commits whatever is highlighted. That is right while the gesture is a keyboard
one, and wrong the moment the user reaches for the mouse: letting go of Ctrl
over the workspace list slammed the panel shut and picked a tab, so switching
workspaces by hand — the thing the pointer was on its way to do — was
unreachable.

The panel now tracks where the pointer is, on the card at all and on the tab
column specifically. A release with the pointer parked on the card but off the
tab column drops the hold and leaves the panel up for the mouse to finish in;
over the tab column it still commits, because that is the ordinary gesture.
Both flags come from hover listeners, so they mean nothing until the mouse has
actually moved since the panel came up, which is exactly the distinction
wanted.

Two macOS consequences of holding Ctrl, fixed with it. A held Ctrl turns every
click into a right click, so reaching for the search box mid-gesture popped
Cut/Copy/Paste instead of placing a caret — the rows already dodged this by
dropping their own menus while the gesture is on, and the box has no menu worth
keeping either (Cmd+V still pastes). And a tab row picked with the mouse
arrives on the right button, so nothing between the row and the window may
swallow that press first.

Guarded by three tests that put the pointer on a computed point of the card
rather than a hard-coded pixel: release over the workspace list keeps the panel
up and picks nothing, release over the tab column still commits, and a
Ctrl+click on a tab row mid-gesture picks the row under the pointer rather than
the one the keyboard had reached.
2026-09-08 16:33:41 +08:00
l0ng-ai d69d8710d7 perf(terminal): never queue the frame behind the grid lock
One UI thread paints every pane in every window, and the thread holding the
grid lock is the pane's own reader part-way through feeding a batch of output
into the emulator. Waiting for it wired one pane's write speed to the frame
rate of the whole window — the read-side twin of #709, which was this same
thread parked in `write(2)` for a stalled link.

`build_grid` now takes the lock with `try_lock_unfair` and returns `None` when
it cannot have it, so that frame paints the one before it; nobody can see a
frame of lag. Unfair rather than queued on purpose: a painter that queued would
make the reader wait for a frame it is not going to get anyway, and skipping
the queue is safe precisely because it never waits. Two frames still block,
because neither has anything to fall back on — the first frame a pane ever
paints, and the frame after a resize, whose previous grid is the wrong shape.

The cells therefore have to survive a refused frame, so the shared `GRID_BUF`
thread_local is gone and each pane owns its own `grid_buf` and `grid_snap` on
the view. What made the buffer reusable was always that it is the previous
frame *of this pane*; one shared scratch buffer could not be that once a frame
could decline to rebuild it. The `buf.clear()`/`resize` moves below the lock
for the same reason.

`key_context` and `any_selection` read frame-cached copies of the terminal mode
and the selection flag, refreshed by one `try_lock` at the top of `render`
rather than one per caller. gpui matches keystrokes against the context the
last painted frame published, so the mode was already a frame-old reading even
when it locked. Anything with a real decision to make still asks the terminal
itself — `alternate_paste` is the chord that cannot be a frame late.
`sync_scrollbar` stops blocking too: the scrollbar is a picture of where the
grid is, not worth parking a window to refresh a thumb.

Guarded by `a_frame_that_cannot_have_the_grid_leaves_the_previous_one_alone`,
which reproduces "the reader has it" with no second thread and no timing —
`try_lock` fails against a lock this thread already holds.
2026-09-08 16:33:29 +08:00
l0ng-ai 15ce97d7a7 fix(ui): keep a custom group out of the workspace subject path
`subject_path_of` picks the group most of a workspace's tabs are in and hands
it back as a path. `display_name_of` then titles the window after its last
component. A custom group is a name, not a path, so a workspace grouped by
hand would have been titled `custom:work` — and one grouped as `work/urgent`
would have been chopped to `urgent`.

Only repo roots are counted now. A workspace grouped entirely by hand falls
through to a pane's cwd, which is a real path and is what the window was
titled after before any of this existed.

Claude-Session: https://claude.ai/code/session_01MS7VnqvGRtNTrJG9zxtz51
2026-09-08 16:13:18 +08:00
l0ng-ai 3133f6d0bc feat(ui): drag a tab into a custom sidebar group
A custom group you could not drag into was a box that looked like it took
drops and did not. Dragging a tab onto one now moves it there.

The reorder surface stays split one-per-group. Merging it into a single
sidebar-wide surface would have to answer "which slots may this land on",
clamp the target through the groups that refuse it, and correct the animation
for the header heights it crosses — for an insertion point that cross-group
dragging does not need. Moving between groups is filing, not sorting: land in
the group, then reorder within it if the position matters.

So this rides beside the reorder rather than through it, the way a pane
dropped on the sidebar already does. Each frame the pointer is inside a custom
group's block, that group is offered; the offer is cleared with the rest of
the drag's pending state, so letting go anywhere else drops on nothing. On
landing, a group outranks any order the drag recorded on its way out of the
one it came from — the pointer left, so the shuffle it caused before leaving
is not what was asked for.

Only custom groups register a rectangle. A repo group's membership is decided
by its tabs' cwds, so "put this tab in tty7" is a request the sidebar has no
honest way to honour, and the same goes for Scratch. Rather than let a drag
die silently over them, a lifted tab fades every block that cannot take it and
tints the one under the pointer. Two kinds of group look alike while nothing
is moving; this is where the difference becomes visible without a word of
explanation.

The tab is carried by id. A drag lasts several frames, and a tab closing in
that time — another window on the workspace, a shell exiting — would shift
every index after it and land the drop on a bystander.

Claude-Session: https://claude.ai/code/session_01MS7VnqvGRtNTrJG9zxtz51
2026-09-08 16:11:02 +08:00
l0ng-ai 16a07a6cbb feat(ui): let a tab be put in a sidebar group by hand
Groups were derived and nothing else: the sidebar read a tab's cwd and filed
it under the repo it found. Tabs that belong together for a reason the cwd
cannot see — a few ssh sessions, three forks of one project, the two panes an
investigation is spread across — had no way to sit together.

A tab can now be moved into a named group from its context menu, and the group
is remembered. What makes this safe is the previous commit: a stated group is
never recomputed, so the probe no longer drags a hand-placed tab home again.

Laid out flat rather than behind a "Move to Group ▸" submenu. Custom groups are
maintained by hand and there are never many, so a submenu would cost a second
click to reveal two or three items — and `PopupMenu::submenu` needs a `&mut
Context` that `tab_context_menu`, which reads the app entity, cannot hold at
the same time.

Three things the feature does not work without, so they ship with it:

- "Group Automatically" clears the stated group. A stated group locks the probe
  out of that tab, so without a way back a tab could be moved into a group and
  never follow its cwd again — and nothing on screen says that is what just
  happened.
- `spawn_group` inherits a custom group. ⌘T inside a folded one would otherwise
  draw nothing but the header's count going up by one, which is exactly the
  symptom #804 fixed for repo groups.
- Renaming rewrites every tab in the group in one pass, and carries the fold
  state to the new key. A group is only the set of tabs that name it, so a
  half-applied rename would not leave a half-renamed group — it would leave two.

Renaming is on the header's own context menu rather than a double click: the
first click of a double folds the group, so the name would be edited on a box
that had just shut. A repo group gets no rename — it is named after its root,
and renaming it could only lie about where its tabs are.

Custom headers carry an asterisk. It is the only thing separating them on sight
from derived ones, which matters because the two behave differently under `cd`
and because a custom group may be named after a real repo.

Dragging a tab between groups is not in this commit; the reorder surface is
still split one-per-group.

Claude-Session: https://claude.ai/code/session_01MS7VnqvGRtNTrJG9zxtz51
2026-09-08 16:01:52 +08:00
l0ng-ai 176a39e455 fix(ui): stack the floating notices; give the forms back keyboard and focus
Four things a user can walk into today, all of them an interaction the app
starts and does not finish.

The remote input notice and the ssh status strip were written out a builder
call at a time in two files, identical down to the padding and differing only
in the border colour. Each also placed itself: both `absolute` at `bottom_4`,
centred, and both children of the same container in `body_area` with nothing
arbitrating between them. A remote workspace whose ssh link had also dropped
drew them on top of each other. The shell moves to `ui::notice`, the notices
stop placing themselves, and the anchor is a column, so a second one stacks.

The managed port-forward form had no keyboard contract at all: zero
`on_key_down`, zero input subscriptions. No Return, no Escape, and it opened
cold, so adding a rule meant clicking into Bind first and committing with the
mouse. Every sibling form in the app has all three.

The four sftp edit forms took the focus into a box they owned and dropped the
box without handing the focus back — `sftp_cancel_edit` took no `Window` at
all, so it could not have. Naming a folder and pressing Escape left the caret
on an element that had stopped rendering and the next keystroke went nowhere
until you clicked. `ssh_prompt` asserts in a comment and a test that every
overlay in the app hands focus back on the way out; these were the
counterexample. Fixed on all three paths that take the form down: cancel, a
rename to the name it already had, and a successful op coming back from the
far side.

`Override` on the changed-host-key sheet — the one control in the product that
can accept a key that no longer matches, which is what a man-in-the-middle
looks like — carried no colour at all. `.danger()` had zero call sites across
the whole tree. It is disabled until "yes" is typed, so it greys until armed
and then goes red: the emphasis arrives exactly when the button does. Button
order and `.primary()` are deliberately left alone; `.primary()` means "the
recommended action" on both host-key sheets, and on this one that is Abort.
2026-09-08 15:53:51 +08:00
l0ng-ai e7e5520411 refactor(ui): give a sidebar group a stated kind, not just a path
A sidebar group was a bare `Option<PathBuf>` the sidebar recomputed from the
tab's cwd every frame. That is right for a group the sidebar derived and wrong
for one a user states by hand: the probe overwrote whatever it found, so a
hand-placed tab would be dragged back to its repo on the very next frame.

`GroupKey` names which of the two a key is. `Repo` stays the probe's to change;
`Custom` is never recomputed. One enum rather than a path plus a `pinned` flag,
because the flag and the path are then free to disagree — and because a custom
group's name is not a path at all, which is the second half of this: it must
skip `group_names`, whose job is to lengthen repo roots until they stop
colliding. Run a name through it and `work/urgent` prints as `urgent`.

The flat spelling the protocol, the session file and the fold list all need
marks a custom group with a `custom:` prefix. No absolute path can collide with
it, and every group written before this decodes as a `Repo` — so old sessions
and old daemons keep working untouched.

Under `SidebarGrouping::None` a custom group hides like everything else. It is
tempting to exempt it, but `sidebar_sections` gives Scratch a header as soon as
any keyed group exists, so exempting one would draw two headers for a user who
asked for none. The key stays on the tab; switching grouping back on brings it
straight back.

No custom group can be created yet — this is the data layer alone.

Claude-Session: https://claude.ai/code/session_01MS7VnqvGRtNTrJG9zxtz51
2026-09-08 15:52:16 +08:00
l0ng-ai 4c02ad3881 feat(ui): fold sidebar groups; stop the diff header clipping its controls (#804)
A sidebar group folds shut when its header is clicked, and stays shut across
launches. A search outranks the fold — a row a live query matches shows
whatever its group says — and so does the active tab's own row, which a fold
must never hide: `spawn_group` seeds a new tab with the group it came from, so
otherwise Cmd-T inside a folded group would draw nothing but a header count
going up by one. Folded rows register no rectangle, so a pane cannot be dropped
into a group that is shut, and the header still counts every row the group has.

Separately, the diff overlay's header stops clipping its own controls. Every
element on it but the commit subject was `flex_shrink_0`, and one of those was
a focused file's path, which is unbounded — in a docked column the two things
you can actually click were pushed off the end and clipped mid-word. The path
and the byline now yield first, ahead of the subject, because each has a second
home elsewhere in the overlay and the subject has none; the path yields
head-first so the filename is the last thing to go. `split_path_leaf` moves to
`path_display` with its tests, which is where a path's display spelling lives.
2026-09-08 12:13:03 +08:00
l0ng-ai 644945d137 style(ui): flatten the inline controls and give tooltips a real shortcut slot (#803)
* style(theme): drop the lift under every inline control

Theme::shadow gates exactly one thing -- the shadow_xs an inline control
(button, input, select trigger, checkbox, radio, slider knob) paints under
itself -- and never the drop shadow on a menu, tooltip or popover, which each
draw theirs unconditionally. Left on, every field and button in the window
carried a faint lift that nothing else here has: this chrome separates surfaces
with low-contrast fills and hairlines, so a control sitting a millimetre above
the panel was the one place claiming depth. Panels that really do float keep
their shadow.

Also bumps the gpui-component pin, and records why the switch and slider keep
their accent: both were tried on the neutral ramp the segmented controls use,
and a dark-grey "on" against a light-grey "off" turned out not to be a large
enough step to read while scanning a column of rows.

* style(tooltip): render a chrome tile's chord as a chord

chord_hint pasted a label and its shortcut into one string -- "Hide sidebar
<cmd>B" -- and handed that to Button::tooltip. Inside the card the chord then
wore the label's own size and colour, so the tooltip read as one odd sentence
rather than as a name with a shortcut beside it.

Tooltip already has a key_binding slot that sets a chord apart on the right, a
size down, in muted_foreground. What was missing was a way to hand Button a
built tooltip instead of a string; gpui-component grew tooltip_element for
that. chord_hint becomes chord_tooltip, and key_hint gains a key_stroke sibling
so a caller can reach the Keystroke rather than only its formatted text.

* style(settings): one field width, and a chevron that is not a patch

The right-hand column had three widths, each picked where it was written: text
fields 260, sliders 240, dropdowns 180. Every row still ended on the same right
edge, so on one page the difference read as controls aligned carelessly rather
than as controls of different kinds -- and moving between Appearance and
Terminal, where the mix differs, the column visibly changed width. FIELD_W is
the one number now, at 260, the widest of the three because it is the one with
a requirement behind it: a font name or a shell path has to fit untruncated.

The Program row's shell picker was a ghost button, which fills a rounded
rectangle while its menu is open, sized by hit_target to the 24px
accessibility floor -- exactly the field's inner height, so that fill met the
border top and bottom and looked like a patch stuck over the field's right end.
It now draws with no fill in any state, the way Select draws its own chevron.
Its menu was min_w(200) anchored TopRight on a chevron that sits inside the
field, so it hung off the field's right half with its left edge 110px in from
the field's own; it is now as wide as the field it drops out of.
2026-09-08 08:34:13 +08:00
l0ng-ai d16746a9af fix(deps): restore the lockfile edges #799's merge walked back (#802)
The merge for #799 re-resolved Cargo.lock and pointed twenty consumers at
older copies of dependencies that were already in the tree for other
crates. No `version =` line moved, so the change is invisible to the usual
scan of a lockfile diff, but the graph regressed:

  * 15 crates off `windows-sys 0.61.2` onto `0.60.2`
    (anstyle-query, anstyle-wincon, dirs-sys, errno, miow, muda,
     nu-ansi-term, quinn-udp, rustix, socket2, stacker, tempfile,
     tray-icon, uds_windows, winreg)
  * `winapi-util` off `windows-sys 0.61.2` all the way onto `0.48.0`
  * `gpu-allocator` off `windows 0.62.2` onto `0.58.0`
  * `iana-time-zone` off `windows-core 0.62.2` onto `0.58.0`
  * `dlib` off `libloading 0.8.9` onto `0.7.4`
  * `bindgen` off `itertools 0.13.0` onto `0.11.0`

Nothing in that PR asked for it. Its only dependency change was the gpui
fork rev, and the range it moved over touches one file in
`crates/gpui/src/elements/list.rs` and no manifest, so the resolution was
incidental to the merge rather than required by it.

This points those twenty edges back at the versions they held before, which
is what a fresh resolve picks. Every version already present in the lock
stays present: `windows-sys 0.60.2` is still there for `notify 8.2.0`,
which pins `^0.60.1`, and the older `windows`/`windows-core`/`libloading`/
`itertools` copies still serve their own consumers. So this drops no
duplicate builds; it only stops the newer copies from being compiled
alongside older ones for crates that had already moved on.

Lockfile only. No manifest and no source changes, and `cargo metadata
--locked` accepts the result without wanting to rewrite it.
2026-09-08 08:18:26 +08:00
l0ng-ai bfabe05375 fix(terminal): submit the line the shell is still holding, not an empty one (#800)
Refs #433.

Adopts the held seed at the editor's own doors rather than at submit time, so a recalled history entry, a ctrl-U, a ghost suggestion or a completion is no longer glued to the front of the gap text.

Also closes a paste-provenance hole left by #790: release_hold()/dump_hold() pushed the hold's contents into the typeahead record as plain text, dropping the paste mark, so a paste made during a gap that outlived the hold window came back looking typed and was submitted raw through the shell's binding table.
2026-09-08 00:22:24 +08:00
l0ng-ai cae2aeb74f test(ui): run the window and pane gpui tests on Windows too (#791)
Windows tty7-app tests go 1466 -> 1638 with no assertion weakened.

Also holds the SCM graph idle test's daemon end open: the moved handle closed the socket right after writing Cwd, which on Windows (loopback TcpStream with unread data) is an abortive close, so settle_graph would time out and the test would silently skip every assertion.
2026-09-07 23:55:21 +08:00
l0ng-ai 314ec61efe fix(pane): return to the pane a directional move left (#781)
Refs #738.

Keys the origin memory by the pane a move lands on as well as the direction: the per-direction array meant a two-step walk clobbered the first step, so Left, Left, Right, Right ended in the wrong pane. Entries are pruned on write when either side names a pane the tab no longer holds.
2026-09-07 23:55:10 +08:00
l0ng-ai 6f7712a5ee fix(terminal): keep a ligated run standing over its own cells (#785)
Refs #751.

The PR body's rationale is stale as of #788: build_font now emits calt:0 liga:0 clig:0 and gpui's DirectWrite backend zeroes all three, so ligatures are off by default on Windows and the Calibri office/waffle repro no longer fires with default settings. This is a fix for users who opt ligatures back on, and for any face on any platform that collapses glyph count.

Reconciled onto #783: the fit flag is gone, so seg_budget now takes ink_covers_segment and the shaping moved above the budget.
2026-09-07 23:50:55 +08:00
l0ng-ai e3630eb8a1 fix(keymap): fold a shift-punctuation chord into the key the platform reports (#784)
Refs #750; only half fixed — the US SHIFTED_GLYPHS table means secondary-shift-]/[ stay unpressable on German/French/Nordic layouts. A layout-correct fold needs KeyBinding::load with the real keyboard mapper.

Also runs the control-code guard over the folded spelling, so ctrl-shift-2 no longer installs ctrl-@ (NUL) beside it.
2026-09-07 23:47:33 +08:00
l0ng-ai 92c1ae9f26 feat(ui): make opening a new window a bindable action (#793)
Refs #710; does not close it (the request was a jump list opening a chosen existing workspace).

Registers NewWindow globally as well as on the render root, since with the tray icon on (the default) closing the last window retires to the tray and leaves no window to dispatch it.
2026-09-07 23:45:17 +08:00
l0ng-ai 661a8c2ed2 feat(ui): mark the tab whose pane is zoomed (#782)
Refs #752.
2026-09-07 23:40:03 +08:00
l0ng-ai 1f9663020f test(terminal): cover a pane's replay across a workspace switch (#789)
Refs #711. Does not fix it; #711 stays open.
2026-09-07 23:33:07 +08:00
l0ng-ai 79527ca871 feat(diff): let the pointer take a range of diff lines and copy it (#794)
Refs #721.

Reconciled onto the virtualised row list from #799: the selection is keyed on RowAt { path, RowId } rather than the flat list index, since collapsing a file above the selection re-points flat indices.
2026-09-07 23:33:02 +08:00
l0ng-ai 2de94472ec feat(tabs): name a titleless tab after its working directory (#792)
Refs #740.
2026-09-07 23:28:22 +08:00
l0ng-ai e6686d0d49 fix(switcher): name a machine whose profile is gone (#786)
Refs #485.

Also stops PaneWorkspace::route_header spelling a profile UUID on the restore path.
2026-09-07 23:09:44 +08:00
l0ng-ai eca98a1318 fix(terminal): submit a plain single line as typed, not as a paste (#790)
Refs #660.
2026-09-07 22:58:36 +08:00
l0ng-ai 28530a476a fix(git): key a repository by one spelling of its root (#796) 2026-09-07 22:55:01 +08:00
l0ng-ai 8c1315b7ab feat(ssh): edit the host from the tab that is connected to it (#801)
Refs #438.
2026-09-07 22:48:39 +08:00
l0ng-ai 23919628c0 fix(settings): say what turning off mouse reporting costs (#780) 2026-09-07 22:43:00 +08:00
l0ng-ai 7b4c6c050d fix(terminal): read a pane's paths in its own host's spelling (#795) 2026-09-07 22:42:11 +08:00
l0ng-ai 5ff0567c7d fix(terminal): keep a solo glyph inside its cell when the next one is taken (#783) 2026-09-07 22:36:58 +08:00
l0ng-ai c125803077 feat(daemon): list a Windows pane's listening ports (#787) 2026-09-07 22:31:23 +08:00
bytehelloandbytehello 42424c7737 feat(ui): add a bindable Close Window action (#773) (#778)
26.9.0's tray-retire model made closing the last window the "keep the daemon,
drop the UI process weight" gesture, but that path was reachable only from the
OS red close button: no action, no palette entry, nothing to bind. `⌘W` closes
a pane or tab, `⌘H` hides the window but keeps it in memory, and `⌘Q` stops the
server. There was nothing that closed the window and left the shells running.

`CloseWindow` is that action, with no default key — the slot is left free.
The logic that decided what a window close means (detach the workspace, and
on the last window retire to the tray if an icon is actually up, otherwise
quit) moves out of `on_window_should_close` into `prepare_window_close`, so
the button and the action share one decision instead of two that can drift.
Notably not routed through `close_window_for`: that one recycles the last
window onto a fresh workspace, which is what deleting a workspace wants and
not what closing a window wants.

It reaches the command palette, the Keybindings UI, and the reference table
of actions with no default key. In the palette it sits beside Quit, because
that pair is the whole point of the action: both end the window in front of
you and only one takes your shells with it. Their subtitles now say which —
including Quit's, which had been promising "shells keep running" while
calling `daemon::spawn::stop()`.

Co-authored-by: bytehello <bytehello@users.noreply.github.com>

https://claude.ai/code/session_01LKMZVh6mUBxXAn6v7P6JC6
2026-09-07 22:29:08 +08:00
l0ng-ai d8a0245e75 fix(terminal): name every ligature feature off, not just calt (#788) 2026-09-07 22:26:39 +08:00
dependabot[bot] cb710c4d79 deps: bump async_zip from 0.0.18 to 0.0.19 (#764)
Also bump the version requirement in Cargo.toml, which dependabot left at 0.0.18 and which made every --locked job fail.
2026-09-07 22:23:28 +08:00
l0ng-ai 081e191bb0 perf(diff-overlay): draw the patch as a virtualised row list (#799)
The overlay built its whole patch as a nested element tree on every frame:
a card per file, a header per hunk, six elements per line. gpui notifies the
view on each scroll wheel event, so a few hundred lines of diff rebuilt tens
of thousands of elements tens of times a second, and the window stalled.

Flatten the tree into one row per line in a new `diff_list` module and draw it
with `gpui::list`, which builds only the rows on screen. The rows are rebuilt
only when what they are built from changes, so scrolling no longer re-splits
hunks or re-clones every line, and a change to one file splices just the rows
it touched rather than resetting the list and losing the scroll position.

The key that decides a rebuild takes the snapshot each frame was asked about
even when it matched only by contents. A probe that finds nothing new still
lands a fresh `Arc` over an equal snapshot; a key left pointing at the old one
would go on walking the whole patch to prove the two equal, once per wheel
event, which is the cost the key exists to avoid.

A list counts a row it has not laid out yet as zero tall, which left the
scrollbar reading an 800-line patch as one viewport: its thumb filled the
track, and a drag from top to bottom travelled 248px and stopped. The rows
below the fold are counted at the 19px both views already give a line of a
patch, through `ListState::with_size_hint` — added to the gpui fork for this,
`Cargo.lock` following its `tty7` branch to `ece710e3`.

A card cannot survive that flattening — its rows are separate items now — so
the frame it drew is gone, and with it the grey header bars and hunk bands
that made the overlay the one view in the app still speaking gpui-component's
default container language. The rows take the source control panel's own
measurements instead: 26px, 10px inset, 5px radius, colour only under the
pointer. The title bar's view switch loses its border for the same reason.
2026-09-07 22:13:57 +08:00
l0ng-ai dac70ec4c8 perf(protocol): put a frame's header and payload on the wire in one write (#797)
Refs #713.
2026-09-07 22:11:06 +08:00
dependabot[bot] 6474e25a24 deps: bump the cargo-minor-patch group across 1 directory with 3 updates (#776) 2026-09-07 22:09:19 +08:00
l0ng-ai f6358494b6 test(remote): give each machine in the route-origin tests its own key (#798) 2026-09-07 22:09:07 +08:00
l0ng-ai 20b73adb2a chore(release): v26.9.1 v26.9.1 2026-09-07 21:00:55 +08:00
l0ng-ai 893172f57d fix(control): raise the dialect to v9 rather than walk it back to 7
Reverting the projects layer took CONTROL_VERSION back to 7 with the
verbs it had been raised for. The dialect that number describes is
correct — this build speaks v7's messages again, one for one — but the
number is not, because v8 is already deployed.

A version that moves backwards stops being an identity. A 7 on the wire
would mean "before projects" or "after them" depending on which build
sent it, and the handshake has nothing but the number to tell those
apart: a v8 peer would read our 7 as an older server it may keep
talking to, and every project verb it pushed would fail to decode and
drop the link.

v9 is a number no peer has seen, so a v8 peer is turned away at the
handshake instead. Nothing else changes; every other reference to the
constant is relative to it.

Claude-Session: https://claude.ai/code/session_015q6HRem76HYy33T39bp34c
2026-09-07 11:24:37 +08:00