Commit Graph
2451 Commits
Author SHA1 Message Date
Matthew Meszaros fa252aebe8 Merge pull request #443 from warmbly/feature/editor-image-links-and-buttons
feat: clickable images and a call-to-action button in the campaign body editor
2026-09-11 23:06:29 -07:00
Matthew Meszaros 8a2856fce0 Merge branch 'main' into feature/editor-image-links-and-buttons 2026-09-11 23:02:15 -07:00
Matthew Meszaros e8186e5f52 fix: the tracking service must not write Avro to a JSON consumer (#450)
* feat: make the Rust tracking publisher honour CODEC_PROVIDER on Kafka instead of always writing Avro, so a json consumer stops silently dropping every open and click, and refuse avro at boot when no Schema Registry is configured

* feat: build the tracking service's kafka feature in CI, because clippy on the default build never opens kafka.rs and that file now ships as the published tracking -kafka image

* feat: install libcurl and the rest of the librdkafka build dependencies for the tracking kafka clippy step, which fails at the first object without curl headers even with WITH_CURL=0
2026-09-11 23:00:15 -07:00
Matthew Meszaros ea8d15374e Merge branch 'main' into feature/editor-image-links-and-buttons 2026-09-11 22:56:16 -07:00
Matthew Meszaros 184cc951f0 Merge pull request #444 from warmbly/fix/issue-432
fix: make Edit with AI apply the instruction instead of rewriting the body into a fresh cold email
2026-09-11 22:52:54 -07:00
Matthew Meszaros 88b483d227 Merge branch 'main' into fix/issue-432 2026-09-11 22:47:54 -07:00
Matthew Meszaros 7d79dcc282 feat: append a -kafka image variant to every version the control plane hands a fleet node when the instance runs Kafka, so a joining worker pulls a build that can actually reach the bus instead of failing at boot (#449) 2026-09-11 22:46:02 -07:00
Matthew Meszaros 1f1112fe93 feat: drop the AI edit's parked review selection when the popover closes, because a result that changes nothing commits no new value and so leaves the layout effect nothing to run on, and the range would then be worn by whatever unrelated edit commits next and yank the caret back into a rewrite the user had already dismissed 2026-09-11 22:42:50 -07:00
Matthew Meszaros f41eac289d Merge branch 'main' into fix/issue-432 2026-09-11 22:35:43 -07:00
Matthew Meszaros 20b13dcea7 Merge branch 'main' into feature/editor-image-links-and-buttons 2026-09-11 22:34:38 -07:00
Matthew Meszaros 280a3e64ac feat: publish Kafka-linked image variants (#448)
* feat: publish Kafka-linked images for backend, consumer, worker and tracking as -kafka tag variants built per-arch on native runners, because the cgo librdkafka link cannot cross-compile on the build-go path

* feat: carry BUILT_AT inside the Go Kafka targets' build-args instead of the shared build-native block, so tracking and realtime stop warning about an unconsumed arg, and emit the matrix with printf because echo expands the separating backslash-n in some shells
2026-09-11 22:31:41 -07:00
Matthew Meszaros 4bf412c226 feat: decide the AI edit's No change signal from the value the composer will actually hold rather than from the model's answer, since a rewrite whose every added character falls past the body-length cap leaves the textarea exactly as it was and reporting Rewritten over an unchanged body is the one thing that signal exists to prevent 2026-09-11 22:30:32 -07:00
Matthew Meszaros a3aec0a9cb Merge branch 'main' into feature/editor-image-links-and-buttons 2026-09-11 22:27:11 -07:00
Matthew Meszaros ea321ebefb feat: put the AI edit's review selection back after React commits the value rather than before it, since React writes the textarea's value during commit and that write moves the cursor to the end, leaving the rewrite unselected and Undo's restored range never reaching the DOM, and strengthen the Undo test to assert the range a follow-up run targets instead of the restored value, which Undo sets regardless and which therefore pinned none of the behaviour the commit before it fixed 2026-09-11 22:22:55 -07:00
Matthew Meszaros d42aeea1aa Merge pull request #447 from warmbly/feat/kafka-topic-creation
feat: the Kafka bus creates the topics it uses
2026-09-11 21:59:41 -07:00
Matthew Meszaros e3092f2322 feat: address the review by releasing the topic lock before the broker call so one slow creation cannot stall every publish, subscribe and close for the full admin timeout, refusing to open an admin connection once the bus is closed so a publish racing past the closed check cannot resurrect a client nothing will shut, building rather than vetting the tagged Kafka backend in CI because vet does not link and a CGO backend fails at link time, and correcting the Confluent tier wording to say auto topic creation is configurable only on Dedicated 2026-09-12 06:54:34 +02:00
Matthew Meszaros af7256ac85 feat: address the third review pass on the Edit with AI fix by recording the range a rewrite replaced instead of working it back out of the lengths afterwards, because the composer's body cap can cut the tail off what was written and the old arithmetic then reconstructed a range that was never selected, so Again re-sent the wrong words and Undo restored the wrong selection, with a test mounting the real textarea host against a small cap to pin both 2026-09-11 21:33:46 -07:00
Matthew Meszaros 069ab15194 feat: address the second review pass on the Edit with AI fix by reading a markdown destination with balanced parentheses so a link the model normalises out of the angle-bracket form it was given comes back whole instead of truncated at the first paren with a stray one left in the copy, restoring only spaces and tabs around the model's answer so a selection that ran to the start of the next paragraph joins the two the way a paste would rather than gaining a blank paragraph nobody typed, and capping the completion at a flat 4096 tokens, above the 3072 it was and below the smallest completion limit in common use, because a request over a backend's own cap earns a 400 naming max_tokens that openAIProvider.adaptParams latches for the life of the process and degrades every later call 2026-09-11 21:21:40 -07:00
Matthew Meszaros 6504d9958a feat: create Kafka topics from the bus that uses them, because a worker's command topic is named after the node id issued at join time so the set is not knowable in advance, and the broker's auto-creation is off by default on Confluent Cloud and not configurable below Standard, which left a worker subscribed to a topic that did not exist receiving nothing and reporting no error, and compile the tagged Kafka build in CI so a backend nothing else builds cannot rot unnoticed 2026-09-12 06:02:49 +02:00
Matthew Meszaros 704e793c8a Merge branch 'main' into feature/editor-image-links-and-buttons 2026-09-11 20:57:20 -07:00
Matthew Meszaros 74771004c4 Merge pull request #446 from warmbly/feat/nats-max-bytes
feat: a stream size ceiling, and a latent bug in the retry path
2026-09-11 20:45:19 -07:00
Matthew Meszaros 131e9ff093 feat: give the JetStream stream a size ceiling from NATS_MAX_BYTES, accepting a byte count or a size like 2GiB, because a managed account can require every stream to declare one and Synadia's Max Bytes Required rejects creation without it, turning that refusal into an error naming the variable to set, and fix the retry path which passed a zero max age and would have recreated the stream with no age limit after a failure 2026-09-12 05:40:43 +02:00
Matthew Meszaros f7e1deeae4 Merge pull request #445 from warmbly/feat/nats-credentials
feat: support NATS JWT credentials, so a managed bus is an option
2026-09-11 20:34:10 -07:00
Matthew Meszaros f1f5249153 feat: authenticate to NATS with a user JWT and nkey seed so a managed bus like Synadia Cloud can replace a self-run one, taking the credential from a file path for containers and from a single-line base64 value for the fleet, because a node receives environment variables rather than files and the env file docker reads cannot express the multi-line credentials format, in both the Go event bus and the Rust tracking publisher 2026-09-12 05:29:09 +02:00
Matthew Meszaros 1bdd1da800 feat: address the CodeRabbit review on the Edit with AI fix by leaving the caret after text written at a collapsed position instead of in front of it (an insertion maps to itself unless the position associates rightwards, so continuing to type went before the insert), splitting the model's blocks one separator at a time so a blank paragraph the author used as spacing survives a rewrite instead of being swallowed by a greedy newline run, carrying a link destination that holds a paren or a space through in markdown's angle-bracket form rather than dropping the link, putting the author's boundary whitespace back on the model's trimmed answer in both hosts so a selection ending on a space does not glue the rewrite to the next word and "did anything change?" compares exactly what was written, and sizing the completion cap from the passage's own rune count so an 8000-rune CJK body is not truncated by a cap chosen for English 2026-09-11 20:23:53 -07:00
Matthew Meszaros 63440e9abb feat: pick a button's label colour by comparing both contrast ratios instead of testing luminance against a threshold, move the sky, emerald and amber swatches to the shade where a white label clears 4.5:1, and clamp the floating node bar inside every viewport edge rather than only the right one 2026-09-11 20:16:07 -07:00
Matthew Meszaros 6501cb599c feat: fix the "Edit with AI" rewrite in the campaign body and the unibox composer for issue #432 by running /generation/edit on a new generation.BuildEditRules system prompt through AIProvider.Complete instead of the cold-outreach writer prompt that redefined the model's role, capped it at 80 words and imposed a five-part email skeleton on every instruction, raising the completion cap so a full-body rewrite is no longer truncated at 1024 tokens and counting the request limits in runes rather than bytes, carrying merge variables, AI blocks, conditionals, form links and link destinations through the round trip in web/src/components/app/ai/richTextPassage.ts instead of deleting every atom node via doc.textBetween, replacing the passage with paste semantics so a phrase rewritten inside a sentence stops splitting its paragraph into three, saying "No change" when the model hands the passage back untouched, and clamping the floating AI card to the surface it is editing so it no longer draws outside the step drawer over the flow canvas 2026-09-11 20:04:32 -07:00
Matthew Meszaros 3ee636e2e6 Merge branch 'main' into feature/editor-image-links-and-buttons 2026-09-11 20:01:18 -07:00
Matthew Meszaros 7ff9f4d2c6 feat: let a campaign body image carry a link and add a call-to-action button to the editor toolbar, both rendered as mail-safe markup (an anchor-wrapped img, a one-cell table whose cell holds the colour and padding for Outlook's Word engine), with the plain-text half now keeping every link destination 2026-09-11 20:01:16 -07:00
Matthew Meszaros f4581108ca Merge pull request #441 from warmbly/fix/issue-434
feat: per-step open, click, reply and bounce rates in Step performance
2026-09-11 10:21:04 -07:00
Matthew Meszaros 470654f5b0 feat: say machine_clicks counts the contacts whose only clicks on a step were automated rather than counting steps, document the zero-send rule on all four step rates in the OpenAPI schema, and stop get_campaign_stats dropping the machine open and click counts from both the campaign totals and each step 2026-09-11 09:12:22 -07:00
Matthew Meszaros 35d9d3d612 feat: count automated clicks from one rolled-up bool_and(machine) per step and contact joined into both the campaign summary and the per-step stats, instead of a correlated EXISTS pair per progress row, which measured 78ms against 33ms on a 50k-lead campaign with 20k logged clicks 2026-09-11 09:01:17 -07:00
Matthew Meszaros 53d25baa29 feat: read the step performance hover as 'Opens: 1 · 20.0% of 5 sent' instead of the mis-pluralised '1 opens', by labelling each StepMetric cell with its capitalised metric name and putting the count after the colon 2026-09-11 08:57:52 -07:00
Matthew Meszaros 5087023e48 feat: give every campaign step its own open, click, reply and bounce rate in Step performance, computed against that step's own sends, with the automated share of its opens and clicks carried alongside them through GetSequenceStats, the campaign analytics API, the get_campaign_stats AI tool and the docs 2026-09-11 08:56:03 -07:00
Matthew Meszaros a542bb2c9c Merge pull request #427 from chrisedington/feat/cleanmylist-verification
Add CleanMyList email verification integration
2026-09-11 06:17:37 -07:00
Matthew Meszaros a5b0e2c2f3 Merge branch 'main' into feat/cleanmylist-verification 2026-09-11 06:12:10 -07:00
Matthew Meszaros 87e3f7006d Merge pull request #438 from warmbly/fix/scanner-timing-window
feat: operator-editable automated-engagement windows, and Barracuda in the scanner catalogue (#412 follow-up)
2026-09-11 06:09:06 -07:00
Matthew Meszaros a8c66591ce feat: correct the isInstant comment that claimed a backwards-skewed clock must not mark events human when the code does exactly that, describing the real behaviour instead: an event stamped before its dispatch means the clocks disagree, so the timing rule abstains and leaves the verdict to the user agent and source network 2026-09-11 06:04:38 -07:00
Matthew Meszaros 9698052569 Merge branch 'main' into feat/cleanmylist-verification 2026-09-11 06:03:55 -07:00
Matthew Meszaros 27c5df5072 feat: refuse a redirect that downgrades a verification request from https to http in both provider clients, since Go keeps the Authorization header across a redirect that stays on the same host and the pasted API key would go on the wire in the clear, and label the verification action from the connection id rather than the active provider, because a degraded connection reports the built-in checker while still being a connection to manage 2026-09-11 05:26:33 -07:00
Matthew Meszaros 6c6a0d1909 feat: record a verification provider's failure before marking its connection and serialize both health writes behind a per-connection gate, since the report is a database round trip and a check resolving alongside it compared itself against a failure that had not been cached yet, withdrawing a degraded state raised by a check newer than its own and leaving the connection healthy while the account was empty 2026-09-11 04:24:17 -07:00
Matthew Meszaros 2219d764cf feat: stop the tracking window live tests from resetting the instance settings row they run against, snapshotting the real document and restoring it verbatim instead of writing defaults back, and assert the untouched click window against that snapshot rather than against the shipped default, which silently required the database to start at defaults 2026-09-11 04:15:19 -07:00
Matthew Meszaros 0e8a05b6df Merge remote-tracking branch 'origin/main' into fix/scanner-timing-window 2026-09-11 04:02:06 -07:00
Matthew Meszaros 3bfbb75e8c Merge pull request #435 from rocker1166/fix/invite-mismatch-and-inbox-actions
fix(invite, unibox): mismatched-session invite 403, thread header Archive/Delete/Unread that survives a sync, Add as contact, reply To seed
2026-09-11 03:58:24 -07:00
Matthew Meszaros 9f61d070d4 feat: give the unibox thread header a way back out of a filing mistake, with Undo on the Archive and Delete toasts, Move to inbox while reading the Trash or Archive folder, and the actions disabled while one is in flight, plus stop the invite page offering Accept before it knows which account the browser is signed in as 2026-09-11 03:23:23 -07:00
Matthew Meszaros da4b89da0b feat: split a unibox message's provider placement into its own provider_folder column (migration 000146) so Archive and Delete in the thread header survive the next sync without the sync losing the ability to follow a real provider move, and narrow PATCH /unibox/folder to inbox/archive/trash behind the unibox feature gate with an audit entry so the move reaches every teammate's list live 2026-09-11 03:23:19 -07:00
Matthew Meszaros 623dc7ec61 feat: rewind the cooldown deadline as well as the observation time in the exhausted-account test so it fails when the fifteen-minute hold regresses to the ordinary one-minute lookup cache rather than only when the cache stops being deadline-keyed, and ask again next to the write whether a verifier is already connected, since validating the pasted key is a round trip to the provider and is long enough for a second connect to pass the first check 2026-09-11 03:12:28 -07:00
Matthew Meszaros 80c3c79a31 feat: add live coverage that the machine windows survive the settings document's jsonb round trip and reach the classifier, a guard that every shipped scanner CIDR is written as its own network address since the loader truncates host bits silently, and correct the comments that claimed an edit lands on the very next event when the consumer reads through a thirty second cache in its own process 2026-09-11 03:11:35 -07:00
SUMAN JANA 727ddb1482 feat: wire the unibox thread header's Mark as unread, Archive and Delete to a new PATCH /unibox/folder, add an Add as contact action for senders outside the CRM, and replace six private From-header parsers with one shared lib/helper/emailAddress that also understands the parenthesised form the IMAP sync stores, which left the reply composer's seeded To failing its own validator 2026-09-11 03:10:18 -07:00
SUMAN JANA 73f6bff2ed feat: stop a browser signed in as someone else from being offered Accept on an invite it cannot accept, comparing the signed-in address with the invited one on the invite page and offering Switch account instead, and naming both addresses in the backend's 403 so the cause is visible 2026-09-11 03:10:18 -07:00