starred/windmill
1
0
Fork 0
mirror of https://github.com/windmill-labs/windmill.git synced 2026-10-08 16:02:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: correct asset node x offset inside loops and branches (#8093)

Browse Source 
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Guilhem
2026-02-25 15:48:09 +00:00
committed by GitHub
co-authored by Claude Opus 4.6
parent 8e7ba9b33d
commit 1c9ac97f87
2 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/src/lib/components/graph/FlowGraphV2.svelte
+1 -1
View File
@@ -585,7 +585,7 @@
let assetNodesResult = $showAssets
? computeAssetNodes(
newNodes.map((n) => ({
data: { assets: n.data?.assets as AssetWithAltAccessType[] },
data: { assets: n.data?.assets as AssetWithAltAccessType[], offset: n.data?.offset as number },
id: n.id,
position: n.position
}))
frontend/src/lib/components/graph/renderers/nodes/AssetNode.svelte
+9 -7
View File
@@ -11,7 +11,7 @@
let computeAssetNodesCache: [NodeDep[], ReturnType<typeof computeAssetNodes>] | undefined
type NodeDep = {
data: object & { assets?: AssetWithAltAccessType[] | undefined }
data: object & { assets?: AssetWithAltAccessType[] | undefined; offset?: number }
id: string
position: { x: number; y: number }
}
@@ -78,13 +78,14 @@
width: inputAssetWidth,
position: {
x:
displayedInputAssets.length === 1
(node.data.offset ?? 0) +
(displayedInputAssets.length === 1
? (NODE.width - inputAssetWidth) / 2 - 10 // Ensure we see the edge
: (inputAssetWidth + inputAssetXGap) * (i - displayedInputAssets.length / 2) +
(NODE.width + inputAssetXGap) / 2 +
(overflowedInputAssets.length
? (-ASSETS_OVERFLOWED_NODE_WIDTH - inputAssetXGap) / 2
: 0),
: 0)),
y: READ_ASSET_Y_OFFSET
},
selectable: false
@@ -115,13 +116,14 @@
width: outputAssetWidth,
position: {
x:
displayedOutputAssets.length === 1
(node.data.offset ?? 0) +
(displayedOutputAssets.length === 1
? (NODE.width - outputAssetWidth) / 2 - 10 // Ensure we see the edge
: (outputAssetWidth + outputAssetXGap) * (i - displayedOutputAssets.length / 2) +
(NODE.width + outputAssetXGap) / 2 +
(overflowedOutputAssets.length
? (-ASSETS_OVERFLOWED_NODE_WIDTH - outputAssetXGap) / 2
: 0),
: 0)),
y: WRITE_ASSET_Y_OFFSET
},
selectable: false
@@ -155,7 +157,7 @@
parentId: node.id,
width: ASSETS_OVERFLOWED_NODE_WIDTH,
position: {
x: MAX_ASSET_ROW_WIDTH - ASSETS_OVERFLOWED_NODE_WIDTH - 14,
x: (node.data.offset ?? 0) + MAX_ASSET_ROW_WIDTH - ASSETS_OVERFLOWED_NODE_WIDTH - 14,
y: READ_ASSET_Y_OFFSET
}
} satisfies Node & AssetsOverflowedN)
@@ -174,7 +176,7 @@
parentId: node.id,
width: ASSETS_OVERFLOWED_NODE_WIDTH,
position: {
x: MAX_ASSET_ROW_WIDTH - ASSETS_OVERFLOWED_NODE_WIDTH - 14,
x: (node.data.offset ?? 0) + MAX_ASSET_ROW_WIDTH - ASSETS_OVERFLOWED_NODE_WIDTH - 14,
y: WRITE_ASSET_Y_OFFSET
}
} satisfies Node & AssetsOverflowedN)