starred/windmill
1
0
Fork 0
mirror of https://github.com/windmill-labs/windmill.git synced 2026-10-12 08:02:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: record the python baseline on the migration connection

Browse Source 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Ruben Fiszel
2026-10-09 20:18:07 +02:00
co-authored by Claude Opus 5.5
parent 5a2df4882d
commit 21b9ea181c
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/windmill-api/src/db.rs
+9 -3
View File
@@ -380,7 +380,8 @@ pub async fn migrate(
}
crate::live_migrations::custom_migrations(&mut custom_migrator).await?;
if let Err(e) = seed_instance_python_baseline(db, new_instance).await {
if let Err(e) = seed_instance_python_baseline(custom_migrator.connection(), new_instance).await
{
tracing::error!("Could not record the instance python baseline: {e:#}");
}
Ok(Some(crate::live_migrations::spawn_background_migrations(
@@ -393,7 +394,12 @@ pub async fn migrate(
/// is unset. Only the process that created the schema knows the instance is new, so its value
/// replaces whatever a server that started alongside it recorded; every other start leaves an
/// existing record alone and gives an instance that predates the record the frozen default.
async fn seed_instance_python_baseline(db: &DB, new_instance: bool) -> Result<(), Error> {
///
/// Runs on the migration connection: a `DATABASE_CONNECTIONS=1` pool has no second one to give.
async fn seed_instance_python_baseline(
conn: &mut PgConnection,
new_instance: bool,
) -> Result<(), Error> {
let (version, on_conflict) = if new_instance {
(
PyVAlias::NEW_INSTANCE,
@@ -408,7 +414,7 @@ async fn seed_instance_python_baseline(db: &DB, new_instance: bool) -> Result<()
))
.bind(INSTANCE_PYTHON_BASELINE_SETTING)
.bind(version.version_string())
.execute(db)
.execute(conn)
.await?;
Ok(())
}