starred/windmill
1
0
Fork 0
mirror of https://github.com/windmill-labs/windmill.git synced 2026-09-08 00:03:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: simplify codex PR review comments

Browse Source
This commit is contained in:
centdix
2026-03-31 21:08:12 +02:00
parent dd3cc60d80
commit 2455c58a25
3 changed files with 13 additions and 233 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/codex/pr-review.prompt.md
+6 -10
View File
@@ -14,14 +14,10 @@ Repository context:
- Do not modify any files.
Output requirements:
- Return JSON that matches the provided schema exactly.
- `summary` must be a short overall review summary.
- `reproduction_instructions` must be a short descriptive paragraph for a tester explaining how to navigate the app to observe the change. Do not make it a numbered list. If the diff is not enough to infer this safely, say that plainly.
- `findings` must contain only high-signal issues. Use an empty array if there are no such issues.
Finding requirements:
- Use a changed file path from this PR.
- Set `line` to the exact right-side line number on the PR head when you are confident it is part of the diff.
- If you cannot map a finding to a changed line with confidence, leave `line` as `null`.
- Keep each finding concise and specific.
- Return a GitHub PR comment in markdown, not JSON.
- Start with `## Codex Review`.
- Give a short overall summary first.
- If you found high-signal issues, list them in a short numbered list with file paths and line numbers when you know them confidently.
- If you found no high-signal issues, say that explicitly.
- End with a `### Reproduction instructions` section containing a short descriptive paragraph for a tester explaining how to navigate the app to observe the change. Do not make it a numbered list. If the diff is not enough to infer this safely, say that plainly.
- Prefer at most 10 findings.
.github/codex/review-output.schema.json
-74
View File
@@ -1,74 +0,0 @@
{
"$schema": "https://json-schema.org/draft/2020-12/schema",
"title": "CodexPullRequestReview",
"type": "object",
"additionalProperties": false,
"required": [
"summary",
"reproduction_instructions",
"findings"
],
"properties": {
"summary": {
"type": "string",
"maxLength": 4000
},
"reproduction_instructions": {
"type": "string",
"maxLength": 4000
},
"findings": {
"type": "array",
"maxItems": 10,
"items": {
"type": "object",
"additionalProperties": false,
"required": [
"title",
"body",
"path",
"line",
"severity",
"reason"
],
"properties": {
"title": {
"type": "string",
"maxLength": 200
},
"body": {
"type": "string",
"maxLength": 2000
},
"path": {
"type": "string",
"maxLength": 500
},
"line": {
"type": [
"integer",
"null"
],
"minimum": 1
},
"severity": {
"type": "string",
"enum": [
"high",
"medium",
"low"
]
},
"reason": {
"type": "string",
"enum": [
"bug",
"security",
"claude_md"
]
}
}
}
}
}
}
.github/workflows/codex-pr-review.yml
+7 -149
View File
@@ -14,9 +14,7 @@ jobs:
if: (github.event.pull_request.draft == false || github.event.pull_request.ready_for_review == true) && github.event.pull_request.head.repo.fork == false
permissions:
contents: read
pull-requests: write
outputs:
review_json: ${{ steps.run_codex.outputs.final-message }}
issues: write
steps:
- name: Check Codex configuration
id: codex_config
@@ -91,162 +89,22 @@ jobs:
with:
openai-api-key: ${{ secrets.OPENAI_API_KEY }}
prompt-file: .github/codex/pr-review.prompt.md
output-schema-file: .github/codex/review-output.schema.json
model: gpt-5.4
effort: xhigh
sandbox: read-only
safety-strategy: drop-sudo
post-review:
runs-on: ubuntu-latest
needs: codex-review
if: needs.codex-review.outputs.review_json != ''
permissions:
pull-requests: write
steps:
- name: Post Codex review
- name: Post Codex review comment
if: steps.codex_config.outputs.enabled == 'true' && steps.run_codex.outputs.final-message != ''
uses: actions/github-script@v7
env:
CODEX_REVIEW_JSON: ${{ needs.codex-review.outputs.review_json }}
PR_HEAD_SHA: ${{ github.event.pull_request.head.sha }}
CODEX_FINAL_MESSAGE: ${{ steps.run_codex.outputs.final-message }}
with:
github-token: ${{ github.token }}
script: |
const raw = process.env.CODEX_REVIEW_JSON?.trim();
if (!raw) {
core.info('No Codex review payload found.');
return;
}
let payload;
try {
payload = JSON.parse(raw);
} catch (error) {
core.setFailed(`Codex review payload was not valid JSON: ${error.message}`);
return;
}
const summary = typeof payload.summary === 'string' && payload.summary.trim()
? payload.summary.trim()
: 'No high-signal issues found.';
const reproduction = typeof payload.reproduction_instructions === 'string' && payload.reproduction_instructions.trim()
? payload.reproduction_instructions.trim()
: 'Not enough UI context in the diff to provide reproduction instructions.';
const findings = Array.isArray(payload.findings) ? payload.findings : [];
const parseChangedLines = (patch) => {
const changedLines = new Set();
if (!patch) {
return changedLines;
}
let nextNewLine = null;
for (const line of patch.split('\n')) {
const hunk = line.match(/^@@ -\d+(?:,\d+)? \+(\d+)(?:,(\d+))? @@/);
if (hunk) {
nextNewLine = Number.parseInt(hunk[1], 10);
continue;
}
if (nextNewLine === null || !line) {
continue;
}
if (line.startsWith('+') && !line.startsWith('+++')) {
changedLines.add(nextNewLine);
nextNewLine += 1;
continue;
}
if (line.startsWith('-') && !line.startsWith('---')) {
continue;
}
if (!line.startsWith('\\')) {
nextNewLine += 1;
}
}
return changedLines;
};
const files = await github.paginate(github.rest.pulls.listFiles, {
await github.rest.issues.createComment({
owner: context.repo.owner,
repo: context.repo.repo,
pull_number: context.payload.pull_request.number,
per_page: 100
issue_number: context.payload.pull_request.number,
body: process.env.CODEX_FINAL_MESSAGE,
});
const changedLinesByPath = new Map(
files.map((file) => [file.filename, parseChangedLines(file.patch)])
);
const reviewComments = [];
const summaryOnlyFindings = [];
for (const finding of findings) {
const title = typeof finding.title === 'string' ? finding.title.trim() : '';
const body = typeof finding.body === 'string' ? finding.body.trim() : '';
const path = typeof finding.path === 'string' ? finding.path.trim() : '';
const severity = typeof finding.severity === 'string' ? finding.severity.trim() : 'medium';
const reason = typeof finding.reason === 'string' ? finding.reason.trim() : 'bug';
const line = Number.isInteger(finding.line) ? finding.line : null;
if (!title || !body) {
continue;
}
const formattedBody = `[${severity}][${reason}] ${title}\n\n${body}`;
const changedLines = changedLinesByPath.get(path);
if (path && line !== null && changedLines?.has(line)) {
reviewComments.push({
path,
line,
side: 'RIGHT',
body: formattedBody
});
} else {
summaryOnlyFindings.push({
path,
line,
severity,
reason,
title,
body
});
}
}
const bodyLines = [
'## Codex Review',
'',
summary
];
if (summaryOnlyFindings.length > 0) {
bodyLines.push('', '### Additional findings');
summaryOnlyFindings.forEach((finding, index) => {
const location = finding.path
? `${finding.path}${finding.line ? `:${finding.line}` : ''}`
: 'general';
bodyLines.push(
'',
`${index + 1}. [${finding.severity}][${finding.reason}] ${location} - ${finding.title}`,
'',
finding.body
);
});
}
bodyLines.push('', '### Reproduction instructions', '', reproduction);
const reviewPayload = {
owner: context.repo.owner,
repo: context.repo.repo,
pull_number: context.payload.pull_request.number,
commit_id: process.env.PR_HEAD_SHA,
event: 'COMMENT',
body: bodyLines.join('\n')
};
if (reviewComments.length > 0) {
reviewPayload.comments = reviewComments;
}
await github.rest.pulls.createReview(reviewPayload);