starred/windmill
1
0
Fork 0
mirror of https://github.com/windmill-labs/windmill.git synced 2026-08-19 00:02:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: refetch owner lists only on row mutations, not scope changes

Browse Source 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UomUzAvrC2cto1T2QUBNnT
This commit is contained in:
Diego Imbert
2026-07-27 10:43:11 +02:00
parent 7a2e9aadf1
commit 2c1e227d29
1 changed files with 22 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/src/lib/components/home/ItemsList.svelte
+22 -15
View File
@@ -483,16 +483,23 @@
// re-fetch reloads each open owner's items in the new order/filter. When a mode
// change (owner/search) has switched the tree out of lazy mode, there's nothing to
// re-fetch — the tree remounts and groups the global stream instead.
// For row mutations (create/edit/archive/move/share): the non_empty-filtered
// owner lists depend on workspace content, so a mutation can change them —
// moving an item into a previously-empty folder must surface that folder's
// node, and emptying a folder must drop it. Scope changes (sort/kind/archived
// via the reload $effect) go through reloadItems directly: content is unchanged
// there, and the resources already refetch on their own `archived` dep.
async function onItemMutated(): Promise<void> {
folderNamesRes.refetch()
usernamesRes.refetch()
await reloadItems()
}
async function reloadItems(): Promise<void> {
// Invalidate any in-flight owner loads from the previous sort/filter so their
// late responses can't overwrite the fresh ones.
treeGen++
const toReload = treeLazyMode ? [...openOwners] : []
// The non_empty-filtered owner lists depend on workspace content, so a row
// mutation can change them: moving an item into a previously-empty folder must
// surface that folder's node, and emptying a folder must drop it.
folderNamesRes.refetch()
usernamesRes.refetch()
await loadRunnables(true)
// force: the owners are still marked loaded, so re-fetch their first page and
// swap it in place (loadOwnerItems replaces each owner's rows atomically — the
@@ -1488,11 +1495,11 @@
onExpandOwner={treeLazyMode ? loadOwnerItems : undefined}
onCollapseOwner={treeLazyMode ? collapseOwner : undefined}
isSearching={filter !== ''}
on:scriptChanged={reloadItems}
on:flowChanged={reloadItems}
on:appChanged={reloadItems}
on:rawAppChanged={reloadItems}
on:reload={reloadItems}
on:scriptChanged={onItemMutated}
on:flowChanged={onItemMutated}
on:appChanged={onItemMutated}
on:rawAppChanged={onItemMutated}
on:reload={onItemMutated}
{showCode}
/>
{/key}
@@ -1512,11 +1519,11 @@
{#each displayedItems as item, i (item.type + '/' + item.path + (item.hash ? '/' + item.hash : ''))}
<Item
{item}
on:scriptChanged={reloadItems}
on:flowChanged={reloadItems}
on:appChanged={reloadItems}
on:rawAppChanged={reloadItems}
on:reload={reloadItems}
on:scriptChanged={onItemMutated}
on:flowChanged={onItemMutated}
on:appChanged={onItemMutated}
on:rawAppChanged={onItemMutated}
on:reload={onItemMutated}
{showCode}
showEditButton={showEditButtons}
keyboardSelected={selectedIndex === i}