starred/windmill
1
0
Fork 0
mirror of https://github.com/windmill-labs/windmill.git synced 2026-08-21 08:02:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: prevent slow loading toast interval from leaking on promise cancellation (#8240)

Browse Source 
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Ruben Fiszel
2026-03-05 15:23:36 +01:00
committed by GitHub
parent 2d583826dc
commit 2e582b1bc1
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/src/lib/components/runs/useJobsLoader.svelte.ts
+6 -2
View File
@@ -133,7 +133,7 @@ export function useJobsLoader(args: () => UseJobLoaderArgs) {
])
})
}
promise = CancelablePromiseUtils.pipe(promise, () => {
promise = CancelablePromiseUtils.finallyDo(promise, () => {
if (slowStreamIntervalId) {
clearInterval(slowStreamIntervalId)
slowStreamIntervalId = undefined
@@ -161,7 +161,7 @@ export function useJobsLoader(args: () => UseJobLoaderArgs) {
)
}, 15000)
paramChangePromise = loadJobsIntern(false, size)
paramChangePromise = CancelablePromiseUtils.pipe(paramChangePromise, () => {
paramChangePromise = CancelablePromiseUtils.finallyDo(paramChangePromise, () => {
if (slowStreamIntervalId) {
clearInterval(slowStreamIntervalId)
slowStreamIntervalId = undefined
@@ -687,6 +687,10 @@ export function useJobsLoader(args: () => UseJobLoaderArgs) {
return () => {
clearTimeout(paramChangeTimeout)
paramChangePromise?.cancel()
if (slowStreamIntervalId) {
clearInterval(slowStreamIntervalId)
slowStreamIntervalId = undefined
}
}
})
$effect(() => {