starred/windmill
1
0
Fork 0
mirror of https://github.com/windmill-labs/windmill.git synced 2026-08-23 08:00:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(sessions): cancel pending draft-prompt flush on delete

Browse Source 
deleteSession removed the record from memory and IndexedDB but left the
debounced draft-prompt flush timer running; it would fire afterward and
persistTouched the deleted session back into IndexedDB, resurrecting a
draft deleted inside the 400ms window on the next reload. Clear the
per-session timer in deleteSession.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Guilhem Lemouel
2026-07-14 13:21:40 +02:00
parent 491b01c9ca
commit 3c97920ae2
2 changed files with 23 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/src/lib/components/sessions/sessionState.svelte.ts
+5
View File
@@ -942,6 +942,11 @@ export function setSessionArchived(id: string, archived: boolean) {
export function deleteSession(id: string) {
const s = sessionState.sessions.find((x) => x.id === id)
if (!s) return
// Cancel any pending draft-prompt flush: left running, its persistTouched
// would write the record back to IndexedDB after we delete it, resurrecting
// a draft deleted inside the debounce window.
clearTimeout(draftPromptFlushHandles.get(id))
draftPromptFlushHandles.delete(id)
sessionState.sessions = sessionState.sessions.filter((x) => x.id !== id)
if (sessionState.currentSessionId === id) {
sessionState.currentSessionId = sessionState.sessions[0]?.id
frontend/src/lib/components/sessions/sessionStateIndexedDb.test.ts
+18
View File
@@ -219,6 +219,24 @@ describe('sessionState IndexedDB persistence', () => {
expect(sessionState.sessions).toEqual([])
})
it('deleting a draft inside the debounce window does not resurrect it', async () => {
const user = freshUser()
userStore.set(user)
await flush()
const s = session({ id: 't4b', transient: true, pending_workspace_id: 'wsA' })
sessionState.sessions = [s]
// Schedule a flush, then delete before the 400ms timer fires. The cancelled
// timer must not write the record back to IndexedDB.
setSessionDraftPrompt('t4b', 'typed then deleted')
deleteSession('t4b')
await new Promise((r) => setTimeout(r, 500))
await rehydrate(user)
await flush()
expect(sessionState.sessions).toEqual([])
})
it('removes a session record', async () => {
const user = freshUser()
userStore.set(user)