starred/windmill
1
0
Fork 0
mirror of https://github.com/windmill-labs/windmill.git synced 2026-10-13 08:02:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: withhold listChanged from clients that cannot receive it

Browse Source 
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
hugocasa
2026-09-24 09:32:03 +02:00
co-authored by Claude Opus 5.5
parent febd20fb18
commit 51e0387d89
1 changed files with 23 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/windmill-mcp/src/server/runner.rs
+23 -3
View File
@@ -20,9 +20,9 @@ use crate::server::tools::create_tool_from_item;
use rmcp::handler::server::ServerHandler;
use rmcp::model::{
CacheScope, CallToolRequestParams, CallToolResponse, CallToolResult, ContentBlock,
Implementation, InitializeResult, ListPromptsResult, ListResourceTemplatesResult,
ListResourcesResult, ListToolsResult, PaginatedRequestParams, ProtocolVersion,
ServerCapabilities, ServerInfo, ServerNotification, SubscriptionFilter,
Implementation, InitializeRequestParams, InitializeResult, ListPromptsResult,
ListResourceTemplatesResult, ListResourcesResult, ListToolsResult, PaginatedRequestParams,
ProtocolVersion, ServerCapabilities, ServerInfo, ServerNotification, SubscriptionFilter,
};
use rmcp::service::{RequestContext, RoleServer, SubscriptionContext};
use rmcp::ErrorData;
@@ -465,6 +465,26 @@ impl<B: McpBackend> ServerHandler for Runner<B> {
Cow::Borrowed(SUPPORTED_PROTOCOL_VERSIONS)
}
/// Only the pre-2026-07-28 revisions reach `initialize`, and they have no stream
/// to receive `list_changed` on (legacy sessions are off and
/// `subscriptions/listen` is 2026-07-28 only), so the capability is withdrawn
/// here. It stays in `get_info`, which bounds what a listen filter may accept.
async fn initialize(
&self,
request: InitializeRequestParams,
context: RequestContext<RoleServer>,
) -> Result<InitializeResult, ErrorData> {
context.peer.set_peer_info(request.clone());
let mut info = self.get_info();
if SUPPORTED_PROTOCOL_VERSIONS.contains(&request.protocol_version) {
info.protocol_version = request.protocol_version;
}
if let Some(tools) = info.capabilities.tools.as_mut() {
tools.list_changed = None;
}
Ok(info)
}
fn accepted_subscription_filter(
&self,
_requested: &SubscriptionFilter,