starred/windmill
1
0
Fork 0
mirror of https://github.com/windmill-labs/windmill.git synced 2026-10-12 16:02:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(sessions): hand the form back on destroy rather than from an effect

Browse Source 
Every way the page stops carrying a call and still holds edits destroys the
component: the tab closes, or its url changes and `loadKey` remounts it. So the
hand-back is a destroy hook, not a reaction to the call changing — which needed
a key and two `untrack`s to keep its own write from re-running it.

The call is the one this form was seeded for, captured where it is seeded. By
the time the hook runs the tab has already stopped naming it, so reading it then
would find nothing to hand back to.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Guilhem Lemouel
2026-10-07 07:24:28 -07:00
co-authored by Claude Opus 5
parent 1a2821d711
commit 5369802585
2 changed files with 22 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/src/lib/components/details/FlowDetail.svelte
+11 -17
View File
@@ -391,34 +391,28 @@
// Seeded once per call rather than once per mount: a tab already showing this item is
// reused for the next request, so a latch on "seeded" would leave the previous call's
// arguments on screen.
//
// An effect because neither end of this is an event: the form does not exist when the
// reader presses Preview — the page fetches the deployed item first — so there is nothing
// to seed until `runForm` lands, and a call arriving on an already-open tab has to seed a
// form that is already mounted. `onMount` answers neither.
let seededCallId: string | undefined = undefined
let seededCall: PendingRun | undefined = undefined
$effect(() => {
if (!pendingRun || !runForm) return
if (seededCallId === pendingRun.toolCallId) return
seededCallId = pendingRun.toolCallId
seededCall = pendingRun
runForm.setArgs(pendingRun.args ?? {})
})
// The form here is a copy, so what the reader typed into it would be lost when the call
// goes back to the card — the card would then offer, and run, the arguments this page
// opened with. Written on the way out rather than per keystroke: one hand-back, whether
// the tab closed, was re-pointed, or the reader picked a version.
// opened with. Written on the way out rather than per keystroke.
//
// Keyed on the call rather than the object naming it, which is rebuilt whenever the draft
// or the posture changes: this must not re-run on either, since its own write to that
// draft would be what re-ran it.
$effect(() => {
const id = pendingRun?.toolCallId
if (!id) return
const call = untrack(() => pendingRun)
return () =>
untrack(() => {
// Only what this call's own form held. The next call for this item re-points the
// same tab without remounting, and its seeding may land first — handing this one
// the arguments of a proposal that was never on screen for it.
if (seededCallId === id) call?.handBack(args ?? {})
})
})
// The call this page was holding, not whichever one it holds now: by the time this runs
// the tab has usually already stopped naming it, which is what ended the ownership.
onDestroy(() => seededCall?.handBack(args ?? {}))
// The dev workspace's editor is not one the session panel can host, so from a preview tab
// it opens in a new browser tab, as the session editors' own entry does.
frontend/src/lib/components/details/ScriptDetail.svelte
+11 -17
View File
@@ -440,34 +440,28 @@
// Seeded once per call rather than once per mount: a tab already showing this item is
// reused for the next request, so a latch on "seeded" would leave the previous call's
// arguments on screen.
//
// An effect because neither end of this is an event: the form does not exist when the
// reader presses Preview — the page fetches the deployed item first — so there is nothing
// to seed until `runForm` lands, and a call arriving on an already-open tab has to seed a
// form that is already mounted. `onMount` answers neither.
let seededCallId: string | undefined = undefined
let seededCall: PendingRun | undefined = undefined
$effect(() => {
if (!pendingRun || !runForm) return
if (seededCallId === pendingRun.toolCallId) return
seededCallId = pendingRun.toolCallId
seededCall = pendingRun
runForm.setArgs(pendingRun.args ?? {})
})
// The form here is a copy, so what the reader typed into it would be lost when the call
// goes back to the card — the card would then offer, and run, the arguments this page
// opened with. Written on the way out rather than per keystroke: one hand-back, whether
// the tab closed, was re-pointed, or the reader picked a version.
// opened with. Written on the way out rather than per keystroke.
//
// Keyed on the call rather than the object naming it, which is rebuilt whenever the draft
// or the posture changes: this must not re-run on either, since its own write to that
// draft would be what re-ran it.
$effect(() => {
const id = pendingRun?.toolCallId
if (!id) return
const call = untrack(() => pendingRun)
return () =>
untrack(() => {
// Only what this call's own form held. The next call for this item re-points the
// same tab without remounting, and its seeding may land first — handing this one
// the arguments of a proposal that was never on screen for it.
if (seededCallId === id) call?.handBack(args ?? {})
})
})
// The call this page was holding, not whichever one it holds now: by the time this runs
// the tab has usually already stopped naming it, which is what ended the ownership.
onDestroy(() => seededCall?.handBack(args ?? {}))
// Read once on purpose: these args seed the form, so tracking the fragment would
// overwrite what the user has typed whenever it changes.