starred/windmill
1
0
Fork 0
mirror of https://github.com/windmill-labs/windmill.git synced 2026-10-18 00:03:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: keep resolved mcp secrets out of header warnings and userinfo urls

Browse Source 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
hugocasa
2026-10-12 09:47:40 +02:00
co-authored by Claude Opus 5.5
parent aba65c8d23
commit 6d0fd3be83
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/windmill-mcp/src/client/mod.rs
+7 -2
View File
@@ -66,7 +66,11 @@ impl McpClient {
)
})?;
let parsed_url = reqwest::Url::parse(&resource.url).context("Invalid MCP server URL")?;
let mut parsed_url =
reqwest::Url::parse(&resource.url).context("Invalid MCP server URL")?;
// reqwest moves userinfo to a header, so its errors print the URL without it.
let _ = parsed_url.set_username("");
let _ = parsed_url.set_password(None);
let server_url = ServerUrl {
full: parsed_url.to_string(),
origin: parsed_url.origin().ascii_serialization(),
@@ -90,7 +94,8 @@ impl McpClient {
headers.insert(name, value);
}
_ => {
tracing::warn!("Invalid header: {}={}", key, value);
// The value may be a resolved secret: name the header only.
tracing::warn!("Invalid header: {}", key);
}
}
}