starred/windmill
1
0
Fork 0
mirror of https://github.com/windmill-labs/windmill.git synced 2026-09-06 08:01:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(backend): handle better some flow edge-cases

Browse Source
This commit is contained in:
Ruben Fiszel
2022-08-04 01:13:12 +02:00
parent 07f5023bf8
commit 70de6e3972
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/src/worker_flow.rs
+4 -2
View File
@@ -139,7 +139,6 @@ pub async fn update_flow_status_after_job_completion(
let flow_job = get_queued_job(flow, w_id, &mut tx)
.await?
.ok_or_else(|| Error::InternalErr(format!("requiring flow to be in the queue")))?;
tx.commit().await?;
let stop_early = success
&& if let Some(expr) = stop_early_expr {
@@ -164,7 +163,7 @@ pub async fn update_flow_status_after_job_completion(
)
.bind(jobs.as_slice())
.bind(w_id)
.fetch(db)
.fetch(&mut tx)
.map_ok(|(v,)| v)
.try_collect::<Vec<serde_json::Value>>()
.await?;
@@ -174,6 +173,7 @@ pub async fn update_flow_status_after_job_completion(
}
_ => result.clone(),
};
tx.commit().await?;
let logs = if stop_early {
"Flow job stopped early".to_string()
@@ -192,6 +192,8 @@ pub async fn update_flow_status_after_job_completion(
.await?;
true
} else {
tx.commit().await?;
match handle_flow(&flow_job, db, result.clone()).await {
Err(err) => {
let _ = add_completed_job_error(