starred/windmill
1
0
Fork 0
mirror of https://github.com/windmill-labs/windmill.git synced 2026-08-20 08:01:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: send flow push-loop ping outside transaction so zombie monitor sees it (#9136)

Browse Source 
* fix: send flow push-loop ping outside transaction so zombie monitor sees it

* fix: keep flow push-loop ping using now() with reusable sqlx cache

---------

Co-authored-by: windmill-internal-app[bot] <1429786+windmill-internal-app[bot]@users.noreply.github.com>
Co-authored-by: Ruben Fiszel <ruben@windmill.dev>
This commit is contained in:
windmill-internal-app[bot]
2026-05-13 12:32:35 +00:00
committed by GitHub
parent 2ec1863340
commit 818cb31fbc
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/windmill-worker/src/worker_flow.rs
+5 -2
View File
@@ -3919,11 +3919,14 @@ async fn push_next_flow_job(
for (i, payload_tag) in job_payloads.into_iter().enumerate() {
if i % 100 == 0 && i != 0 {
tracing::info!(id = %flow_job.id, root_id = %job_root, "pushed (non-commited yet) first {i} subflows of {len}");
// Ping on the pool, outside `tx`, so the zombie flow monitor sees it before the
// push transaction commits — otherwise large parallel pushes can be flagged as
// zombie and trigger a cancel/push deadlock.
sqlx::query!(
"UPDATE v2_job_runtime SET ping = now() WHERE id = $1 AND ping < now()",
"UPDATE v2_job_runtime SET ping = now() WHERE id = $1",
flow_job.id,
)
.execute(&mut *tx)
.execute(db)
.warn_after_seconds(3)
.await?;
}