starred/windmill
1
0
Fork 0
mirror of https://github.com/windmill-labs/windmill.git synced 2026-09-11 16:09:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(hub-projects): bundle http auth resources, pin drafts during deploy

Browse Source 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
tristantr
2026-07-13 14:55:22 +02:00
co-authored by Claude Fable 5
parent 3a8ee64ec4
commit 8d44294570
1 changed files with 21 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/src/lib/components/workspaceSettings/DeployToHub.svelte
+21 -8
View File
@@ -115,7 +115,8 @@
http: {
badge: 'HTTP',
route: 'routes',
note: 'Webhook URL regenerates on import — re-register with the external service.'
note: 'Webhook URL regenerates on import — re-register with the external service.',
resourceField: 'authentication_resource_path'
},
websocket: {
badge: 'WebSocket',
@@ -1192,9 +1193,13 @@
async function deployAll(workspace: string) {
const slug = hubSlug
// Snapshot the selection up-front so a workspace switch mid-deploy can't
// write stale state into the new workspace.
// write stale state into the new workspace. Migration drafts are global
// mutable state cleared by the workspace/folder reset effect — pin them too,
// so the deploy publishes the drafts the user confirmed.
const folder = folderProp
const itemsSnapshot = selectedItems.slice()
const triggersSnapshot = relevantTriggers.slice()
const migrationsSnapshot = migrationDrafts.slice()
hubItemIds = {}
deploying = true
let failures = 0
@@ -1222,6 +1227,10 @@
)
}
// Bundle building is slow — bail before the first Hub write if the user
// switched workspace or folder in the meantime.
if ($workspaceStore !== workspace || folderProp !== folder) return
// Types come from $res: stubs AND schema inputs (resource-<type>).
const inputTypes = bundle.items
.flatMap((i) => typesFromSchema(i.schema))
@@ -1258,9 +1267,10 @@
}
for (const it of bundle.items) {
// Stop writing item status / Hub IDs into a workspace the user has
// switched away from mid-publish.
if ($workspaceStore !== workspace) return
// Stop writing item status / Hub IDs into a workspace or folder the
// user has switched away from mid-publish (postHub targets the live
// folderProp, so continuing would publish into the wrong project).
if ($workspaceStore !== workspace || folderProp !== folder) return
const key = `${it.kind}:${it.path}`
deploymentStatus = { ...deploymentStatus, [key]: { status: 'loading' } }
try {
@@ -1292,6 +1302,7 @@
}
})
)
if ($workspaceStore !== workspace || folderProp !== folder) return
try {
await pushTriggers(workspace, slug, resourcePathMap, triggersSnapshot)
} catch (e: any) {
@@ -1304,7 +1315,7 @@
// don't persist.
try {
await postHub(workspace, '/hub/migrations', {
migrations: migrationDrafts.map((m) => ({
migrations: migrationsSnapshot.map((m) => ({
datatable_name: m.datatable_name,
sql: m.sql,
sql_down: m.sql_down,
@@ -1318,7 +1329,7 @@
}
await sleep(150)
if ($workspaceStore !== workspace) return
if ($workspaceStore !== workspace || folderProp !== folder) return
deploymentStatus = {}
recordings = {}
// Deterministic baseline so a transient Hub read failure can't leave the
@@ -2507,7 +2518,9 @@
<Button
variant="accent"
loading={deploying}
disabled={!hubName.trim() || (!effectiveSlug && !isValidSlug(sanitizeSlug(hubName)))}
disabled={!hubName.trim() ||
(!effectiveSlug && !isValidSlug(sanitizeSlug(hubName))) ||
migrationsGenerating}
startIcon={{ icon: Cloud }}
onclick={confirmBundle}
>