mirror of
https://github.com/windmill-labs/windmill.git
synced 2026-10-13 16:02:59 +00:00
docs(sessions): trim three comments and drop a claim the per-item keying made false
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KcyBRxE8j3ujCYkum9KrC4
This commit is contained in:
co-authored by
Claude Opus 5
parent
8202413bb9
commit
8df960ebd2
@@ -145,11 +145,10 @@
|
||||
</script>
|
||||
|
||||
{#snippet editorBody()}
|
||||
<!-- ResourceEditor reads `path` once, at init, and every fetch/draft handle/save
|
||||
inside it goes through that captured value — so it has to be remounted, not
|
||||
re-pointed, whenever what this host shows changes. `editorGeneration` covers
|
||||
the changes the path alone doesn't name: restoring an old version replaces
|
||||
the deployed value the mounted editor still holds as its baseline. -->
|
||||
<!-- ResourceEditor captures `path` at init and routes every fetch, draft handle and
|
||||
save through it, so it must be remounted rather than re-pointed.
|
||||
`editorGeneration` covers what the path doesn't name: a restore replaces the
|
||||
deployed value the mounted editor still holds as its baseline. -->
|
||||
{#key `${path ?? ''}#${editorGeneration}`}
|
||||
{#await import('./ResourceEditor.svelte')}
|
||||
<Loader2 class="animate-spin" />
|
||||
|
||||
@@ -207,9 +207,9 @@
|
||||
: undefined
|
||||
)
|
||||
|
||||
// Follow a rename: the editor stays mounted and keeps editing the item, but the
|
||||
// tab, its label, the chat's ACTIVE PREVIEW and the draft key all address it by
|
||||
// path — so they have to move with it, or they name an item that no longer exists.
|
||||
// Follow a rename: the tab, its label, the chat's ACTIVE PREVIEW and the draft
|
||||
// key all address the item by path, so they have to move with it or they name an
|
||||
// item that no longer exists.
|
||||
const retargetTo = $derived(
|
||||
slot.kind === 'entity' && runtime
|
||||
? (kind: EntityEditorKind, newPath: string, fromPath: string, fromWs: string) => {
|
||||
|
||||
@@ -61,11 +61,10 @@
|
||||
live editor would leave the previous schedule's load to finish into the new
|
||||
one's form and deployed baseline. -->
|
||||
{#key `${path}#${generation}`}
|
||||
<!-- No `allowDraft`: that switches the toolbar to the trigger-panel branch,
|
||||
whose deploy button is gated on the `trigger`/`isDeployed` a script or
|
||||
flow editor supplies for a trigger staged next to it. A standalone tab
|
||||
has neither, which leaves the schedule permanently unsavable — its
|
||||
situation is the drawer's, whose plain Save this restores. -->
|
||||
<!-- No `allowDraft`: it switches the toolbar to the trigger-panel branch, whose
|
||||
deploy button is gated on the `trigger`/`isDeployed` a script or flow editor
|
||||
supplies alongside a staged trigger. A standalone tab has neither, and would
|
||||
be left permanently unsavable; this keeps the drawer's plain Save. -->
|
||||
<ScheduleEditorInner
|
||||
bind:this={editor}
|
||||
useDrawer={false}
|
||||
|
||||
Reference in New Issue
Block a user